mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
5a759d31f7
Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char*) to (char*) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."*' is not anymore same as table_name.* - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)
125 lines
2.7 KiB
C++
125 lines
2.7 KiB
C++
/* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
#ifndef SQL_TABLE_MAINTENANCE_H
|
|
#define SQL_TABLE_MAINTENANCE_H
|
|
|
|
/* Must be able to hold ALTER TABLE t PARTITION BY ... KEY ALGORITHM = 1 ... */
|
|
#define SQL_ADMIN_MSG_TEXT_SIZE (128 * 1024)
|
|
|
|
bool mysql_assign_to_keycache(THD* thd, TABLE_LIST* table_list,
|
|
const LEX_CSTRING *key_cache_name);
|
|
bool mysql_preload_keys(THD* thd, TABLE_LIST* table_list);
|
|
int reassign_keycache_tables(THD* thd, KEY_CACHE *src_cache,
|
|
KEY_CACHE *dst_cache);
|
|
|
|
/**
|
|
Sql_cmd_analyze_table represents the ANALYZE TABLE statement.
|
|
*/
|
|
class Sql_cmd_analyze_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a ANALYZE TABLE statement.
|
|
*/
|
|
Sql_cmd_analyze_table()
|
|
{}
|
|
|
|
~Sql_cmd_analyze_table()
|
|
{}
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_ANALYZE;
|
|
}
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
Sql_cmd_check_table represents the CHECK TABLE statement.
|
|
*/
|
|
class Sql_cmd_check_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a CHECK TABLE statement.
|
|
*/
|
|
Sql_cmd_check_table()
|
|
{}
|
|
|
|
~Sql_cmd_check_table()
|
|
{}
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_CHECK;
|
|
}
|
|
};
|
|
|
|
|
|
/**
|
|
Sql_cmd_optimize_table represents the OPTIMIZE TABLE statement.
|
|
*/
|
|
class Sql_cmd_optimize_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a OPTIMIZE TABLE statement.
|
|
*/
|
|
Sql_cmd_optimize_table()
|
|
{}
|
|
|
|
~Sql_cmd_optimize_table()
|
|
{}
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_OPTIMIZE;
|
|
}
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
Sql_cmd_repair_table represents the REPAIR TABLE statement.
|
|
*/
|
|
class Sql_cmd_repair_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a REPAIR TABLE statement.
|
|
*/
|
|
Sql_cmd_repair_table()
|
|
{}
|
|
|
|
~Sql_cmd_repair_table()
|
|
{}
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_REPAIR;
|
|
}
|
|
};
|
|
|
|
#endif
|