mirror of
https://github.com/MariaDB/server.git
synced 2026-05-04 22:25:32 +02:00
BitKeeper/deleted/.del-factory.h~c1679505d3a6dd53:
Delete: server-tools/instance-manager/factory.h
BitKeeper/deleted/.del-factory.cc~6836cccd4cd35b4d:
Delete: server-tools/instance-manager/factory.cc
server-tools/instance-manager/Makefile.am:
- remove Commands_factory: it'll be needed when we add support
for NNTP/HTTP connections, currently it only adds unnecessary
complexity.
server-tools/instance-manager/commands.cc:
- fix coding style: no else after return; fix comments, make
one place a bit faster.
server-tools/instance-manager/guardian.cc:
- fix coding style and comments.
- we must register the current thread in the thread registry
before entering pthread_cond_timedwait, because at shutdown
the thread registry will try to kick out of wait all blocked
threads. Unregistered threads are not awakened by the registry.
This fixes the failinig assert in Thread_registry::~Thread_registry
at shutdown, when shutdown is requested and there is an
instance monitored by Guardian.
server-tools/instance-manager/guardian.h:
- fix coding style: enums must start with enum_
server-tools/instance-manager/instance.h:
- move comment to the variable it comments
server-tools/instance-manager/instance_map.cc:
- cleanup
server-tools/instance-manager/instance_options.cc:
- cleanup; no else after return (fix coding style).
server-tools/instance-manager/manager.cc:
- fix alignment; make some code easier to read.
server-tools/instance-manager/mysql_connection.cc:
- remove Commands_factory
server-tools/instance-manager/options.cc:
- fix a possible crash when the instance manager is started with
--no-defaults --defaults-file=~/.my.cnf: if we return
without cloning saved_argv by calling load_defaults, Options::cleanup
will crash on attempt to free_defaults(saved_argv);
server-tools/instance-manager/parse.cc:
- get rid of Commands_factory
server-tools/instance-manager/parse.h:
- get rid of Commands_factory
server-tools/instance-manager/parse_output.cc:
- in parse_output_and_get_value return error also if the specified
pattern was not found, or the command failed to execute.
server-tools/instance-manager/portability.h:
- fix coding style (// comments are allowed only at ends of lines)
server-tools/instance-manager/thread_registry.cc:
- implement Thread_registry::cond_timedwait
server-tools/instance-manager/thread_registry.h:
- implement Thread_registry::cond_timedwait; remove
unused out parameter from Thread_registry::cond_wait.
server-tools/instance-manager/user_map.cc:
- safety: newline can take 2 bytes.
117 lines
3.5 KiB
C++
117 lines
3.5 KiB
C++
/* Copyright (C) 2004 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#include <my_global.h>
|
|
#include "parse.h"
|
|
#include "parse_output.h"
|
|
|
|
#include <stdio.h>
|
|
#include <my_sys.h>
|
|
#include <m_string.h>
|
|
#include "portability.h"
|
|
|
|
|
|
/*
|
|
Parse output of the given command
|
|
|
|
SYNOPSYS
|
|
parse_output_and_get_value()
|
|
|
|
command the command to execue with popen.
|
|
word the word to look for (usually an option name)
|
|
result the buffer to store the next word (option value)
|
|
input_buffer_len self-explanatory
|
|
flag this equals to GET_LINE if we want to get all the line after
|
|
the matched word and GET_VALUE otherwise.
|
|
|
|
DESCRIPTION
|
|
|
|
Parse output of the "command". Find the "word" and return the next one
|
|
if flag is GET_VALUE. Return the rest of the parsed string otherwise.
|
|
|
|
RETURN
|
|
0 - ok, the word has been found
|
|
1 - error occured or the word is not found
|
|
*/
|
|
|
|
int parse_output_and_get_value(const char *command, const char *word,
|
|
char *result, size_t input_buffer_len,
|
|
uint flag)
|
|
{
|
|
FILE *output;
|
|
uint wordlen;
|
|
/* should be enough to store the string from the output */
|
|
enum { MAX_LINE_LEN= 512 };
|
|
char linebuf[MAX_LINE_LEN];
|
|
int rc= 1;
|
|
|
|
wordlen= strlen(word);
|
|
|
|
/*
|
|
Successful return of popen does not tell us whether the command has been
|
|
executed successfully: if the command was not found, we'll get EOF
|
|
when reading the output buffer below.
|
|
*/
|
|
if (!(output= popen(command, "r")))
|
|
goto err;
|
|
|
|
/*
|
|
We want fully buffered stream. We also want system to
|
|
allocate appropriate buffer.
|
|
*/
|
|
setvbuf(output, NULL, _IOFBF, 0);
|
|
|
|
while (fgets(linebuf, sizeof(linebuf) - 1, output))
|
|
{
|
|
uint found_word_len= 0;
|
|
char *linep= linebuf;
|
|
|
|
linebuf[sizeof(linebuf) - 1]= '\0'; /* safety */
|
|
|
|
/*
|
|
Get the word, which might contain non-alphanumeric characters. (Usually
|
|
these are '/', '-' and '.' in the path expressions and filenames)
|
|
*/
|
|
get_word((const char **) &linep, &found_word_len, NONSPACE);
|
|
if (!strncmp(word, linep, wordlen))
|
|
{
|
|
/*
|
|
If we have found the word, return the next one (this is usually
|
|
an option value) or the whole line (if flag)
|
|
*/
|
|
linep+= found_word_len; /* swallow the previous one */
|
|
if (flag & GET_VALUE)
|
|
{
|
|
get_word((const char **) &linep, &found_word_len, NONSPACE);
|
|
if (input_buffer_len <= found_word_len)
|
|
goto err;
|
|
strmake(result, linep, found_word_len);
|
|
}
|
|
else /* currently there are only two options */
|
|
strmake(result, linep, input_buffer_len - 1);
|
|
rc= 0;
|
|
break;
|
|
}
|
|
}
|
|
|
|
pclose:
|
|
/* we are not interested in the termination status */
|
|
pclose(output);
|
|
|
|
err:
|
|
return rc;
|
|
}
|
|
|