mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 05:52:27 +01:00
d4088df5e9
Post-review version. Some minor review fixes, but also changed the way some errors are handled: Don't return specific parse errors; instead always use the more general "table corrupt" error (amended accordingly). mysql-test/r/sp-destruct.result: Updated results. mysql-test/r/sp-error.result: Updated for fully qualified name in "no return" error message. mysql-test/t/sp-destruct.test: Adopted the more consistent error handling for a corrupted mysql.proc table. (No more "parse error" et al). sql/share/errmsg.txt: Changed ER_SP_PROC_TABLE_CORRUPT to be more explicit. sql/sp.cc: Review fixes. Changed the handling of parse errors, and added the routine name to the "table corrupt" error message. sql/sql_base.cc: Review changes: Change error tests and added comments. sql/sql_parse.cc: Mored ER_SP_NORETURN test of functions to sql_yacc.yy for more general error handling. sql/sql_yacc.yy: Mored ER_SP_NORETURN test of functions from sql_parse.cc for more general error handling.
124 lines
3.3 KiB
Text
124 lines
3.3 KiB
Text
#
|
|
# Destructive stored procedure tests
|
|
#
|
|
# We do horrible things to the mysql.proc table here, so any unexpected
|
|
# failures here might leave it in an undetermined state.
|
|
#
|
|
# In the case of trouble you might want to skip this.
|
|
#
|
|
|
|
# We're using --system things that probably doesn't work on Windows.
|
|
--source include/not_windows.inc
|
|
|
|
# Backup proc table
|
|
--system rm -rf var/master-data/mysql/backup
|
|
--system mkdir var/master-data/mysql/backup
|
|
--system cp var/master-data/mysql/proc.* var/master-data/mysql/backup/
|
|
|
|
use test;
|
|
|
|
--disable_warnings
|
|
drop procedure if exists bug14233;
|
|
drop function if exists bug14233;
|
|
drop table if exists t1;
|
|
drop view if exists v1;
|
|
--enable_warnings
|
|
|
|
create procedure bug14233()
|
|
set @x = 42;
|
|
|
|
create function bug14233_f() returns int
|
|
return 42;
|
|
|
|
create table t1 (id int);
|
|
create trigger t1_ai after insert on t1 for each row call bug14233();
|
|
|
|
# Unsupported tampering with the mysql.proc definition
|
|
alter table mysql.proc drop type;
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
call bug14233();
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
create view v1 as select bug14233_f();
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
insert into t1 values (0);
|
|
|
|
flush table mysql.proc;
|
|
|
|
# Thrashing the .frm file
|
|
--system echo 'saljdlfa' > var/master-data/mysql/proc.frm
|
|
--error ER_NOT_FORM_FILE
|
|
call bug14233();
|
|
--error ER_NOT_FORM_FILE
|
|
create view v1 as select bug14233_f();
|
|
--error ER_NOT_FORM_FILE
|
|
insert into t1 values (0);
|
|
|
|
|
|
flush table mysql.proc;
|
|
|
|
# Drop the mysql.proc table
|
|
--system rm var/master-data/mysql/proc.*
|
|
--error ER_NO_SUCH_TABLE
|
|
call bug14233();
|
|
--error ER_NO_SUCH_TABLE
|
|
create view v1 as select bug14233_f();
|
|
--error ER_NO_SUCH_TABLE
|
|
insert into t1 values (0);
|
|
|
|
# Restore mysql.proc
|
|
--system mv var/master-data/mysql/backup/* var/master-data/mysql/
|
|
--system rmdir var/master-data/mysql/backup
|
|
|
|
flush table mysql.proc;
|
|
flush privileges;
|
|
|
|
delete from mysql.proc where name like 'bug14233%';
|
|
|
|
# Unsupported editing of mysql.proc, circumventing checks in "create ..."
|
|
insert into mysql.proc
|
|
(
|
|
db, name, type, specific_name, language, sql_data_access, is_deterministic,
|
|
security_type, param_list, returns, body, definer, created, modified,
|
|
sql_mode, comment
|
|
)
|
|
values
|
|
(
|
|
'test', 'bug14233_1', 'FUNCTION', 'bug14233_1', 'SQL', 'READS_SQL_DATA', 'NO',
|
|
'DEFINER', '', 'int(10)',
|
|
'select count(*) from mysql.user',
|
|
'root@localhost', NOW() , '0000-00-00 00:00:00', '', ''
|
|
),
|
|
(
|
|
'test', 'bug14233_2', 'FUNCTION', 'bug14233_2', 'SQL', 'READS_SQL_DATA', 'NO',
|
|
'DEFINER', '', 'int(10)',
|
|
'begin declare x int; select count(*) into x from mysql.user; end',
|
|
'root@localhost', NOW() , '0000-00-00 00:00:00', '', ''
|
|
),
|
|
(
|
|
'test', 'bug14233_3', 'PROCEDURE', 'bug14233_3', 'SQL', 'READS_SQL_DATA','NO',
|
|
'DEFINER', '', '',
|
|
'alksj wpsj sa ^#!@ ',
|
|
'root@localhost', NOW() , '0000-00-00 00:00:00', '', ''
|
|
);
|
|
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
select bug14233_1();
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
create view v1 as select bug14233_1();
|
|
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
select bug14233_2();
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
create view v1 as select bug14233_2();
|
|
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
call bug14233_3();
|
|
drop trigger t1_ai;
|
|
create trigger t1_ai after insert on t1 for each row call bug14233_3();
|
|
--error ER_SP_PROC_TABLE_CORRUPT
|
|
insert into t1 values (0);
|
|
|
|
# Clean-up
|
|
delete from mysql.proc where name like 'bug14233%';
|
|
drop trigger t1_ai;
|
|
drop table t1;
|