mirror of
https://github.com/MariaDB/server.git
synced 2025-01-21 22:34:18 +01:00
c4f5326bb7
The problem was that my_hash_sort didn't properly delete end-space characters properly, so strings that should compare identically was seen as different strings. (Space was handled correctly, but not NBSP) This caused duplicate key errors when a heap table was converted to Aria as part of overflow in group by. Fixed by removing all characters that compares as end space when creating a hash. Other things: - Fixed that --sorted_results also works for errors in mysqltest. - Speed up hash by not comparing strings that has different hash. - Speed up many my_hash_sort functions by using registers to calculate hash instead of pointers. This was previously done for some functions, but not for all. - Made a macro of the hash function, to simplify code and to be able to experiment with new hash functions. client/mysqltest.cc: Fixed that --sorted_results also works for error messages. mysql-test/r/ctype_partitions.result: New test to ensure that partitions on hash works mysql-test/suite/multi_source/gtid.result: Updated result mysql-test/suite/multi_source/gtid.test: Test that --sorted_result works for error messages mysql-test/suite/multi_source/gtid_ignore_duplicates.result: Updated result mysql-test/suite/multi_source/gtid_ignore_duplicates.test: Updated result mysql-test/suite/multi_source/load_data.result: Updated result mysql-test/suite/multi_source/load_data.test: Updated result mysql-test/t/ctype_partitions.test: New test to ensure that partitions on hash works storage/heap/hp_write.c: Speed up hash by not comparing strings that has different hash. storage/maria/ma_check.c: Extra debug strings/ctype-bin.c: Use macro for hash function strings/ctype-latin1.c: Use macro for hash function Use registers to calculate hash (speedup) strings/ctype-mb.c: Use macro for hash function Use registers to calculate hash (speedup) strings/ctype-simple.c: Use macro for hash function Use same variable names as in other my_hash_sort functions. Update my_hash_sort_simple() to properly remove end space (patch by Bar) strings/ctype-uca.c: Ignore duplicated space inside strings and end space in my_hash_sort_uca(). This fixed MDEV-6255 Use macro for hash function Use registers to calculate hash (speedup) strings/ctype-ucs2.c: Use macro for hash function Use registers to calculate hash (speedup) strings/ctype-utf8.c: Use macro for hash function Use registers to calculate hash (speedup) strings/strings_def.h: Made a macro of the hash function, to simplify code and to be able to experiment with new hash functions. |
||
---|---|---|
.. | ||
unittest | ||
CMakeLists.txt | ||
file_formats.txt | ||
ft_maria.c | ||
ha_maria.cc | ||
ha_maria.h | ||
lockman.c | ||
lockman.h | ||
ma_bitmap.c | ||
ma_blockrec.c | ||
ma_blockrec.h | ||
ma_cache.c | ||
ma_changed.c | ||
ma_check.c | ||
ma_check_standalone.h | ||
ma_checkpoint.c | ||
ma_checkpoint.h | ||
ma_checksum.c | ||
ma_close.c | ||
ma_commit.c | ||
ma_commit.h | ||
ma_control_file.c | ||
ma_control_file.h | ||
ma_create.c | ||
ma_dbug.c | ||
ma_delete.c | ||
ma_delete_all.c | ||
ma_delete_table.c | ||
ma_dynrec.c | ||
ma_extra.c | ||
ma_ft_boolean_search.c | ||
ma_ft_eval.c | ||
ma_ft_eval.h | ||
ma_ft_nlq_search.c | ||
ma_ft_parser.c | ||
ma_ft_stem.c | ||
ma_ft_test1.c | ||
ma_ft_test1.h | ||
ma_ft_update.c | ||
ma_ftdefs.h | ||
ma_fulltext.h | ||
ma_info.c | ||
ma_init.c | ||
ma_key.c | ||
ma_key_recover.c | ||
ma_key_recover.h | ||
ma_keycache.c | ||
ma_locking.c | ||
ma_loghandler.c | ||
ma_loghandler.h | ||
ma_loghandler_lsn.h | ||
ma_norec.c | ||
ma_open.c | ||
ma_packrec.c | ||
ma_page.c | ||
ma_pagecache.c | ||
ma_pagecache.h | ||
ma_pagecaches.c | ||
ma_pagecrc.c | ||
ma_panic.c | ||
ma_preload.c | ||
ma_range.c | ||
ma_recovery.c | ||
ma_recovery.h | ||
ma_recovery_util.c | ||
ma_recovery_util.h | ||
ma_rename.c | ||
ma_rfirst.c | ||
ma_rkey.c | ||
ma_rlast.c | ||
ma_rnext.c | ||
ma_rnext_same.c | ||
ma_rprev.c | ||
ma_rrnd.c | ||
ma_rsame.c | ||
ma_rsamepos.c | ||
ma_rt_index.c | ||
ma_rt_index.h | ||
ma_rt_key.c | ||
ma_rt_key.h | ||
ma_rt_mbr.c | ||
ma_rt_mbr.h | ||
ma_rt_split.c | ||
ma_rt_test.c | ||
ma_scan.c | ||
ma_search.c | ||
ma_servicethread.c | ||
ma_servicethread.h | ||
ma_sort.c | ||
ma_sp_defs.h | ||
ma_sp_key.c | ||
ma_sp_test.c | ||
ma_state.c | ||
ma_state.h | ||
ma_static.c | ||
ma_statrec.c | ||
ma_test1.c | ||
ma_test2.c | ||
ma_test3.c | ||
ma_test_all.res | ||
ma_test_all.sh | ||
ma_test_big.sh | ||
ma_test_force_start.pl | ||
ma_test_recovery | ||
ma_unique.c | ||
ma_update.c | ||
ma_write.c | ||
maria_chk.c | ||
maria_def.h | ||
maria_dump_log.c | ||
maria_ftdump.c | ||
maria_pack.c | ||
maria_read_log.c | ||
maria_rename.sh | ||
tablockman.c | ||
tablockman.h | ||
test_pack | ||
trnman.c | ||
trnman.h | ||
trnman_public.h |