mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
e080080711
Bug#31621: Windows server hanging during shutdown using named pipes
and idle connection
Problem: when idle pipe connection is forcefully closed with KILL
statement or when the server goes down, thread that is closing connection
would hang infinitely in CloseHandle(). The reason for the hang is that
named pipe operations are performed synchronously. In this mode all IOs
on pipe are serialized, that is CloseHandle() will not abort ReadFile()
in another thread, but wait for ReadFile() to complete.
The fix implements asynchrnous mode for named pipes, where operation of file
are not synchronized. Read/Write operation would fire an async IO and wait for
either IO completion or timeout.
Note, that with this patch timeouts are properly handled for named pipes.
Post-review: Win32 timeout code has been fixed for named pipes and shared
memory. We do not store pointer to NET in vio structure, only the read and
write timeouts.
include/violite.h:
Add pipe_overlapped to Vio structure for async IO for named pipes.
sql-common/client.c:
Use asynchronous pipe IO.
sql/mysqld.cc:
Use asynchronous pipe IO.
vio/vio.c:
-Refactor timeouts for win32 protocols: shared memory and named pipes.
Store read/write timeout in VIO structure, instead of storing pointer
to NET. New function vio_win32_timeout called indirectly via
vio_timeout changes these values.
vio/vio_priv.h:
Remove vio_ignore_timeout.
Add vio_win32_timeout to be used for named pipes and shared memory.
vio/viosocket.c:
Use async IO for named pipes.
After issuing IO, wait for either IO completion, pipe_close_event
or timeout.
Refactor timeouts for named pipe and shared memory.
43 lines
1.4 KiB
C
43 lines
1.4 KiB
C
/* Copyright (C) 2003 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Structures and functions private to the vio package */
|
|
|
|
#define DONT_MAP_VIO
|
|
#include <my_global.h>
|
|
#include <mysql_com.h>
|
|
#include <my_sys.h>
|
|
#include <m_string.h>
|
|
#include <violite.h>
|
|
|
|
#ifdef _WIN32
|
|
void vio_win32_timeout(Vio *vio, uint which, uint timeout);
|
|
#endif
|
|
|
|
void vio_timeout(Vio *vio,uint which, uint timeout);
|
|
|
|
#ifdef HAVE_OPENSSL
|
|
#include "my_net.h" /* needed because of struct in_addr */
|
|
|
|
size_t vio_ssl_read(Vio *vio,uchar* buf, size_t size);
|
|
size_t vio_ssl_write(Vio *vio,const uchar* buf, size_t size);
|
|
|
|
/* When the workday is over... */
|
|
int vio_ssl_close(Vio *vio);
|
|
void vio_ssl_delete(Vio *vio);
|
|
|
|
int vio_ssl_blocking(Vio *vio, my_bool set_blocking_mode, my_bool *old_mode);
|
|
|
|
#endif /* HAVE_OPENSSL */
|