mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 03:52:35 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/* Copyright 2018 Codership Oy <info@codership.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
#ifndef WSREP_CONDITION_VARIABLE_H
|
|
#define WSREP_CONDITION_VARIABLE_H
|
|
|
|
/* wsrep-lib */
|
|
#include "wsrep/condition_variable.hpp"
|
|
|
|
/* implementation */
|
|
#include "my_pthread.h"
|
|
|
|
class Wsrep_condition_variable : public wsrep::condition_variable
|
|
{
|
|
public:
|
|
|
|
Wsrep_condition_variable(mysql_cond_t* cond)
|
|
: m_cond(cond)
|
|
{ }
|
|
~Wsrep_condition_variable() = default;
|
|
|
|
void notify_one()
|
|
{
|
|
mysql_cond_signal(m_cond);
|
|
}
|
|
|
|
void notify_all()
|
|
{
|
|
mysql_cond_broadcast(m_cond);
|
|
}
|
|
|
|
void wait(wsrep::unique_lock<wsrep::mutex>& lock)
|
|
{
|
|
mysql_mutex_t* mutex= static_cast<mysql_mutex_t*>(lock.mutex()->native());
|
|
mysql_cond_wait(m_cond, mutex);
|
|
}
|
|
private:
|
|
mysql_cond_t* m_cond;
|
|
};
|
|
|
|
#endif /* WSREP_CONDITION_VARIABLE_H */
|