mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
02f305516f
If [NOT] PRESERVE was not given, parser always defaulted to NOT PRESERVE, making it impossible for the "not given = no change" rule to work in ALTER EVENT. Leaving out the PRESERVE-clause defaults to NOT PRESERVE on CREATE now, and to "no change" in ALTER. mysql-test/r/events_2.result: show that giving no PRESERVE-clause to ALTER EVENT results in no change. show that giving no PRESERVE-clause to CREATE EVENT defaults to NOT PRESERVE as per the docs. Show specifically that this is also handled correctly when trying to ALTER EVENTs into the past. mysql-test/t/events_2.test: show that giving no PRESERVE-clause to ALTER EVENT results in no change. show that giving no PRESERVE-clause to CREATE EVENT defaults to NOT PRESERVE as per the docs. Show specifically that this is also handled correctly when trying to ALTER EVENTs into the past. sql/event_db_repository.cc: If ALTER EVENT was given no PRESERVE-clause (meaning "no change"), we don't know the previous PRESERVE-setting by the time we check the parse-data. If ALTER EVENT was given dates that are in the past, we don't know how to react, lacking the PRESERVE-setting. Heal this by running the check later when we have actually read the previous EVENT-data. sql/event_parse_data.cc: Change default for ON COMPLETION to indicate, "not specified." Also defer throwing errors when ALTER EVENT is given dates in the past but not PRESERVE-clause until we know the previous PRESERVE-value. sql/event_parse_data.h: Add third state for ON COMPLETION [NOT] PRESERVE (preserve, don't, not specified). Make check_dates() public so we can defer this check until deeper in the callstack where we have all the required data. sql/sql_yacc.yy: If CREATE EVENT is not given ON COMPLETION [NOT] PRESERVE, we default to NOT, as per the docs.
124 lines
2.7 KiB
C++
124 lines
2.7 KiB
C++
/* Copyright (C) 2000-2003 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#ifndef _EVENT_PARSE_DATA_H_
|
|
#define _EVENT_PARSE_DATA_H_
|
|
|
|
#define EVEX_GET_FIELD_FAILED -2
|
|
#define EVEX_BAD_PARAMS -5
|
|
#define EVEX_MICROSECOND_UNSUP -6
|
|
#define EVEX_MAX_INTERVAL_VALUE 1000000000L
|
|
|
|
class Event_parse_data : public Sql_alloc
|
|
{
|
|
public:
|
|
/*
|
|
ENABLED = feature can function normally (is turned on)
|
|
SLAVESIDE_DISABLED = feature is turned off on slave
|
|
DISABLED = feature is turned off
|
|
*/
|
|
enum enum_status
|
|
{
|
|
ENABLED = 1,
|
|
DISABLED,
|
|
SLAVESIDE_DISABLED
|
|
};
|
|
|
|
enum enum_on_completion
|
|
{
|
|
/*
|
|
On CREATE EVENT, DROP is the DEFAULT as per the docs.
|
|
On ALTER EVENT, "no change" is the DEFAULT.
|
|
*/
|
|
ON_COMPLETION_DEFAULT = 0,
|
|
ON_COMPLETION_DROP,
|
|
ON_COMPLETION_PRESERVE
|
|
};
|
|
|
|
int on_completion;
|
|
int status;
|
|
longlong originator;
|
|
/*
|
|
do_not_create will be set if STARTS time is in the past and
|
|
on_completion == ON_COMPLETION_DROP.
|
|
*/
|
|
bool do_not_create;
|
|
|
|
bool body_changed;
|
|
|
|
LEX_STRING dbname;
|
|
LEX_STRING name;
|
|
LEX_STRING definer;// combination of user and host
|
|
LEX_STRING comment;
|
|
|
|
Item* item_starts;
|
|
Item* item_ends;
|
|
Item* item_execute_at;
|
|
|
|
my_time_t starts;
|
|
my_time_t ends;
|
|
my_time_t execute_at;
|
|
my_bool starts_null;
|
|
my_bool ends_null;
|
|
my_bool execute_at_null;
|
|
|
|
sp_name *identifier;
|
|
Item* item_expression;
|
|
longlong expression;
|
|
interval_type interval;
|
|
|
|
static Event_parse_data *
|
|
new_instance(THD *thd);
|
|
|
|
bool
|
|
check_parse_data(THD *thd);
|
|
|
|
bool
|
|
check_dates(THD *thd, int previous_on_completion);
|
|
|
|
private:
|
|
|
|
void
|
|
init_definer(THD *thd);
|
|
|
|
void
|
|
init_name(THD *thd, sp_name *spn);
|
|
|
|
int
|
|
init_execute_at(THD *thd);
|
|
|
|
int
|
|
init_interval(THD *thd);
|
|
|
|
int
|
|
init_starts(THD *thd);
|
|
|
|
int
|
|
init_ends(THD *thd);
|
|
|
|
Event_parse_data();
|
|
~Event_parse_data();
|
|
|
|
void
|
|
report_bad_value(const char *item_name, Item *bad_item);
|
|
|
|
void
|
|
check_if_in_the_past(THD *thd, my_time_t ltime_utc);
|
|
|
|
Event_parse_data(const Event_parse_data &); /* Prevent use of these */
|
|
void check_originator_id(THD *thd);
|
|
void operator=(Event_parse_data &);
|
|
};
|
|
#endif
|