mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 04:22:27 +01:00
16c8298a85
There was two problems: The first was the symptom, caused by bad error handling in ha_partition. It did not handle print_error etc. when having no partitions (when used by dummy handler). The second was the real problem that when dropping tables it reused the table type (storage engine) from when the lock was asked for, not the table type that it had when gaining the exclusive name lock. So that it tried to delete tables from wrong storage engines. Solutions for the first problem was to accept some handler calls to the partitioning handler even if it was not setup with any partitions, and also if possible fallback to use the base handler's default functions. Solution for the second problem was to remove the optimization to reuse the definition from the cache, instead always check the frm-file when holding the LOCK_open mutex (updated with a fix for a debug print crash and better comments as required by reviewer, and removed optimization to avoid reading the frm-file). mysql-test/r/partition_debug_sync.result: Bug#42438: Crash ha_partition::change_table_ptr New result file using DEBUG_SYNC for deterministic results. mysql-test/t/partition_debug_sync.test: Bug#42438: Crash ha_partition::change_table_ptr New test file using DEBUG_SYNC for deterministic results. sql/ha_partition.cc: Bug#42438: Crash ha_partition::change_table_ptr allow some handler calls, used by error handling, even when no partitions are setup. Fallback to default handling if possible. sql/sql_base.cc: Bug#42438: Crash ha_partition::change_table_ptr Added DEBUG_SYNC point for deterministic test cases. sql/sql_table.cc: Bug#42438: Crash ha_partition::change_table_ptr Always use the table type written in the .frm-file (i.e. the current table type) when deleting a table. Moved the check for log-table to not depend of the cache. Added DEBUG_SYNC points for deterministic test cases.
81 lines
2.5 KiB
Text
81 lines
2.5 KiB
Text
#--disable_abort_on_error
|
|
#
|
|
# Test for the partition storage engine which require DEBUG_SYNC feature to
|
|
# Created by Mattias Jonsson
|
|
#
|
|
--source include/have_partition.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
--enable_warnings
|
|
|
|
--echo #
|
|
--echo # Bug#42438: Crash ha_partition::change_table_ptr
|
|
--echo # Test when remove partitioning is done while drop table is waiting
|
|
--echo # for the table.
|
|
connect(con1, localhost, root,,);
|
|
--echo # Con 1
|
|
SET DEBUG_SYNC= 'RESET';
|
|
CREATE TABLE t1
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
/*!50100 PARTITION BY RANGE (a)
|
|
(PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
|
|
SET DEBUG_SYNC= 'alter_table_before_create_table_no_lock SIGNAL removing_partitioning WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'alter_table_before_main_binlog SIGNAL partitioning_removed';
|
|
--send ALTER TABLE t1 REMOVE PARTITIONING
|
|
connection default;
|
|
--echo # Con default
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitioning';
|
|
SET DEBUG_SYNC= 'waiting_for_table SIGNAL waiting_for_alter';
|
|
SET DEBUG_SYNC= 'rm_table_part2_before_delete_table WAIT_FOR partitioning_removed';
|
|
DROP TABLE IF EXISTS t1;
|
|
--echo # Con 1
|
|
connection con1;
|
|
--reap
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
|
|
--echo #
|
|
--echo # Bug#42438: Crash ha_partition::change_table_ptr
|
|
--echo # Test when remove partitioning is failing due to drop table is already
|
|
--echo # in progress.
|
|
CREATE TABLE t2
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
/*!50100 PARTITION BY RANGE (a)
|
|
(PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
|
|
SET DEBUG_SYNC= 'before_lock_tables_takes_lock SIGNAL removing_partitions WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'alter_table_before_rename_result_table WAIT_FOR delete_done';
|
|
--send ALTER TABLE t2 REMOVE PARTITIONING
|
|
connection default;
|
|
--echo # Con default
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitions';
|
|
SET DEBUG_SYNC= 'waiting_for_table SIGNAL waiting_for_alter';
|
|
SET DEBUG_SYNC= 'rm_table_part2_before_binlog SIGNAL delete_done';
|
|
DROP TABLE IF EXISTS t2;
|
|
--echo # Con 1
|
|
connection con1;
|
|
--error ER_NO_SUCH_TABLE
|
|
--reap
|
|
SET DEBUG_SYNC= 'RESET';
|
|
disconnect con1;
|
|
connection default;
|
|
--echo # Con default
|
|
SET DEBUG_SYNC= 'RESET';
|
|
|
|
--echo End of 5.1 tests
|