mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
b92081cdea
Before this fix, a call to a User Defined Function (UDF) could, under some circumstances, be interpreted as a call to a Stored function instead. This occurred if a native function was invoked in the parameters for the UDF, as in "select my_udf(abs(x))". The root cause of this defect is the introduction, by the fix for Bug 21809, of st_select_lex::udf_list, and it's usage in the parser in sql_yacc.yy in the rule function_call_generic (in 5.1). While the fix itself for Bug 21809 is correct in 5.0, the code change merged into the 5.1 release created the issue, because the calls in 5.1 to : - lex->current_select->udf_list.push_front(udf) - lex->current_select->udf_list.pop() are not balanced in case of native functions, causing the udf_list, which is really a stack, to be out of sync with the internal stack maintained by the bison parser. Instead of moving the call to udf_list.pop(), which would have fixed the symptom, this patch goes further and removes the need for udf_list. This is motivated by two reasons: a) Maintaining a stack in the MySQL code in sync with the stack maintained internally in sql_yacc.cc (not .yy) is extremely dependent of the implementation of yacc/bison, and extremely difficult to maintain. It's also totally dependent of the structure of the grammar, and has a risk to break with regression defects each time the grammar itself is changed. b) The previous code did report construct like "foo(expr AS name)" as syntax errors (ER_PARSER_ERROR), which is incorrect, and misleading. The syntax is perfectly valid, as this expression is valid when "foo" is a UDF. Whether this syntax is legal or not depends of the semantic of "foo". With this change: a) There is only one stack (in bison), and no List<udf_func> to maintain. b) "foo(expr AS name)", when used incorrectly, is reported as semantic error: - ER_WRONG_PARAMETERS_TO_NATIVE_FCT (for native functions) - ER_WRONG_PARAMETERS_TO_STORED_FCT (for stored functions) This is achieved by the changes implemented in item_create.cc mysql-test/r/parser.result: New tests mysql-test/r/udf.result: New tests mysql-test/t/parser.test: New tests mysql-test/t/udf.test: New tests sql/item_create.cc: Semantic checks for named parameters, as in "foo(expr AS name)". sql/share/errmsg.txt: New error message sql/sql_lex.cc: Remove usage of udf_list. sql/sql_lex.h: Remove usage of udf_list. sql/sql_yacc.yy: Remove usage of udf_list.
253 lines
8.3 KiB
Text
253 lines
8.3 KiB
Text
drop table if exists t1;
|
|
CREATE FUNCTION metaphon RETURNS STRING SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE FUNCTION myfunc_double RETURNS REAL SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE FUNCTION myfunc_nonexist RETURNS INTEGER SONAME "UDF_EXAMPLE_LIB";
|
|
ERROR HY000: Can't find symbol 'myfunc_nonexist' in library
|
|
CREATE FUNCTION myfunc_int RETURNS INTEGER SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE FUNCTION sequence RETURNS INTEGER SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE FUNCTION lookup RETURNS STRING SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE FUNCTION reverse_lookup
|
|
RETURNS STRING SONAME "UDF_EXAMPLE_LIB";
|
|
CREATE AGGREGATE FUNCTION avgcost
|
|
RETURNS REAL SONAME "UDF_EXAMPLE_LIB";
|
|
select myfunc_double();
|
|
ERROR HY000: myfunc_double must have at least one argument
|
|
select myfunc_double(1);
|
|
myfunc_double(1)
|
|
49.00
|
|
select myfunc_double(78654);
|
|
myfunc_double(78654)
|
|
54.00
|
|
select myfunc_nonexist();
|
|
ERROR 42000: FUNCTION test.myfunc_nonexist does not exist
|
|
select myfunc_int();
|
|
myfunc_int()
|
|
0
|
|
select lookup();
|
|
ERROR HY000: Wrong arguments to lookup; Use the source
|
|
select lookup("127.0.0.1");
|
|
lookup("127.0.0.1")
|
|
127.0.0.1
|
|
select lookup(127,0,0,1);
|
|
ERROR HY000: Wrong arguments to lookup; Use the source
|
|
select lookup("localhost");
|
|
lookup("localhost")
|
|
127.0.0.1
|
|
select reverse_lookup();
|
|
ERROR HY000: Wrong number of arguments to reverse_lookup; Use the source
|
|
select reverse_lookup("127.0.0.1");
|
|
select reverse_lookup(127,0,0,1);
|
|
select reverse_lookup("localhost");
|
|
reverse_lookup("localhost")
|
|
NULL
|
|
select avgcost();
|
|
ERROR HY000: wrong number of arguments: AVGCOST() requires two arguments
|
|
select avgcost(100,23.76);
|
|
ERROR HY000: wrong argument type: AVGCOST() requires an INT and a REAL
|
|
create table t1(sum int, price float(24));
|
|
insert into t1 values(100, 50.00), (100, 100.00);
|
|
select avgcost(sum, price) from t1;
|
|
avgcost(sum, price)
|
|
75.0000
|
|
delete from t1;
|
|
insert into t1 values(100, 54.33), (200, 199.99);
|
|
select avgcost(sum, price) from t1;
|
|
avgcost(sum, price)
|
|
151.4367
|
|
drop table t1;
|
|
select metaphon('hello');
|
|
metaphon('hello')
|
|
HL
|
|
CREATE PROCEDURE `XXX1`(in testval varchar(10))
|
|
begin
|
|
select metaphon(testval);
|
|
end//
|
|
call XXX1('hello');
|
|
metaphon(testval)
|
|
HL
|
|
drop procedure xxx1;
|
|
CREATE PROCEDURE `XXX2`()
|
|
begin
|
|
declare testval varchar(10);
|
|
set testval = 'hello';
|
|
select metaphon(testval);
|
|
end//
|
|
call XXX2();
|
|
metaphon(testval)
|
|
HL
|
|
drop procedure xxx2;
|
|
CREATE TABLE bug19904(n INT, v varchar(10));
|
|
INSERT INTO bug19904 VALUES (1,'one'),(2,'two'),(NULL,NULL),(3,'three'),(4,'four');
|
|
SELECT myfunc_double(n) AS f FROM bug19904;
|
|
f
|
|
49.00
|
|
50.00
|
|
NULL
|
|
51.00
|
|
52.00
|
|
SELECT metaphon(v) AS f FROM bug19904;
|
|
f
|
|
ON
|
|
TW
|
|
NULL
|
|
0R
|
|
FR
|
|
DROP TABLE bug19904;
|
|
CREATE DEFINER=CURRENT_USER() FUNCTION should_not_parse
|
|
RETURNS STRING SONAME "should_not_parse.so";
|
|
ERROR HY000: Incorrect usage of SONAME and DEFINER
|
|
CREATE DEFINER=someone@somewhere FUNCTION should_not_parse
|
|
RETURNS STRING SONAME "should_not_parse.so";
|
|
ERROR HY000: Incorrect usage of SONAME and DEFINER
|
|
create table t1(f1 int);
|
|
insert into t1 values(1),(2);
|
|
explain select myfunc_int(f1) from t1 order by 1;
|
|
id select_type table type possible_keys key key_len ref rows Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 Using temporary; Using filesort
|
|
drop table t1;
|
|
CREATE TABLE t1(a INT, b INT);
|
|
INSERT INTO t1 values (1,1),(2,2);
|
|
CREATE FUNCTION fn(a int) RETURNS int DETERMINISTIC
|
|
BEGIN
|
|
RETURN a;
|
|
END
|
|
||
|
|
CREATE VIEW v1 AS SELECT a, fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
SELECT myfunc_int(a AS attr_name) FROM t1;
|
|
myfunc_int(a AS attr_name)
|
|
1
|
|
2
|
|
EXPLAIN EXTENDED SELECT myfunc_int(a AS attr_name) FROM t1;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00
|
|
Warnings:
|
|
Note 1003 select myfunc_int(`test`.`t1`.`a` AS `attr_name`) AS `myfunc_int(a AS attr_name)` from `test`.`t1`
|
|
EXPLAIN EXTENDED SELECT myfunc_int(a) FROM t1;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00
|
|
Warnings:
|
|
Note 1003 select myfunc_int(`test`.`t1`.`a` AS `a`) AS `myfunc_int(a)` from `test`.`t1`
|
|
SELECT a,c FROM v1;
|
|
a c
|
|
1 1
|
|
2 2
|
|
SELECT a, fn(MIN(b) xx) as c FROM t1 GROUP BY a;
|
|
ERROR 42000: Incorrect parameters in the call to stored function 'fn'
|
|
SELECT myfunc_int(fn(MIN(b) xx)) as c FROM t1 GROUP BY a;
|
|
ERROR 42000: Incorrect parameters in the call to stored function 'fn'
|
|
SELECT myfunc_int(test.fn(MIN(b) xx)) as c FROM t1 GROUP BY a;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'xx)) as c FROM t1 GROUP BY a' at line 1
|
|
SELECT myfunc_int(fn(MIN(b)) xx) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
SELECT myfunc_int(test.fn(MIN(b)) xx) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
EXPLAIN EXTENDED SELECT myfunc_int(MIN(b) xx) as c FROM t1 GROUP BY a;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00 Using temporary; Using filesort
|
|
Warnings:
|
|
Note 1003 select myfunc_int(min(`test`.`t1`.`b`) AS `xx`) AS `c` from `test`.`t1` group by `test`.`t1`.`a`
|
|
EXPLAIN EXTENDED SELECT test.fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00 Using temporary; Using filesort
|
|
Warnings:
|
|
Note 1003 select `test`.`fn`(min(`test`.`t1`.`b`)) AS `c` from `test`.`t1` group by `test`.`t1`.`a`
|
|
EXPLAIN EXTENDED SELECT myfunc_int(fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00 Using temporary; Using filesort
|
|
Warnings:
|
|
Note 1003 select myfunc_int(`test`.`fn`(min(`test`.`t1`.`b`)) AS `fn(MIN(b))`) AS `c` from `test`.`t1` group by `test`.`t1`.`a`
|
|
EXPLAIN EXTENDED SELECT myfunc_int(test.fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 2 100.00 Using temporary; Using filesort
|
|
Warnings:
|
|
Note 1003 select myfunc_int(`test`.`fn`(min(`test`.`t1`.`b`)) AS `test.fn(MIN(b))`) AS `c` from `test`.`t1` group by `test`.`t1`.`a`
|
|
SELECT myfunc_int(MIN(b) xx) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
SELECT test.fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
SELECT myfunc_int(fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
SELECT myfunc_int(test.fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
c
|
|
1
|
|
2
|
|
DROP VIEW v1;
|
|
DROP TABLE t1;
|
|
DROP FUNCTION fn;
|
|
End of 5.0 tests.
|
|
select myfunc_double(3);
|
|
myfunc_double(3)
|
|
51.00
|
|
select myfunc_double(3 AS three);
|
|
myfunc_double(3 AS three)
|
|
51.00
|
|
select myfunc_double(abs(3));
|
|
myfunc_double(abs(3))
|
|
51.00
|
|
select myfunc_double(abs(3) AS named_param);
|
|
myfunc_double(abs(3) AS named_param)
|
|
51.00
|
|
select abs(myfunc_double(3));
|
|
abs(myfunc_double(3))
|
|
51.00
|
|
select abs(myfunc_double(3 AS three));
|
|
abs(myfunc_double(3 AS three))
|
|
51.00
|
|
select myfunc_double(abs(3 AS wrong));
|
|
ERROR 42000: Incorrect parameters in the call to native function 'abs'
|
|
select abs(myfunc_double(3) AS wrong);
|
|
ERROR 42000: Incorrect parameters in the call to native function 'abs'
|
|
DROP FUNCTION metaphon;
|
|
DROP FUNCTION myfunc_double;
|
|
DROP FUNCTION myfunc_nonexist;
|
|
ERROR 42000: FUNCTION test.myfunc_nonexist does not exist
|
|
DROP FUNCTION myfunc_int;
|
|
DROP FUNCTION sequence;
|
|
DROP FUNCTION lookup;
|
|
DROP FUNCTION reverse_lookup;
|
|
DROP FUNCTION avgcost;
|
|
CREATE FUNCTION is_const RETURNS STRING SONAME "UDF_EXAMPLE_LIB";
|
|
select
|
|
is_const(3) as const,
|
|
is_const(3.14) as const,
|
|
is_const('fnord') as const,
|
|
is_const(2+3) as const,
|
|
is_const(rand()) as 'nc rand()',
|
|
is_const(sin(3.14)) as const,
|
|
is_const(upper('test')) as const;
|
|
const const const const nc rand() const const
|
|
const const const const not const const const
|
|
create table bug18761 (n int);
|
|
insert into bug18761 values (null),(2);
|
|
select
|
|
is_const(3) as const,
|
|
is_const(3.14) as const,
|
|
is_const('fnord') as const,
|
|
is_const(2+3) as const,
|
|
is_const(2+n) as 'nc 2+n ',
|
|
is_const(sin(n)) as 'nc sin(n)',
|
|
is_const(sin(3.14)) as const,
|
|
is_const(upper('test')) as const,
|
|
is_const(rand()) as 'nc rand()',
|
|
is_const(n) as 'nc n ',
|
|
is_const(is_const(n)) as 'nc ic?(n)',
|
|
is_const(is_const('c')) as const
|
|
from
|
|
bug18761;
|
|
const const const const nc 2+n nc sin(n) const const nc rand() nc n nc ic?(n) const
|
|
const const const const not const not const const const not const not const not const const
|
|
const const const const not const not const const const not const not const not const const
|
|
drop table bug18761;
|
|
select is_const((1,2,3));
|
|
ERROR 21000: Operand should contain 1 column(s)
|
|
drop function if exists is_const;
|