mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
f094eff1d9
pointed data. I ran gcc -Wcast-qual on storage/maria, this identified un-needed casts, a couple of functions which said they had a const parameter though they changed the pointed content! This is fixed here. Some suspicious places receive a comment. The original intention of running -Wcast-qual was to find what code changes R-tree keys: I added const words, but hidden casts like those of int2store (casts target to (uint16*)) removed const checking; -Wcast-qual helped find those hidden casts. Log handler does not change the content pointed by LEX_STRING::str it receives, so we now use a struct which has a const inside, to emphasize this and be able to pass "const uchar*" buffers to log handler without fear of their content being changed by it. One-line fix for a merge glitch (when merging from MyISAM). include/m_string.h: As Maria's log handler uses LEX_STRING but never changes the content pointed by LEX_STRING::str, and assigns uchar* into this member most of the time, we introduce a new struct LEX_CUSTRING (C const U unsigned) for the log handler. include/my_global.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. include/my_handler.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. ha_find_null() does not change *a. include/my_sys.h: insert_dynamic() does not change *element. include/myisampack.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. mysys/array.c: insert_dynamic() does not change *element mysys/my_handler.c: ha_find_null() does not change *a storage/maria/ma_bitmap.c: Log handler receives const strings now storage/maria/ma_blockrec.c: Log handler receives const strings now. _ma_apply_undo_row_delete/update() do change *header. storage/maria/ma_blockrec.h: correct prototype storage/maria/ma_check.c: Log handler receives const strings now. Un-needed casts storage/maria/ma_checkpoint.c: Log handler receives const strings now storage/maria/ma_checksum.c: unneeded cast storage/maria/ma_commit.c: Log handler receives const strings now storage/maria/ma_create.c: Log handler receives const strings now storage/maria/ma_dbug.c: fixing warning of gcc -Wcast-qual storage/maria/ma_delete.c: Log handler receives const strings now storage/maria/ma_delete_all.c: Log handler receives const strings now storage/maria/ma_delete_table.c: Log handler receives const strings now storage/maria/ma_dynrec.c: fixing some warnings of gcc -Wcast-qual. Unneeded casts removed. Comment about function which lies. storage/maria/ma_ft_parser.c: fix for warnings of gcc -Wcast-qual, removing unneeded casts storage/maria/ma_ft_update.c: less casts, comment storage/maria/ma_key.c: less casts, stay const (warnings of gcc -Wcast-qual) storage/maria/ma_key_recover.c: Log handler receives const strings now storage/maria/ma_loghandler.c: Log handler receives const strings now storage/maria/ma_loghandler.h: Log handler receives const strings now storage/maria/ma_loghandler_lsn.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. storage/maria/ma_page.c: Log handler receives const strings now; more const storage/maria/ma_recovery.c: Log handler receives const strings now storage/maria/ma_rename.c: Log handler receives const strings now storage/maria/ma_rt_index.c: more const, to emphasize that functions don't change pointed content. best_key= NULL was forgotten during merge from MyISAM a few days ago, was causing a Valgrind warning storage/maria/ma_rt_index.h: new proto storage/maria/ma_rt_key.c: more const storage/maria/ma_rt_key.h: new proto storage/maria/ma_rt_mbr.c: more const for functions which deserve it storage/maria/ma_rt_mbr.h: new prototype storage/maria/ma_rt_split.c: make const what is not changed. storage/maria/ma_search.c: un-needed casts, more const storage/maria/ma_sp_key.c: more const storage/maria/ma_unique.c: un-needed casts. storage/maria/ma_write.c: Log handler receives const strings now storage/maria/maria_def.h: some more const storage/maria/unittest/ma_test_loghandler-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_first_lsn-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_max_lsn-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_multigroup-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_multithread-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_noflush-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_nologs-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_pagecache-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_purge-t.c: Log handler receives const strings now
173 lines
5.4 KiB
C
173 lines
5.4 KiB
C
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Remove all rows from a MARIA table */
|
|
/* This clears the status information and truncates files */
|
|
|
|
#include "maria_def.h"
|
|
#include "trnman.h"
|
|
|
|
/**
|
|
@brief deletes all rows from a table
|
|
|
|
@param info Maria handler
|
|
|
|
@note It is important that this function does not rely on the state
|
|
information, as it may be called by ma_apply_undo_bulk_insert() on an
|
|
inconsistent table left by a crash.
|
|
|
|
@return Operation status
|
|
@retval 0 ok
|
|
@retval 1 error
|
|
*/
|
|
|
|
int maria_delete_all_rows(MARIA_HA *info)
|
|
{
|
|
MARIA_SHARE *share= info->s;
|
|
my_bool log_record;
|
|
LSN lsn;
|
|
DBUG_ENTER("maria_delete_all_rows");
|
|
|
|
if (share->options & HA_OPTION_READ_ONLY_DATA)
|
|
{
|
|
DBUG_RETURN(my_errno=EACCES);
|
|
}
|
|
/**
|
|
@todo LOCK take X-lock on table here.
|
|
When we have versioning, if some other thread is looking at this table,
|
|
we cannot shrink the file like this.
|
|
*/
|
|
if (_ma_readinfo(info,F_WRLCK,1))
|
|
DBUG_RETURN(my_errno);
|
|
log_record= share->now_transactional && !share->temporary;
|
|
if (_ma_mark_file_changed(info))
|
|
goto err;
|
|
|
|
if (log_record)
|
|
{
|
|
/*
|
|
This record will be used by Recovery to finish the deletion if it
|
|
crashed. We force it to have a complete history in the log.
|
|
*/
|
|
LEX_CUSTRING log_array[TRANSLOG_INTERNAL_PARTS + 1];
|
|
uchar log_data[FILEID_STORE_SIZE];
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 0].str= log_data;
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 0].length= sizeof(log_data);
|
|
if (unlikely(translog_write_record(&lsn, LOGREC_REDO_DELETE_ALL,
|
|
info->trn, info, 0,
|
|
sizeof(log_array)/sizeof(log_array[0]),
|
|
log_array, log_data, NULL) ||
|
|
translog_flush(lsn)))
|
|
goto err;
|
|
/*
|
|
If we fail in this function after this point, log and table will be
|
|
inconsistent.
|
|
*/
|
|
}
|
|
else
|
|
{
|
|
/* Other branch called function below when writing log record, in hook */
|
|
_ma_reset_status(info);
|
|
}
|
|
|
|
/*
|
|
If we are using delayed keys or if the user has done changes to the tables
|
|
since it was locked then there may be key blocks in the page cache. Or
|
|
there may be data blocks there. We need to throw them away or they may
|
|
re-enter the emptied table or another table later.
|
|
*/
|
|
if (_ma_flush_table_files(info, MARIA_FLUSH_DATA|MARIA_FLUSH_INDEX,
|
|
FLUSH_IGNORE_CHANGED, FLUSH_IGNORE_CHANGED) ||
|
|
my_chsize(info->dfile.file, 0, 0, MYF(MY_WME)) ||
|
|
my_chsize(share->kfile.file, share->base.keystart, 0, MYF(MY_WME)) )
|
|
goto err;
|
|
|
|
if (_ma_initialize_data_file(share, info->dfile.file))
|
|
goto err;
|
|
|
|
|
|
if (log_record)
|
|
{
|
|
/*
|
|
Because LOGREC_REDO_DELETE_ALL does not operate on pages, it has the
|
|
following problem:
|
|
delete_all; inserts (redo_insert); all pages get flushed; checkpoint:
|
|
the dirty pages list will be empty. In recovery, delete_all is executed,
|
|
but redo_insert are skipped (dirty pages list is empty).
|
|
To avoid this, we need to set skip_redo_lsn now, and thus need to sync
|
|
files.
|
|
*/
|
|
my_bool error= _ma_state_info_write(share, 1|4) ||
|
|
_ma_update_state_lsns(share, lsn, FALSE, FALSE) ||
|
|
_ma_sync_table_files(info);
|
|
info->trn->rec_lsn= LSN_IMPOSSIBLE;
|
|
if (error)
|
|
goto err;
|
|
}
|
|
|
|
VOID(_ma_writeinfo(info,WRITEINFO_UPDATE_KEYFILE));
|
|
#ifdef HAVE_MMAP
|
|
/* Resize mmaped area */
|
|
rw_wrlock(&info->s->mmap_lock);
|
|
_ma_remap_file(info, (my_off_t)0);
|
|
rw_unlock(&info->s->mmap_lock);
|
|
#endif
|
|
allow_break(); /* Allow SIGHUP & SIGINT */
|
|
DBUG_RETURN(0);
|
|
|
|
err:
|
|
{
|
|
int save_errno=my_errno;
|
|
VOID(_ma_writeinfo(info,WRITEINFO_UPDATE_KEYFILE));
|
|
info->update|=HA_STATE_WRITTEN; /* Buffer changed */
|
|
allow_break(); /* Allow SIGHUP & SIGINT */
|
|
DBUG_RETURN(my_errno=save_errno);
|
|
}
|
|
} /* maria_delete_all_rows */
|
|
|
|
|
|
/*
|
|
Reset status information
|
|
|
|
SYNOPSIS
|
|
_ma_reset_status()
|
|
maria Maria handler
|
|
|
|
DESCRIPTION
|
|
Resets data and index file information as if the file would be empty
|
|
Files are not touched.
|
|
*/
|
|
|
|
void _ma_reset_status(MARIA_HA *info)
|
|
{
|
|
MARIA_SHARE *share= info->s;
|
|
MARIA_STATE_INFO *state= &share->state;
|
|
uint i;
|
|
|
|
info->state->records= info->state->del= state->split= 0;
|
|
state->changed= 0; /* File is optimized */
|
|
state->dellink= HA_OFFSET_ERROR;
|
|
state->sortkey= (ushort) ~0;
|
|
info->state->key_file_length= share->base.keystart;
|
|
info->state->data_file_length= 0;
|
|
info->state->empty= info->state->key_empty= 0;
|
|
info->state->checksum= 0;
|
|
|
|
/* Drop the delete key chain. */
|
|
state->key_del= HA_OFFSET_ERROR;
|
|
/* Clear all keys */
|
|
for (i=0 ; i < share->base.keys ; i++)
|
|
state->key_root[i]= HA_OFFSET_ERROR;
|
|
}
|