mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
86fcfb1508
Fixed bug when removing a newly inserted record (in case of duplicate key). The bug caused a crash for rows with several blobs and the first blob was small enough to fit into the head page. Don't change state_history if nothing changed (speed optimization that also simplifies logic). Reset state_history if we added/deleted or updated rows without versioning. Fixed wrong test in trnman_exists_active_transactions() if state is visible or not. Other bugs fixed: Fixed wrong argument to (lock->get_status) when we had to wait for TL_WRITE_CONCURRENT_INSERT. Item_equal::update_used_tables() didn't calculate const_item_cache properly. Added assert's to detect if join_read_const_table() was called under wrong assumptions.. Fixed that _ma_setup_live_state() is called from thr_lock() instead of handler::external_lock(). This was needed to get versioning information to be setup correctly. Fixed error in debug binaries during a call to _ma_check_table_is_closed() when another thread was opening/closing a table. Fixed wrong test when finding right history_state to use. mysql-test/suite/maria/r/maria.result: Added test for Bug#40311 Assert in MARIA_RECORD_POS during pushbuild 2 test mysql-test/suite/maria/t/maria.test: Added test for Bug#40311 Assert in MARIA_RECORD_POS during pushbuild 2 test mysys/thr_lock.c: Fixed wrong argument to (lock->get_status) when we had to wait for TL_WRITE_CONCURRENT_INSERT sql/item_cmpfunc.cc: Item_equal::update_used_tables() didn't calculate const_item_cache properly, which later caused a wrong result for item->const_item() sql/sql_base.cc: In debug mode, Initilize record buffer with unexpected data to catch usage of uninitialized memory sql/sql_select.cc: Fixed indentation Added assert's to detect if join_read_const_table() was called under wrong assumptions. One assert() is disabled for now as Item_equal() doesn't behave as expected. storage/maria/ha_maria.cc: Move calling to _ma_setup_live_state() to ma_state.c::_ma_block_get_status() This was needed as _ma_setup_live_state() needed to know if the table will be used concurrently or not storage/maria/ma_blockrec.c: Fixed bug when removing a newly inserted record (in case of duplicate key). The bug caused a crash for rows with several blobs and the first blob was small enough to fit into the head page. storage/maria/ma_dbug.c: Added mutex to protect the open table list during _ma_check_table_is_closed(). Without the protection we could get a error in debug binaries during a call to _ma_check_table_is_closed() storage/maria/ma_delete_table.c: Removed not used code storage/maria/ma_rename.c: Removed not used code storage/maria/ma_state.c: Fixed wrong test when finding right history_state to use Mark in tables->state_current.no_transid if we are using transid's or not. Don't change state_history if nothing changed (speed optimization that also simplifies logic) Reset state_history if we added/deleted or updated rows without versioning. More DBUG_ASSERT's and more DBUG Updated maria_versioning() to initialize environment before calling _ma_blok_get_status(). This was needed because of the new logic in _ma_block_get_status() storage/maria/ma_state.h: Added flags to detect if table changed and/or if we changed table without versioning storage/maria/ma_write.c: Simple cleanups (No logic changes) storage/maria/trnman.c: Fixed wrong test in trnman_exists_active_transactions() if state is visible or not.
202 lines
5.3 KiB
C
202 lines
5.3 KiB
C
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Support rutiner with are using with dbug */
|
|
|
|
#include "maria_def.h"
|
|
|
|
void _ma_print_key(FILE *stream, MARIA_KEY *key)
|
|
{
|
|
_ma_print_keydata(stream, key->keyinfo->seg, key->data, key->data_length);
|
|
}
|
|
|
|
|
|
/* Print a key in a user understandable format */
|
|
|
|
void _ma_print_keydata(FILE *stream, register HA_KEYSEG *keyseg,
|
|
const uchar *key, uint length)
|
|
{
|
|
int flag;
|
|
short int s_1;
|
|
long int l_1;
|
|
float f_1;
|
|
double d_1;
|
|
const uchar *end;
|
|
const uchar *key_end= key + length;
|
|
|
|
VOID(fputs("Key: \"",stream));
|
|
flag=0;
|
|
for (; keyseg->type && key < key_end ;keyseg++)
|
|
{
|
|
if (flag++)
|
|
VOID(putc('-',stream));
|
|
end= key+ keyseg->length;
|
|
if (keyseg->flag & HA_NULL_PART)
|
|
{
|
|
/* A NULL value is encoded by a 1-byte flag. Zero means NULL. */
|
|
if (! *(key++))
|
|
{
|
|
fprintf(stream,"NULL");
|
|
continue;
|
|
}
|
|
end++;
|
|
}
|
|
|
|
switch (keyseg->type) {
|
|
case HA_KEYTYPE_BINARY:
|
|
if (!(keyseg->flag & HA_SPACE_PACK) && keyseg->length == 1)
|
|
{ /* packed binary digit */
|
|
VOID(fprintf(stream,"%d",(uint) *key++));
|
|
break;
|
|
}
|
|
/* fall through */
|
|
case HA_KEYTYPE_TEXT:
|
|
case HA_KEYTYPE_NUM:
|
|
if (keyseg->flag & HA_SPACE_PACK)
|
|
{
|
|
VOID(fprintf(stream,"%.*s",(int) *key,key+1));
|
|
key+= (int) *key+1;
|
|
}
|
|
else
|
|
{
|
|
VOID(fprintf(stream,"%.*s",(int) keyseg->length,key));
|
|
key=end;
|
|
}
|
|
break;
|
|
case HA_KEYTYPE_INT8:
|
|
VOID(fprintf(stream,"%d",(int) *((const signed char*) key)));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_SHORT_INT:
|
|
s_1= mi_sint2korr(key);
|
|
VOID(fprintf(stream,"%d",(int) s_1));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_USHORT_INT:
|
|
{
|
|
ushort u_1;
|
|
u_1= mi_uint2korr(key);
|
|
VOID(fprintf(stream,"%u",(uint) u_1));
|
|
key=end;
|
|
break;
|
|
}
|
|
case HA_KEYTYPE_LONG_INT:
|
|
l_1=mi_sint4korr(key);
|
|
VOID(fprintf(stream,"%ld",l_1));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_ULONG_INT:
|
|
l_1=mi_uint4korr(key);
|
|
VOID(fprintf(stream,"%lu",(ulong) l_1));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_INT24:
|
|
VOID(fprintf(stream,"%ld",(long) mi_sint3korr(key)));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_UINT24:
|
|
VOID(fprintf(stream,"%lu",(ulong) mi_uint3korr(key)));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_FLOAT:
|
|
mi_float4get(f_1,key);
|
|
VOID(fprintf(stream,"%g",(double) f_1));
|
|
key=end;
|
|
break;
|
|
case HA_KEYTYPE_DOUBLE:
|
|
mi_float8get(d_1,key);
|
|
VOID(fprintf(stream,"%g",d_1));
|
|
key=end;
|
|
break;
|
|
#ifdef HAVE_LONG_LONG
|
|
case HA_KEYTYPE_LONGLONG:
|
|
{
|
|
char buff[21];
|
|
longlong2str(mi_sint8korr(key),buff,-10);
|
|
VOID(fprintf(stream,"%s",buff));
|
|
key=end;
|
|
break;
|
|
}
|
|
case HA_KEYTYPE_ULONGLONG:
|
|
{
|
|
char buff[21];
|
|
longlong2str(mi_sint8korr(key),buff,10);
|
|
VOID(fprintf(stream,"%s",buff));
|
|
key=end;
|
|
break;
|
|
}
|
|
case HA_KEYTYPE_BIT:
|
|
{
|
|
uint i;
|
|
fputs("0x",stream);
|
|
for (i=0 ; i < keyseg->length ; i++)
|
|
fprintf(stream, "%02x", (uint) *key++);
|
|
key= end;
|
|
break;
|
|
}
|
|
|
|
#endif
|
|
case HA_KEYTYPE_VARTEXT1: /* VARCHAR and TEXT */
|
|
case HA_KEYTYPE_VARTEXT2: /* VARCHAR and TEXT */
|
|
case HA_KEYTYPE_VARBINARY1: /* VARBINARY and BLOB */
|
|
case HA_KEYTYPE_VARBINARY2: /* VARBINARY and BLOB */
|
|
{
|
|
uint tmp_length;
|
|
get_key_length(tmp_length,key);
|
|
/*
|
|
The following command sometimes gives a warning from valgrind.
|
|
Not yet sure if the bug is in valgrind, glibc or mysqld
|
|
*/
|
|
VOID(fprintf(stream,"%.*s",(int) tmp_length,key));
|
|
key+=tmp_length;
|
|
break;
|
|
}
|
|
default: break; /* This never happens */
|
|
}
|
|
}
|
|
VOID(fputs("\"\n",stream));
|
|
return;
|
|
} /* print_key */
|
|
|
|
|
|
#ifdef EXTRA_DEBUG
|
|
|
|
my_bool _ma_check_table_is_closed(const char *name, const char *where)
|
|
{
|
|
char filename[FN_REFLEN];
|
|
LIST *pos;
|
|
DBUG_ENTER("_ma_check_table_is_closed");
|
|
|
|
(void) fn_format(filename,name,"",MARIA_NAME_IEXT,4+16+32);
|
|
pthread_mutex_lock(&THR_LOCK_maria);
|
|
for (pos=maria_open_list ; pos ; pos=pos->next)
|
|
{
|
|
MARIA_HA *info=(MARIA_HA*) pos->data;
|
|
MARIA_SHARE *share= info->s;
|
|
if (!strcmp(share->unique_file_name.str, filename))
|
|
{
|
|
if (share->last_version)
|
|
{
|
|
fprintf(stderr,"Warning: Table: %s is open on %s\n", name,where);
|
|
DBUG_PRINT("warning",("Table: %s is open on %s", name,where));
|
|
pthread_mutex_unlock(&THR_LOCK_maria);
|
|
DBUG_RETURN(1);
|
|
}
|
|
}
|
|
}
|
|
pthread_mutex_unlock(&THR_LOCK_maria);
|
|
DBUG_RETURN(0);
|
|
}
|
|
#endif /* EXTRA_DEBUG */
|