mirror of
https://github.com/MariaDB/server.git
synced 2025-02-02 20:11:42 +01:00
f3985c649d
General overview: The logic for switching to row format when binlog_format=MIXED had numerous flaws. The underlying problem was the lack of a consistent architecture. General purpose of this changeset: This changeset introduces an architecture for switching to row format when binlog_format=MIXED. It enforces the architecture where it has to. It leaves some bugs to be fixed later. It adds extensive tests to verify that unsafe statements work as expected and that appropriate errors are produced by problems with the selection of binlog format. It was not practical to split this into smaller pieces of work. Problem 1: To determine the logging mode, the code has to take several parameters into account (namely: (1) the value of binlog_format; (2) the capabilities of the engines; (3) the type of the current statement: normal, unsafe, or row injection). These parameters may conflict in several ways, namely: - binlog_format=STATEMENT for a row injection - binlog_format=STATEMENT for an unsafe statement - binlog_format=STATEMENT for an engine only supporting row logging - binlog_format=ROW for an engine only supporting statement logging - statement is unsafe and engine does not support row logging - row injection in a table that does not support statement logging - statement modifies one table that does not support row logging and one that does not support statement logging Several of these conflicts were not detected, or were detected with an inappropriate error message. The problem of BUG#39934 was that no appropriate error message was written for the case when an engine only supporting row logging executed a row injection with binlog_format=ROW. However, all above cases must be handled. Fix 1: Introduce new error codes (sql/share/errmsg.txt). Ensure that all conditions are detected and handled in decide_logging_format() Problem 2: The binlog format shall be determined once per statement, in decide_logging_format(). It shall not be changed before or after that. Before decide_logging_format() is called, all information necessary to determine the logging format must be available. This principle ensures that all unsafe statements are handled in a consistent way. However, this principle is not followed: thd->set_current_stmt_binlog_row_based_if_mixed() is called in several places, including from code executing UPDATE..LIMIT, INSERT..SELECT..LIMIT, DELETE..LIMIT, INSERT DELAYED, and SET @@binlog_format. After Problem 1 was fixed, that caused inconsistencies where these unsafe statements would not print the appropriate warnings or errors for some of the conflicts. Fix 2: Remove calls to THD::set_current_stmt_binlog_row_based_if_mixed() from code executed after decide_logging_format(). Compensate by calling the set_current_stmt_unsafe() at parse time. This way, all unsafe statements are detected by decide_logging_format(). Problem 3: INSERT DELAYED is not unsafe: it is logged in statement format even if binlog_format=MIXED, and no warning is printed even if binlog_format=STATEMENT. This is BUG#45825. Fix 3: Made INSERT DELAYED set itself to unsafe at parse time. This allows decide_logging_format() to detect that a warning should be printed or the binlog_format changed. Problem 4: LIMIT clause were not marked as unsafe when executed inside stored functions/triggers/views/prepared statements. This is BUG#45785. Fix 4: Make statements containing the LIMIT clause marked as unsafe at parse time, instead of at execution time. This allows propagating unsafe-ness to the view.
264 lines
8.9 KiB
Text
264 lines
8.9 KiB
Text
--source include/have_ndb.inc
|
|
# Since the master generates row-based events, the slave must be in
|
|
# ROW or MIXED mode to accept the events.
|
|
--source include/have_binlog_format_mixed_or_row.inc
|
|
--source include/ndb_master-slave.inc
|
|
|
|
|
|
|
|
#
|
|
# Bug #11087
|
|
#
|
|
# connect to the master and create tabe t1 in gotoslave database
|
|
--connection master
|
|
CREATE TABLE `t1` ( `nid` int(11) NOT NULL default '0',
|
|
`nom` char(4) default NULL,
|
|
`prenom` char(4) default NULL,
|
|
PRIMARY KEY (`nid`))
|
|
ENGINE=ndbcluster DEFAULT CHARSET=latin1;
|
|
|
|
INSERT INTO t1 VALUES(1,"XYZ1","ABC1");
|
|
select * from t1 order by nid;
|
|
|
|
--sync_slave_with_master
|
|
# connect to slave and ensure data it there.
|
|
--connection slave
|
|
select * from t1 order by nid;
|
|
|
|
--connection master
|
|
delete from t1;
|
|
INSERT INTO t1 VALUES(1,"XYZ2","ABC2");
|
|
# Make sure all rows are on the master
|
|
select * from t1 order by nid;
|
|
|
|
# make sure all rows are on the slave.
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
# Bug #11087 would have row with nid 2 missing
|
|
select * from t1 order by nid;
|
|
|
|
--connection master
|
|
delete from t1;
|
|
insert into t1 values(1,"AA", "AA");
|
|
insert into t1 values(2,"BB", "BB");
|
|
insert into t1 values(3,"CC", "CC");
|
|
insert into t1 values(4,"DD", "DD");
|
|
|
|
begin;
|
|
# delete+insert = update
|
|
delete from t1 where nid = 1;
|
|
insert into t1 values (1,"A2", "A2");
|
|
|
|
# update+delete = delete
|
|
update t1 set nom="B2" where nid = 2;
|
|
delete from t1 where nid = 2;
|
|
|
|
# multi-update
|
|
update t1 set nom = "D2" where nid = 4;
|
|
delete from t1 where nid = 4;
|
|
insert into t1 values (4, "D3", "D3");
|
|
update t1 set nom = "D4" where nid = 4;
|
|
|
|
# insert+delete = nothing
|
|
insert into t1 values (5, "EE", "EE");
|
|
delete from t1 where nid = 5;
|
|
|
|
commit;
|
|
select * from t1 order by 1;
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select * from t1 order by 1;
|
|
--connection master
|
|
DROP table t1;
|
|
|
|
#
|
|
# Test replication of table with no primary key
|
|
#
|
|
--connection master
|
|
CREATE TABLE `t1` ( `nid` int(11) NOT NULL default '0',
|
|
`nom` char(4) default NULL,
|
|
`prenom` char(4) default NULL)
|
|
ENGINE=ndbcluster DEFAULT CHARSET=latin1;
|
|
|
|
INSERT INTO t1 VALUES(1,"XYZ1","ABC1"),(2,"AAA","BBB"),(3,"CCC","DDD");
|
|
select * from t1 order by nid;
|
|
|
|
--sync_slave_with_master
|
|
# connect to slave and ensure data it there.
|
|
--connection slave
|
|
select * from t1 order by nid;
|
|
|
|
--connection master
|
|
delete from t1 where nid = 2;
|
|
INSERT INTO t1 VALUES(4,"EEE","FFF");
|
|
# Make sure all rows are on the master
|
|
select * from t1 order by nid;
|
|
|
|
# make sure all rows are on the slave.
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select * from t1 order by nid;
|
|
|
|
--connection master
|
|
UPDATE t1 set nid=nid+1;
|
|
UPDATE t1 set nom="CCP" where nid = 4;
|
|
select * from t1 order by nid;
|
|
|
|
# make sure all rows are on the slave.
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select * from t1 order by nid;
|
|
|
|
--connection master
|
|
DROP table t1;
|
|
|
|
#
|
|
# Bug #27378 update becomes delete on slave
|
|
#
|
|
|
|
--connection master
|
|
CREATE TABLE `t1` (
|
|
`prid` int(10) unsigned NOT NULL,
|
|
`id_type` enum('IMSI','SIP') NOT NULL,
|
|
`fkimssub` varchar(50) NOT NULL,
|
|
`user_id` varchar(20) DEFAULT NULL,
|
|
`password` varchar(20) DEFAULT NULL,
|
|
`ptg_nbr` varchar(20) DEFAULT NULL,
|
|
`old_tmsi` int(10) unsigned DEFAULT NULL,
|
|
`new_tmsi` int(10) unsigned DEFAULT NULL,
|
|
`dev_capability` int(10) unsigned DEFAULT NULL,
|
|
`dev_oid` bigint(20) unsigned DEFAULT NULL,
|
|
`lac_cell_id` bigint(20) unsigned DEFAULT NULL,
|
|
`ms_classmark1` int(10) unsigned DEFAULT NULL,
|
|
`cipher_key` int(10) unsigned DEFAULT NULL,
|
|
`priid_master` int(10) unsigned DEFAULT NULL,
|
|
PRIMARY KEY (`prid`),
|
|
UNIQUE KEY `fkimssub` (`fkimssub`,`ptg_nbr`) USING HASH
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1;
|
|
|
|
INSERT INTO `t1` VALUES (183342,'IMSI','config3_sub_2Privates_3Publics_imssub_36668','user_id_73336','user_id_73336','73336',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(47617,'IMSI','config3_sub_2Privates_3Publics_imssub_9523','user_id_19046','user_id_19046','19046',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(200332,'IMSI','config3_sub_2Privates_3Publics_imssub_40066','user_id_80132','user_id_80132','80132',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(478882,'IMSI','config3_sub_2Privates_3Publics_imssub_95776','user_id_191552','user_id_191552','191552',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(490146,'IMSI','config3_sub_2Privates_3Publics_imssub_98029','user_id_196057','user_id_196057','196057',NULL,NULL,NULL,1010,NULL,NULL,NULL,NULL),(499301,'IMSI','config3_sub_2Privates_3Publics_imssub_99860','user_id_199719','user_id_199719','199719',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(506101,'IMSI','config3_sub_2Privates_3Publics_imssub_101220','user_id_202439','user_id_202439','202439',NULL,NULL,NULL,1010,NULL,NULL,NULL,NULL),(510142,'IMSI','config3_sub_2Privates_3Publics_imssub_102028','user_id_204056','user_id_204056','204056',NULL,NULL,NULL,1010,NULL,NULL,NULL,NULL),(515871,'IMSI','config3_sub_2Privates_3Publics_imssub_103174','user_id_206347','user_id_206347','206347',NULL,NULL,NULL,1010,NULL,NULL,NULL,NULL),(209842,'IMSI','config3_sub_2Privates_3Publics_imssub_41968','user_id_83936','user_id_83936','83936',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL),(365902,'IMSI','config3_sub_2Privates_3Publics_imssub_73180','user_id_146360','user_id_146360','146360',NULL,NULL,NULL,1010,NULL,NULL,NULL,NULL),(11892,'IMSI','config3_sub_2Privates_3Publics_imssub_2378','user_id_4756','user_id_4756','4756',NULL,NULL,NULL,123456789,NULL,NULL,NULL,NULL);
|
|
|
|
select count(*) from t1;
|
|
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select count(*) from t1;
|
|
|
|
--connection master
|
|
update t1 set dev_oid=dev_oid+1;
|
|
select count(*) from t1;
|
|
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select count(*) from t1;
|
|
|
|
--connection master
|
|
DROP table t1;
|
|
|
|
##################################################################
|
|
#
|
|
# Check that retries are made on the slave on some temporary errors
|
|
#
|
|
|
|
#
|
|
# 1. Deadlock
|
|
#
|
|
--connection master
|
|
CREATE TABLE `t1` ( `nid` int(11) NOT NULL default '0',
|
|
`nom` char(4) default NULL,
|
|
`prenom` char(4) default NULL,
|
|
PRIMARY KEY USING HASH (`nid`))
|
|
ENGINE=ndbcluster DEFAULT CHARSET=latin1;
|
|
INSERT INTO t1 VALUES(1,"XYZ1","ABC1");
|
|
|
|
# cause a lock on that row on the slave
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
--echo **** On Slave ****
|
|
BEGIN;
|
|
UPDATE t1 SET `nom`="LOCK" WHERE `nid`=1;
|
|
|
|
# set number of retries low so we fail the retries
|
|
set GLOBAL slave_transaction_retries=1;
|
|
|
|
# now do a change to this row on the master
|
|
# will deadlock on the slave because of lock above
|
|
--connection master
|
|
--echo **** On Master ****
|
|
UPDATE t1 SET `nom`="DEAD" WHERE `nid`=1;
|
|
|
|
--echo **** On Slave ****
|
|
# Wait for deadlock to be detected.
|
|
# When detected, the slave will stop, so we just wait for it to stop.
|
|
connection slave;
|
|
source include/wait_for_slave_sql_to_stop.inc;
|
|
|
|
# Replication should have stopped, since max retries were not enough.
|
|
# verify with show slave status
|
|
--replace_result $MASTER_MYPORT MASTER_PORT
|
|
--replace_column 1 <Slave_IO_State> 7 <Read_Master_Log_Pos> 8 <Relay_Log_File> 9 <Relay_Log_Pos> 16 <Replicate_Ignore_Table> 19 <Last_Errno> 20 <Last_Error> 22 <Exec_Master_Log_Pos> 23 <Relay_Log_Space> 33 <Seconds_Behind_Master> 35 <Last_IO_Errno> 36 <Last_IO_Error> 37 <Last_SQL_Errno> 38 <Last_SQL_Error>
|
|
--query_vertical SHOW SLAVE STATUS;
|
|
|
|
# now set max retries high enough to succeed, and start slave again
|
|
set GLOBAL slave_transaction_retries=10;
|
|
source include/start_slave.inc;
|
|
# Wait for deadlock to be detected and retried.
|
|
# We want to wait until at least one retry has been made, but before
|
|
# the slave stops. currently, there is no safe way to do that: we
|
|
# would need to access the retry counter, but that is not exposed.
|
|
# Failing that, we just wait sufficiently long that one but not all
|
|
# retries have been made. See BUG#35183.
|
|
sleep 5;
|
|
|
|
# commit transaction to release lock on row and let replication succeed
|
|
select * from t1 order by nid;
|
|
COMMIT;
|
|
|
|
# verify that the row succeded to be applied on the slave
|
|
--connection master
|
|
--sync_slave_with_master
|
|
--connection slave
|
|
select * from t1 order by nid;
|
|
|
|
# cleanup
|
|
--connection master
|
|
DROP TABLE t1;
|
|
|
|
|
|
#
|
|
# BUG#18094
|
|
# Slave caches invalid table definition after atlters causes select failure
|
|
#
|
|
--connection master
|
|
CREATE TABLE t1 (c1 INT KEY) ENGINE=NDB;
|
|
|
|
INSERT INTO t1 VALUES (1),(2),(3),(4),(5),(6),(7),(8),(9),(10);
|
|
|
|
ALTER TABLE t1 ADD c2 INT;
|
|
|
|
--sync_slave_with_master
|
|
connection slave;
|
|
SELECT * FROM t1 ORDER BY c1;
|
|
|
|
connection master;
|
|
ALTER TABLE t1 CHANGE c2 c2 TEXT CHARACTER SET utf8;
|
|
ALTER TABLE t1 CHANGE c2 c2 BLOB;
|
|
|
|
--sync_slave_with_master
|
|
connection slave;
|
|
# here we would get error 1412 prior to bug
|
|
SELECT * FROM t1 ORDER BY c1 LIMIT 5;
|
|
|
|
--connection master
|
|
TRUNCATE t1;
|
|
SELECT count(*) FROM t1;
|
|
INSERT INTO t1 VALUES (101,NULL),(102,NULL),(103,NULL),(104,NULL),(105,NULL),(106,NULL),(107,NULL),(108,NULL),(109,NULL),(1010,NULL);
|
|
--sync_slave_with_master
|
|
connection slave;
|
|
SELECT count(*) FROM t1;
|
|
SELECT c1 FROM t1 ORDER BY c1 LIMIT 5;
|
|
|
|
# cleanup
|
|
--connection master
|
|
DROP TABLE t1;
|
|
-- source include/master-slave-end.inc
|