mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
84 lines
3.1 KiB
C++
84 lines
3.1 KiB
C++
/* Copyright 2018 Codership Oy <info@codership.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
#include "my_global.h"
|
|
#include "wsrep_api.h"
|
|
#include "wsrep_server_state.h"
|
|
#include "wsrep_binlog.h" /* init/deinit group commit */
|
|
|
|
mysql_mutex_t LOCK_wsrep_server_state;
|
|
mysql_cond_t COND_wsrep_server_state;
|
|
|
|
#ifdef HAVE_PSI_INTERFACE
|
|
PSI_mutex_key key_LOCK_wsrep_server_state;
|
|
PSI_cond_key key_COND_wsrep_server_state;
|
|
#endif
|
|
|
|
Wsrep_server_state::Wsrep_server_state(const std::string& name,
|
|
const std::string& incoming_address,
|
|
const std::string& address,
|
|
const std::string& working_dir,
|
|
const wsrep::gtid& initial_position,
|
|
int max_protocol_version)
|
|
: wsrep::server_state(m_mutex,
|
|
m_cond,
|
|
m_service,
|
|
NULL,
|
|
name,
|
|
incoming_address,
|
|
address,
|
|
working_dir,
|
|
initial_position,
|
|
max_protocol_version,
|
|
wsrep::server_state::rm_sync)
|
|
, m_mutex(&LOCK_wsrep_server_state)
|
|
, m_cond(&COND_wsrep_server_state)
|
|
, m_service(*this)
|
|
{ }
|
|
|
|
Wsrep_server_state::~Wsrep_server_state() = default;
|
|
|
|
void Wsrep_server_state::init_once(const std::string& name,
|
|
const std::string& incoming_address,
|
|
const std::string& address,
|
|
const std::string& working_dir,
|
|
const wsrep::gtid& initial_position,
|
|
int max_protocol_version)
|
|
{
|
|
if (m_instance == 0)
|
|
{
|
|
mysql_mutex_init(key_LOCK_wsrep_server_state, &LOCK_wsrep_server_state,
|
|
MY_MUTEX_INIT_FAST);
|
|
mysql_cond_init(key_COND_wsrep_server_state, &COND_wsrep_server_state, 0);
|
|
m_instance = new Wsrep_server_state(name,
|
|
incoming_address,
|
|
address,
|
|
working_dir,
|
|
initial_position,
|
|
max_protocol_version);
|
|
}
|
|
}
|
|
|
|
void Wsrep_server_state::destroy()
|
|
{
|
|
|
|
if (m_instance)
|
|
{
|
|
delete m_instance;
|
|
m_instance= 0;
|
|
mysql_mutex_destroy(&LOCK_wsrep_server_state);
|
|
mysql_cond_destroy(&COND_wsrep_server_state);
|
|
}
|
|
}
|