mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 22:12:30 +01:00
b534ca4bc0
- BUG#22306: STOP INSTANCE can not be applied for instances in Crashed,
Failed and Abandoned;
- BUG#23476: DROP INSTANCE does not work
- BUG#23215: STOP INSTANCE takes too much time
BUG#22306:
The problem was that STOP INSTANCE checked that mysqld is up and running.
If it was not so, STOP INSTANCE reported an error. Now, STOP INSTANCE
reports an error if the instance has been started (mysqld can be down).
BUG#23476:
The problem was that DROP INSTANCE tried to stop inactive instance. The fix is
trivial.
BUG#23215:
The problem was that locks were not acquired properly, so the
instance-monitoring thread could not acquire the mutex, holded by the
query-processing thread.
The fix is to simplify locking scheme by moving instance-related information to
Instance-class out of Guardian-class. This allows to get rid of storing a
separate list of Instance-information in Guardian and keeping it synchronized
with the original list in Instance_map.
70 lines
2 KiB
C++
70 lines
2 KiB
C++
#ifndef INCLUDES_MYSQL_INSTANCE_MANAGER_MANAGER_H
|
|
#define INCLUDES_MYSQL_INSTANCE_MANAGER_MANAGER_H
|
|
/* Copyright (C) 2003 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#if defined(__GNUC__) && defined(USE_PRAGMA_INTERFACE)
|
|
#pragma interface
|
|
#endif
|
|
|
|
#include <my_global.h>
|
|
|
|
class Guardian;
|
|
class Instance_map;
|
|
class Thread_registry;
|
|
class User_map;
|
|
|
|
class Manager
|
|
{
|
|
public:
|
|
static int main();
|
|
|
|
static bool flush_instances();
|
|
|
|
public:
|
|
/**
|
|
These methods return a non-NULL value only for the duration
|
|
of main().
|
|
*/
|
|
static Instance_map *get_instance_map() { return p_instance_map; }
|
|
static Guardian *get_guardian() { return p_guardian; }
|
|
static Thread_registry *get_thread_registry() { return p_thread_registry; }
|
|
static User_map *get_user_map() { return p_user_map; }
|
|
|
|
public:
|
|
#ifndef __WIN__
|
|
static bool is_linux_threads() { return linux_threads; }
|
|
#endif // __WIN__
|
|
|
|
private:
|
|
static void stop_all_threads();
|
|
|
|
private:
|
|
static Guardian *p_guardian;
|
|
static Instance_map *p_instance_map;
|
|
static Thread_registry *p_thread_registry;
|
|
static User_map *p_user_map;
|
|
|
|
#ifndef __WIN__
|
|
/*
|
|
This flag is set if Instance Manager is running on the system using
|
|
LinuxThreads.
|
|
*/
|
|
static bool linux_threads;
|
|
#endif // __WIN__
|
|
};
|
|
|
|
#endif // INCLUDES_MYSQL_INSTANCE_MANAGER_MANAGER_H
|