mariadb/mysql-test
unknown b25315469e Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
The GROUP_CONCAT uses its own temporary table. When ROLLUP is present
it creates the second copy of Item_func_group_concat. This copy receives the
same list of arguments that original group_concat does. When the copy is
set up the result_fields of functions from the argument list are reset to the
temporary table of this copy.
As a result of this action data from functions flow directly to the ROLLUP copy
and the original group_concat functions shows wrong result.
Since queries with COUNT(DISTINCT ...) use temporary tables to store
the results the COUNT function they are also affected by this bug.

The idea of the fix is to copy content of the result_field for the function
under GROUP_CONCAT/COUNT from  the first temporary table to the second one,
rather than setting result_field to point to the second temporary table.
To achieve this goal force_copy_fields flag is added to Item_func_group_concat
and Item_sum_count_distinct classes. This flag is initialized to 0 and set to 1
into the make_unique() member function of both classes.
To the TMP_TABLE_PARAM structure is modified to include the similar flag as
well.
The create_tmp_table() function passes that flag to create_tmp_field().
When the flag is set the create_tmp_field() function will set result_field
as a source field and will not reset that result field to newly created 
field for Item_func_result_field and its descendants. Due to this there
will be created copy func to copy data from old result_field to newly 
created field.


mysql-test/t/func_gconcat.test:
  Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
mysql-test/r/func_gconcat.result:
  Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
sql/sql_table.cc:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  Added 0 as a last parameter to create_tmp_field()  to force old behaviour.
sql/sql_select.cc:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  
  Added the flag 'make_copy_field' to create_tmp_field(), so that for Item_result_field descendants create_tmp_field() sets the item's result field as a source field and deny resetting that result field to a new value.
sql/sql_class.h:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  Added the flag 'force_copy_fields' to the structure TMP_TABLE_PARAM in order to make create_tmp_field() force the creation of 'copy_field' objects.
sql/mysql_priv.h:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  Added the bool parameter 'make_copy_field' to create_tmp_field().
sql/item_sum.cc:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  Added initialization of the force_copy_fields flag and passing it to create_tmp_table() through TMP_TBLE_PARAM in the Item_func_group_concat and Item_sum_count_distinct member functions.
sql/item_sum.h:
  Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
  Added the flag 'force_copy_fields' to the Item_func_group_concat and Item_sum_count_distinct classes.
2006-03-29 23:30:34 +04:00
..
include Bug#15377 Valid multibyte sequences are truncated on INSERT 2005-12-09 16:37:58 +04:00
lib Fix a race on some platforms in mysql-test-run.pl, where it would sometimes 2006-02-11 22:50:59 +01:00
misc
ndb reintroduce --no-defaults to ndb_mgmd 2006-01-20 00:08:26 +11:00
r Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries 2006-03-29 23:30:34 +04:00
std_data Merge mysql.com:/home/jimw/my/mysql-4.1-11203 2005-10-21 17:57:51 -07:00
suite/jp
t Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries 2006-03-29 23:30:34 +04:00
create-test-result
fix-result
init_db.sql
install_test_db.sh
Makefile.am Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 2005-11-04 01:15:35 +01:00
my_create_tables.c
my_manage.c Some fixes to avoid compiler warnings. 2005-10-18 18:03:26 +03:00
my_manage.h
mysql-test-run.pl mysql-test-run.{pl,sh}: 2006-02-11 23:35:23 +01:00
mysql-test-run.sh mysql-test-run.{pl,sh}: 2006-02-11 23:35:23 +01:00
mysql_test_run_new.c Some fixes to avoid compiler warnings. 2005-10-18 18:03:26 +03:00
README fix README file to be more verbose match actual situation (recomitted to push into 4.1) 2005-06-22 05:18:43 +02:00
README.gcov
resolve-stack
suppress.purify

This directory contains a test suite for mysql daemon. To run
the currently existing test cases, simply execute ./mysql-test-run in
this directory. It will fire up the newly built mysqld and test it.

If you want to run a test with a running MySQL server use the --extern
option to mysql-test-run. Please note that in this mode the test suite
expects user to specify test names to run. Otherwise it falls back to the
normal "non-extern" behaviour. The reason is that some tests
could not run with external server. Here is the sample command
to test "alias" and "analyze" tests on external server:

mysql-test-run --extern alias analyze

To match your setup you might also need to provide --socket, --user and
other relevant options.

Note that you do not have to have to do make install, and you could
actually have a co-existing MySQL installation - the tests will not
conflict with it.

All tests must pass. If one or more of them fail on your system, please
read the following manual section of how to report the problem:

http://dev.mysql.com/doc/mysql/en/MySQL_test_suite.html


You can create your own test cases. To create a test case:

 xemacs t/test_case_name.test

 in the file, put a set of SQL commands that will create some tables,
 load test data, run some queries to manipulate it.

 We would appreciate if the test tables were called t1, t2, t3 ... (to not
 conflict too much with existing tables).

 Your test should begin by dropping the tables you are going to create and
 end by dropping them again.  This will ensure that one can run the test
 over and over again.
 
 If you are using mysqltest commands (like result file names) in your
 test case you should do create the result file as follows:

 mysql-test-run --record test_case_name

 or

 mysqltest --record < t/test_case_name.test

 If you only have a simple test cases consistent of SQL commands and comments
 you can create the test case one of the following ways:

 mysql-test-run --record test_case_name

 mysql test < t/test_case_name.test > r/test_case_name.result

 mysqltest --record --record-file=r/test_case_name.result < t/test_case_name.test

 When this is done, take a look at r/test_case_name.result
 - If the result is wrong, you have found a bug;  In this case you should
   edit the test result to the correct results so that we can verify
   that the bug is corrected in future releases.

To submit your test case, put your .test file and .result file(s) into
a tar.gz archive, add a README that explains the problem, ftp the 
archive to ftp://support.mysql.com/pub/mysql/secret/ and send  a mail
to bugs@lists.mysql.com