mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
0eb26fdfa8
Apart strict-aliasing warnings, fix the remaining warnings generated by GCC 4.4.4 -Wall and -Wextra flags. One major source of warnings was the in-house function my_bcmp which (unconventionally) took pointers to unsigned characters as the byte sequences to be compared. Since my_bcmp and bcmp are deprecated functions whose only difference with memcmp is the return value, every use of the function is replaced with memcmp as the special return value wasn't actually being used by any caller. There were also various other warnings, mostly due to type mismatches, missing return values, missing prototypes, dead code (unreachable) and ignored return values. BUILD/SETUP.sh: Remove flags that are implied by -Wall and -Wextra. Do not warn about unused parameters in C++. BUILD/check-cpu: Print only the compiler version instead of verbose banner. Although the option is gcc specific, the check was only being used for GCC specific checks anyway. client/mysql.cc: bcmp is no longer defined. client/mysqltest.cc: Pass a string to function expecting a format string. Replace use of bcmp with memcmp. cmd-line-utils/readline/Makefile.am: Always define _GNU_SOURCE when compiling GNU readline. Required to make certain prototypes visible. cmd-line-utils/readline/input.c: Condition for the code to be meaningful. configure.in: Remove check for bcmp. extra/comp_err.c: Use appropriate type. extra/replace.c: Replace use of bcmp with memcmp. extra/yassl/src/crypto_wrapper.cpp: Do not ignore the return value of fgets. Retrieve the file position if fgets succeed -- if it fails, the function will bail out and return a error. extra/yassl/taocrypt/include/blowfish.hpp: Use a single array instead of accessing positions of the sbox_ through a subscript to pbox_. extra/yassl/taocrypt/include/runtime.hpp: One definition of such functions is enough. extra/yassl/taocrypt/src/aes.cpp: Avoid potentially ambiguous conditions. extra/yassl/taocrypt/src/algebra.cpp: Rename arguments to avoid shadowing related warnings. extra/yassl/taocrypt/src/blowfish.cpp: Avoid potentially ambiguous conditions. extra/yassl/taocrypt/src/integer.cpp: Do not define type within a anonymous union. Use a variable to return a value instead of leaving the result in a register -- compiler does not know the logic inside the asm. extra/yassl/taocrypt/src/misc.cpp: Define handler for pure virtual functions. Remove unused code. extra/yassl/taocrypt/src/twofish.cpp: Avoid potentially ambiguous conditions. extra/yassl/testsuite/test.hpp: Function must have C language linkage. include/m_string.h: Remove check which relied on bcmp being defined -- they weren't being used as bcmp is only visible when _BSD_SOURCE is defined. include/my_bitmap.h: Remove bogus helpers which were used only in a few files and were causing warnings about dead code. include/my_global.h: Due to G++ bug, always silence false-positive uninitialized variables warnings when compiling C++ code with G++. Remove bogus helper. libmysql/Makefile.shared: Remove built-in implementation of bcmp. mysql-test/lib/My/SafeProcess/safe_process.cc: Cast pid to largest possible type for a process identifier. mysys/mf_loadpath.c: Leave space of the ending nul. mysys/mf_pack.c: Replace bcmp with memcmp. mysys/my_bitmap.c: Dead code removal. mysys/my_gethwaddr.c: Remove unused variable. mysys/my_getopt.c: Silence bogus uninitialized variable warning. Do not cast away the constant qualifier. mysys/safemalloc.c: Cast to expected type. mysys/thr_lock.c: Silence bogus uninitialized variable warning. sql/field.cc: Replace bogus helper with a more appropriate logic which is used throughout the code. sql/item.cc: Remove bogus logical condition which always evaluates to TRUE. sql/item_create.cc: Simplify code to avoid signedness related warnings. sql/log_event.cc: Replace use of bcmp with memcmp. No need to use helpers for simple bit operations. sql/log_event_old.cc: Replace bmove_align with memcpy. sql/mysqld.cc: Move use declaration of variable to the ifdef block where it is used. Remove now-unnecessary casts and arguments. sql/set_var.cc: Replace bogus helpers with simple and classic bit operations. sql/slave.cc: Cast to expected type and silence bogus warning. sql/sql_class.h: Don't use enum values as bit flags, the supposed type safety is bogus as the combined bit flags are not a value in the enumeration. sql/udf_example.c: Only declare variable when necessary. sql/unireg.h: Replace use of bmove_align with memcpy. storage/innobase/os/os0file.c: Silence bogus warning. storage/myisam/mi_open.c: Remove bogus cast, DBUG_DUMP expects a pointer to unsigned char. storage/myisam/mi_page.c: Remove bogus cast, DBUG_DUMP expects a pointer to unsigned char. strings/bcmp.c: Remove built-in bcmp. strings/ctype-ucs2.c: Silence bogus warning. tests/mysql_client_test.c: Use a appropriate type as expected by simple_command(). |
||
|---|---|---|
| .. | ||
| .cvsignore | ||
| autorun.sh | ||
| build_mccge.sh | ||
| check-cpu | ||
| cleanup | ||
| compile-alpha | ||
| compile-alpha-ccc | ||
| compile-alpha-cxx | ||
| compile-alpha-debug | ||
| compile-amd64-debug-max | ||
| compile-amd64-debug-max-no-ndb | ||
| compile-amd64-gcov | ||
| compile-amd64-gprof | ||
| compile-amd64-max | ||
| compile-amd64-max-sci | ||
| compile-amd64-valgrind-max | ||
| compile-darwin-mwcc | ||
| compile-dist | ||
| compile-hpux11-parisc2-aCC | ||
| compile-ia64-debug-max | ||
| compile-irix-mips64-mipspro | ||
| compile-ndb-autotest | ||
| compile-pentium | ||
| compile-pentium-cybozu | ||
| compile-pentium-debug | ||
| compile-pentium-debug-max | ||
| compile-pentium-debug-max-no-embedded | ||
| compile-pentium-debug-max-no-ndb | ||
| compile-pentium-debug-openssl | ||
| compile-pentium-debug-yassl | ||
| compile-pentium-gcov | ||
| compile-pentium-gprof | ||
| compile-pentium-icc | ||
| compile-pentium-icc-valgrind-max | ||
| compile-pentium-icc-yassl | ||
| compile-pentium-max | ||
| compile-pentium-myodbc | ||
| compile-pentium-mysqlfs-debug | ||
| compile-pentium-pgcc | ||
| compile-pentium-valgrind-max | ||
| compile-pentium-valgrind-max-no-ndb | ||
| compile-pentium64 | ||
| compile-pentium64-debug | ||
| compile-pentium64-debug-max | ||
| compile-pentium64-gcov | ||
| compile-pentium64-gprof | ||
| compile-pentium64-max | ||
| compile-pentium64-max-sci | ||
| compile-pentium64-valgrind-max | ||
| compile-ppc | ||
| compile-ppc-debug | ||
| compile-ppc-debug-max | ||
| compile-ppc-debug-max-no-ndb | ||
| compile-ppc-max | ||
| compile-solaris-amd64 | ||
| compile-solaris-amd64-debug | ||
| compile-solaris-amd64-forte | ||
| compile-solaris-amd64-forte-debug | ||
| compile-solaris-sparc | ||
| compile-solaris-sparc-debug | ||
| compile-solaris-sparc-forte | ||
| compile-solaris-sparc-purify | ||
| FINISH.sh | ||
| Makefile.am | ||
| SETUP.sh | ||