mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 03:52:35 +01:00
af12ff6568
Approximative, because it's using our binlogging way (what we call "query"-level) and this is not as good as record-level binlog (5.1) would be. It imposes several
limitations to routines, and has caveats (which I'll document, and for which the server will try to issue errors but that is not always possible).
Reason I don't propagate caller info to the binlog as planned is that on master and slave
users may be different; even with that some caveats would remain.
mysql-test/mysql-test-run.sh:
In the testsuite we know what we do, we are not creating nasty routines, and breaking binlog is ok except in rpl_sp.
mysql-test/r/blackhole.result:
Updating results now that 4.1 has been merged
mysql-test/valgrind.supp:
Some suppressions for Valgrind (useful on my machine Suse 9.1);
this is just adding to the already existing suppressions of pthread and dl.
sql/item_func.cc:
Don't binlog the substatements when executing a function. If the function
is declared to modify data and does not complete, warning "broken binlog".
Note that SELECT myfunc() will not be binlogged even if myfunc() updates data (will be documented);
but INSERT INTO t VALUES(myfunc()) will be binlogged (what decides is if the caller
gets binlogged; the function changes nothing to binlogging).
sql/log_event.cc:
Just making functions which can be re-used when we binlog more strings
in status_vars in Query_log_event (e.g. one day "user", "host").
sql/log_event.h:
comment
sql/mysql_priv.h:
--log-bin-trust-routine-creators
sql/mysqld.cc:
--log-bin-trust-routine-creators
sql/set_var.cc:
--log-bin-trust-routine-creators
sql/share/errmsg.txt:
error messages to warn about problems with routines and binlog
sql/slave.cc:
If in a routine, replication table inclusion/exclusion rules always answer "replicate!" (see comment in code).
sql/sp.cc:
If binlog is on: errors if one wants to create a non-deterministic update routine
(repeatability problem - note that the test is not perfect for functions) or does not have SUPER (because routines can easily
be made to destroy slave's data with just CREATE ROUTINE and EXECUTE priv on master).
--log-bin-trust-routine-creators removes these errors.
Binlogging of CREATE PROCEDURE|FUNCTION.
sql/sql_acl.cc:
No thd==0 in tables_ok().
sql/sql_parse.cc:
Binlogging of CALL (and not of the substatements of the SP).
If SP returns error, we don't binlog it (see comment); we push warning in this case.
Binlogging of ALTER|DROP PROCEDURE|FUNCTION with safety messages.
134 lines
2 KiB
Text
134 lines
2 KiB
Text
#
|
|
# Suppress some common (not fatal) errors in system libraries found by valgrind
|
|
#
|
|
|
|
#
|
|
# Pthread doesn't free all thread specific memory before program exists
|
|
#
|
|
{
|
|
pthread allocate_tls memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_allocate_tls
|
|
fun:allocate_stack
|
|
fun:pthread_create@@GLIBC_2.1
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread memalign memory loss
|
|
Memcheck:Leak
|
|
fun:memalign
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
pthread errno
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dlerror_run
|
|
fun:dlsym
|
|
fun:__errno_location
|
|
}
|
|
|
|
|
|
#
|
|
# Warnings in libz becasue it works with aligned memory(?)
|
|
#
|
|
|
|
{
|
|
libz tr_flush_block
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
fun:gzclose
|
|
}
|
|
|
|
{
|
|
libz tr_flush_block2
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz longest_match
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
}
|
|
|
|
{
|
|
libz longest_match2
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz deflate
|
|
Memcheck:Cond
|
|
obj:/usr/lib/libz.so.*
|
|
obj:/usr/lib/libz.so.*
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|