mirror of
https://github.com/MariaDB/server.git
synced 2025-01-22 14:54:20 +01:00
f3985c649d
General overview: The logic for switching to row format when binlog_format=MIXED had numerous flaws. The underlying problem was the lack of a consistent architecture. General purpose of this changeset: This changeset introduces an architecture for switching to row format when binlog_format=MIXED. It enforces the architecture where it has to. It leaves some bugs to be fixed later. It adds extensive tests to verify that unsafe statements work as expected and that appropriate errors are produced by problems with the selection of binlog format. It was not practical to split this into smaller pieces of work. Problem 1: To determine the logging mode, the code has to take several parameters into account (namely: (1) the value of binlog_format; (2) the capabilities of the engines; (3) the type of the current statement: normal, unsafe, or row injection). These parameters may conflict in several ways, namely: - binlog_format=STATEMENT for a row injection - binlog_format=STATEMENT for an unsafe statement - binlog_format=STATEMENT for an engine only supporting row logging - binlog_format=ROW for an engine only supporting statement logging - statement is unsafe and engine does not support row logging - row injection in a table that does not support statement logging - statement modifies one table that does not support row logging and one that does not support statement logging Several of these conflicts were not detected, or were detected with an inappropriate error message. The problem of BUG#39934 was that no appropriate error message was written for the case when an engine only supporting row logging executed a row injection with binlog_format=ROW. However, all above cases must be handled. Fix 1: Introduce new error codes (sql/share/errmsg.txt). Ensure that all conditions are detected and handled in decide_logging_format() Problem 2: The binlog format shall be determined once per statement, in decide_logging_format(). It shall not be changed before or after that. Before decide_logging_format() is called, all information necessary to determine the logging format must be available. This principle ensures that all unsafe statements are handled in a consistent way. However, this principle is not followed: thd->set_current_stmt_binlog_row_based_if_mixed() is called in several places, including from code executing UPDATE..LIMIT, INSERT..SELECT..LIMIT, DELETE..LIMIT, INSERT DELAYED, and SET @@binlog_format. After Problem 1 was fixed, that caused inconsistencies where these unsafe statements would not print the appropriate warnings or errors for some of the conflicts. Fix 2: Remove calls to THD::set_current_stmt_binlog_row_based_if_mixed() from code executed after decide_logging_format(). Compensate by calling the set_current_stmt_unsafe() at parse time. This way, all unsafe statements are detected by decide_logging_format(). Problem 3: INSERT DELAYED is not unsafe: it is logged in statement format even if binlog_format=MIXED, and no warning is printed even if binlog_format=STATEMENT. This is BUG#45825. Fix 3: Made INSERT DELAYED set itself to unsafe at parse time. This allows decide_logging_format() to detect that a warning should be printed or the binlog_format changed. Problem 4: LIMIT clause were not marked as unsafe when executed inside stored functions/triggers/views/prepared statements. This is BUG#45785. Fix 4: Make statements containing the LIMIT clause marked as unsafe at parse time, instead of at execution time. This allows propagating unsafe-ness to the view.
160 lines
4.3 KiB
Text
160 lines
4.3 KiB
Text
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
set @old_slave_exec_mode= @@global.slave_exec_mode;
|
|
set @@global.slave_exec_mode= IDEMPOTENT;
|
|
create table ti1 (b int primary key) engine = innodb;
|
|
create table ti2 (a int primary key, b int, foreign key (b) references ti1(b))
|
|
engine = innodb;
|
|
set foreign_key_checks=1 /* ensure the check */;
|
|
insert into ti1 values (1),(2),(3);
|
|
insert into ti2 set a=2, b=2;
|
|
select * from ti1 order by b /* must be (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
insert into ti2 set a=1, b=1;
|
|
select * from ti2 order by b /* must be (1,1) (2,2) */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
set @save_binlog_format= @@session.binlog_format;
|
|
set @@session.binlog_format= row;
|
|
delete from ti1 where b=1;
|
|
select * from ti1 order by b /* must be (2),(3) */;
|
|
b
|
|
2
|
|
3
|
|
select * from ti1 order by b /* must stays as were on master (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
delete from ti1 where b=3;
|
|
insert into ti2 set a=3, b=3;
|
|
select * from ti2 order by b /* must be (1,1),(2,2) - not inserted */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
set global slave_exec_mode='STRICT';
|
|
set global slave_exec_mode='IDEMPOTENT,STRICT';
|
|
ERROR HY000: Ambiguous slave modes combination.
|
|
select @@global.slave_exec_mode /* must be STRICT */;
|
|
@@global.slave_exec_mode
|
|
STRICT
|
|
*** foreign keys errors as above now forces to stop
|
|
set foreign_key_checks=0;
|
|
drop table ti2, ti1;
|
|
create table ti1 (b int primary key) engine = innodb;
|
|
create table ti2 (a int primary key, b int, foreign key (b) references ti1(b))
|
|
engine = innodb;
|
|
set foreign_key_checks=1 /* ensure the check */;
|
|
insert into ti1 values (1),(2),(3);
|
|
insert into ti2 set a=2, b=2;
|
|
select * from ti1 order by b /* must be (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
*** conspire future problem
|
|
insert into ti2 set a=1, b=1;
|
|
select * from ti2 order by b /* must be (1,1) (2,2) */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
delete from ti1 where b=1 /* offending delete event */;
|
|
select * from ti1 order by b /* must be (2),(3) */;
|
|
b
|
|
2
|
|
3
|
|
*** slave must stop (Trying to delete a referenced foreing key)
|
|
Last_SQL_Error
|
|
1451
|
|
select * from ti1 order by b /* must be (1),(2),(3) - not deleted */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
set foreign_key_checks= 0;
|
|
delete from ti2 where b=1;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
*** conspire the following insert failure
|
|
*** conspire future problem
|
|
delete from ti1 where b=3;
|
|
insert into ti2 set a=3, b=3 /* offending write event */;
|
|
*** slave must stop (Trying to insert an invalid foreign key)
|
|
Last_SQL_Error
|
|
1452
|
|
select * from ti2 order by b /* must be (2,2) */;
|
|
a b
|
|
2 2
|
|
set foreign_key_checks= 0;
|
|
insert into ti1 set b=3;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
select * from ti2 order by b /* must be (2,2),(3,3) */;
|
|
a b
|
|
2 2
|
|
3 3
|
|
*** other errors
|
|
*** conspiring query
|
|
insert into ti1 set b=1;
|
|
insert into ti1 set b=1 /* offending write event */;
|
|
*** slave must stop (Trying to insert a dupliacte key)
|
|
Last_SQL_Error
|
|
1062
|
|
set foreign_key_checks= 0;
|
|
delete from ti1 where b=1;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
CREATE TABLE t1 (a INT PRIMARY KEY);
|
|
CREATE TABLE t2 (a INT);
|
|
INSERT INTO t1 VALUES (-1),(-2),(-3);
|
|
INSERT INTO t2 VALUES (-1),(-2),(-3);
|
|
DELETE FROM t1 WHERE a = -2;
|
|
DELETE FROM t2 WHERE a = -2;
|
|
DELETE FROM t1 WHERE a = -2;
|
|
*** slave must stop (Key was not found)
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
DELETE FROM t2 WHERE a = -2;
|
|
*** slave must stop (Key was not found)
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
*** slave must stop (Key was not found)
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
*** slave must stop (Key was not found)
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
SET @@global.slave_exec_mode= @old_slave_exec_mode;
|
|
drop table t1,t2,ti2,ti1;
|
|
set @@global.slave_exec_mode= @old_slave_exec_mode;
|
|
*** end of tests
|