mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 10:14:19 +01:00
5a759d31f7
Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char*) to (char*) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."*' is not anymore same as table_name.* - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)
102 lines
2.8 KiB
C++
102 lines
2.8 KiB
C++
/* Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
|
|
/* Procedures (functions with changes output of select) */
|
|
|
|
#ifdef USE_PRAGMA_IMPLEMENTATION
|
|
#pragma implementation // gcc: Class implementation
|
|
#endif
|
|
|
|
#include <my_global.h>
|
|
#include "sql_priv.h"
|
|
#include "procedure.h"
|
|
#include "sql_analyse.h" // Includes procedure
|
|
#ifdef USE_PROC_RANGE
|
|
#include "proc_range.h"
|
|
#endif
|
|
|
|
static struct st_procedure_def {
|
|
const char *name;
|
|
Procedure *(*init)(THD *thd,ORDER *param,select_result *result,
|
|
List<Item> &field_list);
|
|
} sql_procs[] = {
|
|
#ifdef USE_PROC_RANGE
|
|
{ "split_sum",proc_sum_range_init }, // Internal procedure at TCX
|
|
{ "split_count",proc_count_range_init }, // Internal procedure at TCX
|
|
{ "matris_ranges",proc_matris_range_init }, // Internal procedure at TCX
|
|
#endif
|
|
{ "analyse",proc_analyse_init } // Analyse a result
|
|
};
|
|
|
|
|
|
my_decimal *Item_proc_string::val_decimal(my_decimal *decimal_value)
|
|
{
|
|
if (null_value)
|
|
return 0;
|
|
string2my_decimal(E_DEC_FATAL_ERROR, &str_value, decimal_value);
|
|
return (decimal_value);
|
|
}
|
|
|
|
|
|
my_decimal *Item_proc_int::val_decimal(my_decimal *decimal_value)
|
|
{
|
|
if (null_value)
|
|
return 0;
|
|
int2my_decimal(E_DEC_FATAL_ERROR, value, unsigned_flag, decimal_value);
|
|
return (decimal_value);
|
|
}
|
|
|
|
|
|
my_decimal *Item_proc_real::val_decimal(my_decimal *decimal_value)
|
|
{
|
|
if (null_value)
|
|
return 0;
|
|
double2my_decimal(E_DEC_FATAL_ERROR, value, decimal_value);
|
|
return (decimal_value);
|
|
}
|
|
|
|
|
|
/**
|
|
Setup handling of procedure.
|
|
|
|
@return
|
|
Return 0 if everything is ok
|
|
*/
|
|
|
|
|
|
Procedure *
|
|
setup_procedure(THD *thd,ORDER *param,select_result *result,
|
|
List<Item> &field_list,int *error)
|
|
{
|
|
uint i;
|
|
DBUG_ENTER("setup_procedure");
|
|
*error=0;
|
|
if (!param)
|
|
DBUG_RETURN(0);
|
|
for (i=0 ; i < array_elements(sql_procs) ; i++)
|
|
{
|
|
if (!my_strcasecmp(system_charset_info,
|
|
(*param->item)->name.str, sql_procs[i].name))
|
|
{
|
|
Procedure *proc=(*sql_procs[i].init)(thd,param,result,field_list);
|
|
*error= !proc;
|
|
DBUG_RETURN(proc);
|
|
}
|
|
}
|
|
my_error(ER_UNKNOWN_PROCEDURE, MYF(0), (*param->item)->name);
|
|
*error=1;
|
|
DBUG_RETURN(0);
|
|
}
|