mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 12:32:27 +01:00
4f18083b08
The problem was that TRUNCATE TABLE didn't take a exclusive lock on a table if it resorted to truncating via delete of all rows in the table. Specifically for InnoDB tables, this could break proper isolation as InnoDB ends up aborting some granted locks when truncating a table. The solution is to take a exclusive metadata lock before TRUNCATE TABLE can proceed. This guarantees that no other transaction is using the table. Incompatible change: Truncate via delete no longer fails if sql_safe_updates is activated (this was a undocumented side effect). libmysqld/CMakeLists.txt: Add new files to the build list. libmysqld/Makefile.am: Add new files to the build list. mysql-test/extra/binlog_tests/binlog_truncate.test: Add test case for Bug#42643 mysql-test/include/mix1.inc: Update test case as TRUNCATE TABLE now grabs a exclusive lock. Ensure that TRUNCATE waits for granted locks on the table. mysql-test/suite/binlog/t/binlog_truncate_innodb.test: As with other data modifying statements, TRUNCATE is still not possible in a transaction with isolation level READ COMMITTED or READ UNCOMMITED. It would be possible to implement so, but it is not worth the effort. mysql-test/suite/binlog/t/binlog_truncate_myisam.test: Test under different binlog formats. mysql-test/suite/binlog/t/disabled.def: Re-enable test case. mysql-test/t/innodb_bug38231.test: Truncate no longer works with row-level locks. mysql-test/t/mdl_sync.test: Ensure that a acquired lock is not given up due to a conflict. mysql-test/t/partition_innodb_semi_consistent.test: End transaction as to release metadata locks. mysql-test/t/truncate.test: A metadata lock is now taken before the object is verified. sql/CMakeLists.txt: Add new files to the build list. sql/Makefile.am: Add new files to the build list. sql/datadict.cc: Introduce a new file specific for data dictionary operations. sql/datadict.h: Add header file. sql/sql_base.cc: Rename data dictionary function. sql/sql_bitmap.h: Include dependency. sql/sql_delete.cc: Move away from relying on mysql_delete() to delete all rows of a table. Thus, move any bits related to truncate to sql_truncate.cc sql/sql_delete.h: Remove parameter. sql/sql_parse.cc: Add protection against the global read lock -- a intention exclusive lock can be acquired in the truncate path. sql/sql_show.cc: Add sync point for testing scenarios where a pending flush is ignored. sql/sql_truncate.cc: Acquire a shared metadata lock before accessing table metadata. Upgrade the lock to a exclusive one if the table can be re-created. Rework binlog rules to better reflect the requirements. sql/sql_yacc.yy: Set appropriate lock types for table to be truncated. sql/table.h: Move to data dictionary header.
161 lines
3.6 KiB
Text
161 lines
3.6 KiB
Text
drop table if exists t1, t2;
|
|
create table t1 (a integer, b integer,c1 CHAR(10));
|
|
insert into t1 (a) values (1),(2);
|
|
truncate table t1;
|
|
select count(*) from t1;
|
|
count(*)
|
|
0
|
|
insert into t1 values(1,2,"test");
|
|
select count(*) from t1;
|
|
count(*)
|
|
1
|
|
delete from t1;
|
|
select * from t1;
|
|
a b c1
|
|
drop table t1;
|
|
select count(*) from t1;
|
|
ERROR 42S02: Table 'test.t1' doesn't exist
|
|
create temporary table t1 (n int);
|
|
insert into t1 values (1),(2),(3);
|
|
truncate table t1;
|
|
select * from t1;
|
|
n
|
|
drop table t1;
|
|
truncate non_existing_table;
|
|
ERROR 42S02: Table 'test.non_existing_table' doesn't exist
|
|
create table t1 (a integer auto_increment primary key);
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
truncate table t1;
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
SELECT * from t1;
|
|
a
|
|
1
|
|
2
|
|
delete from t1;
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
SELECT * from t1;
|
|
a
|
|
3
|
|
4
|
|
drop table t1;
|
|
create temporary table t1 (a integer auto_increment primary key);
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
truncate table t1;
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
SELECT * from t1;
|
|
a
|
|
1
|
|
2
|
|
delete from t1;
|
|
insert into t1 (a) values (NULL),(NULL);
|
|
SELECT * from t1;
|
|
a
|
|
3
|
|
4
|
|
drop table t1;
|
|
create table t1 (s1 int);
|
|
insert into t1 (s1) values (1), (2), (3), (4), (5);
|
|
create view v1 as select * from t1;
|
|
truncate table v1;
|
|
ERROR 42S02: Table 'test.v1' doesn't exist
|
|
drop view v1;
|
|
drop table t1;
|
|
#
|
|
# Bug#20667 - Truncate table fails for a write locked table
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
LOCK TABLE t1 WRITE;
|
|
INSERT INTO t1 VALUES (1);
|
|
SELECT * FROM t1;
|
|
c1
|
|
1
|
|
TRUNCATE TABLE t1;
|
|
SELECT * FROM t1;
|
|
c1
|
|
UNLOCK TABLES;
|
|
LOCK TABLE t1 READ;
|
|
TRUNCATE TABLE t1;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
UNLOCK TABLES;
|
|
CREATE TABLE t2 (c1 INT);
|
|
LOCK TABLE t2 WRITE;
|
|
TRUNCATE TABLE t1;
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
|
UNLOCK TABLES;
|
|
CREATE VIEW v1 AS SELECT t1.c1 FROM t1,t2 WHERE t1.c1 = t2.c1;
|
|
INSERT INTO t1 VALUES (1), (2), (3);
|
|
INSERT INTO t2 VALUES (1), (3), (4);
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
TRUNCATE v1;
|
|
ERROR 42S02: Table 'test.v1' doesn't exist
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
LOCK TABLE t1 WRITE;
|
|
SELECT * FROM v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
TRUNCATE v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
SELECT * FROM v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
UNLOCK TABLES;
|
|
LOCK TABLE t1 WRITE, t2 WRITE;
|
|
SELECT * FROM v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
TRUNCATE v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
SELECT * FROM v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
UNLOCK TABLES;
|
|
LOCK TABLE v1 WRITE;
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
TRUNCATE v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
UNLOCK TABLES;
|
|
LOCK TABLE t1 WRITE, t2 WRITE, v1 WRITE;
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
TRUNCATE v1;
|
|
ERROR HY000: Table 'v1' was not locked with LOCK TABLES
|
|
SELECT * FROM v1;
|
|
c1
|
|
1
|
|
3
|
|
UNLOCK TABLES;
|
|
DROP VIEW v1;
|
|
DROP TABLE t1, t2;
|
|
CREATE PROCEDURE p1() SET @a = 5;
|
|
TRUNCATE p1;
|
|
ERROR 42S02: Table 'test.p1' doesn't exist
|
|
SHOW CREATE PROCEDURE p1;
|
|
Procedure sql_mode Create Procedure character_set_client collation_connection Database Collation
|
|
p1 CREATE DEFINER=`root`@`localhost` PROCEDURE `p1`()
|
|
SET @a = 5 latin1 latin1_swedish_ci latin1_swedish_ci
|
|
DROP PROCEDURE p1;
|
|
#
|
|
# Bug#46452 Crash in MDL, HANDLER OPEN + TRUNCATE TABLE
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 AS SELECT 1 AS f1;
|
|
HANDLER t1 OPEN;
|
|
# Here comes the crash.
|
|
TRUNCATE t1;
|
|
# Currently TRUNCATE, just like other DDL, implicitly closes
|
|
# open HANDLER table.
|
|
HANDLER t1 READ FIRST;
|
|
ERROR 42S02: Unknown table 't1' in HANDLER
|
|
DROP TABLE t1;
|
|
# End of 6.0 tests
|