mirror of
https://github.com/MariaDB/server.git
synced 2025-01-23 23:34:34 +01:00
a14bbee5ab
2617.31.12, 2617.31.15, 2617.31.15, 2617.31.16, 2617.43.1 - initial changeset that introduced the fix for Bug#989 and follow up fixes for all test suite failures introduced in the initial changeset. ------------------------------------------------------------ revno: 2617.31.1 committer: Davi Arnaut <Davi.Arnaut@Sun.COM> branch nick: 4284-6.0 timestamp: Fri 2009-03-06 19:17:00 -0300 message: Bug#989: If DROP TABLE while there's an active transaction, wrong binlog order WL#4284: Transactional DDL locking Currently the MySQL server does not keep metadata locks on schema objects for the duration of a transaction, thus failing to guarantee the integrity of the schema objects being used during the transaction and to protect then from concurrent DDL operations. This also poses a problem for replication as a DDL operation might be replicated even thought there are active transactions using the object being modified. The solution is to defer the release of metadata locks until a active transaction is either committed or rolled back. This prevents other statements from modifying the table for the entire duration of the transaction. This provides commitment ordering for guaranteeing serializability across multiple transactions. - Incompatible change: If MySQL's metadata locking system encounters a lock conflict, the usual schema is to use the try and back-off technique to avoid deadlocks -- this schema consists in releasing all locks and trying to acquire them all in one go. But in a transactional context this algorithm can't be utilized as its not possible to release locks acquired during the course of the transaction without breaking the transaction commitments. To avoid deadlocks in this case, the ER_LOCK_DEADLOCK will be returned if a lock conflict is encountered during a transaction. Let's consider an example: A transaction has two statements that modify table t1, then table t2, and then commits. The first statement of the transaction will acquire a shared metadata lock on table t1, and it will be kept utill COMMIT to ensure serializability. At the moment when the second statement attempts to acquire a shared metadata lock on t2, a concurrent ALTER or DROP statement might have locked t2 exclusively. The prescription of the current locking protocol is that the acquirer of the shared lock backs off -- gives up all his current locks and retries. This implies that the entire multi-statement transaction has to be rolled back. - Incompatible change: FLUSH commands such as FLUSH PRIVILEGES and FLUSH TABLES WITH READ LOCK won't cause locked tables to be implicitly unlocked anymore. mysql-test/extra/binlog_tests/drop_table.test: Add test case for Bug#989. mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction. mysql-test/include/mix1.inc: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction. mysql-test/include/mix2.inc: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction. mysql-test/r/flush_block_commit.result: Update test case result (WL#4284). mysql-test/r/flush_block_commit_notembedded.result: Update test case result (WL#4284). mysql-test/r/innodb.result: Update test case result (WL#4284). mysql-test/r/innodb_mysql.result: Update test case result (WL#4284). mysql-test/r/lock.result: Add test case result for an effect of WL#4284/Bug#989 (all locks should be released when a connection terminates). mysql-test/r/mix2_myisam.result: Update test case result (effects of WL#4284/Bug#989). mysql-test/r/not_embedded_server.result: Update test case result (effects of WL#4284/Bug#989). Add a test case for interaction of WL#4284 and FLUSH PRIVILEGES. mysql-test/r/partition_innodb_semi_consistent.result: Update test case result (effects of WL#4284/Bug#989). mysql-test/r/partition_sync.result: Temporarily disable the test case for Bug#43867, which will be fixed by a subsequent backport. mysql-test/r/ps.result: Add a test case for effect of PREPARE on transactional locks: we take a savepoint at beginning of PREAPRE and release it at the end. Thus PREPARE does not accumulate metadata locks (Bug#989/WL#4284). mysql-test/r/read_only_innodb.result: Update test case result (effects of WL#4284/Bug#989). mysql-test/suite/binlog/r/binlog_row_drop_tbl.result: Add a test case result (WL#4284/Bug#989). mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result: Update test case result (effects of WL#4284/Bug#989). mysql-test/suite/binlog/r/binlog_stm_drop_tbl.result: Add a test case result (WL#4284/Bug#989). mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result: Update test case result (effects of WL#4284/Bug#989). mysql-test/suite/binlog/r/binlog_unsafe.result: A side effect of Bug#989 -- slightly different table map ids. mysql-test/suite/binlog/t/binlog_row_drop_tbl.test: Add a test case for WL#4284/Bug#989. mysql-test/suite/binlog/t/binlog_stm_drop_tbl.test: Add a test case for WL#4284/Bug#989. mysql-test/suite/binlog/t/binlog_stm_row.test: Update to the new state name. This is actually a follow up to another patch for WL#4284, that changes Locked thread state to Table lock. mysql-test/suite/ndb/r/ndb_index_ordered.result: Remove result for disabled part of the test case. mysql-test/suite/ndb/t/disabled.def: Temporarily disable a test case (Bug#45621). mysql-test/suite/ndb/t/ndb_index_ordered.test: Disable a part of a test case (needs update to reflect semantics of Bug#989). mysql-test/suite/rpl/t/disabled.def: Disable tests made meaningless by transactional metadata locking. mysql-test/suite/sys_vars/r/autocommit_func.result: Add a commit (Bug#989). mysql-test/suite/sys_vars/t/autocommit_func.test: Add a commit (Bug#989). mysql-test/t/flush_block_commit.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction. mysql-test/t/flush_block_commit_notembedded.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction. Add a test case for transaction-scope locks and the global read lock (Bug#989/WL#4284). mysql-test/t/innodb.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction (effects of Bug#989/WL#4284). mysql-test/t/lock.test: Add a test case for Bug#989/WL#4284. mysql-test/t/not_embedded_server.test: Add a test case for Bug#989/WL#4284. mysql-test/t/partition_innodb_semi_consistent.test: Replace TRUNCATE with DELETE, to not issue an implicit commit of a transaction, and not depend on metadata locks. mysql-test/t/partition_sync.test: Temporarily disable the test case for Bug#43867, which needs a fix to be backported from 6.0. mysql-test/t/ps.test: Add a test case for semantics of PREPARE and transaction-scope locks: metadata locks on tables used in PREPARE are enclosed into a temporary savepoint, taken at the beginning of PREPARE, and released at the end. Thus PREPARE does not effect what locks a transaction owns. mysql-test/t/read_only_innodb.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction (Bug#989/WL#4284). Wait for the read_only statement to actually flush tables before sending other concurrent statements that depend on its state. mysql-test/t/xa.test: Fix test case to reflect the fact that transactions now hold metadata locks for the duration of a transaction (Bug#989/WL#4284). sql/ha_ndbcluster_binlog.cc: Backport bits of changes of ha_ndbcluster_binlog.cc from 6.0, to fix the failing binlog test suite with WL#4284. WL#4284 implementation does not work with 5.1 implementation of ndbcluster binlog index. sql/log_event.cc: Release metadata locks after issuing a commit. sql/mdl.cc: Style changes (WL#4284). sql/mysql_priv.h: Rename parameter to match the name used in the definition (WL#4284). sql/rpl_injector.cc: Release metadata locks on commit (WL#4284). sql/rpl_rli.cc: Remove assert made meaningless, metadata locks are released at the end of the transaction. sql/set_var.cc: Close tables and release locks if autocommit mode is set. sql/slave.cc: Release metadata locks after a rollback. sql/sql_acl.cc: Don't implicitly unlock locked tables. Issue a implicit commit at the end and unlock tables. sql/sql_base.cc: Defer the release of metadata locks when closing tables if not required to. Issue a deadlock error if the locking protocol requires that a transaction re-acquire its locks. Release metadata locks when closing tables for reopen. sql/sql_class.cc: Release metadata locks if the thread is killed. sql/sql_parse.cc: Release metadata locks after implicitly committing a active transaction, or after explicit commits or rollbacks. sql/sql_plugin.cc: Allocate MDL request on the stack as the use of the table is contained within the function. It will be removed from the context once close_thread_tables is called at the end of the function. sql/sql_prepare.cc: The problem is that the prepare phase of the CREATE TABLE statement takes a exclusive metadata lock lock and this can cause a self-deadlock the thread already holds a shared lock on the table being that should be created. The solution is to make the prepare phase take a shared metadata lock when preparing a CREATE TABLE statement. The execution of the statement will still acquire a exclusive lock, but won't cause any problem as it issues a implicit commit. After some discussions with stakeholders it has been decided that metadata locks acquired during a PREPARE statement must be released once the statement is prepared even if it is prepared within a multi statement transaction. sql/sql_servers.cc: Don't implicitly unlock locked tables. Issue a implicit commit at the end and unlock tables. sql/sql_table.cc: Close table and release metadata locks after a admin operation. sql/table.h: The problem is that the prepare phase of the CREATE TABLE statement takes a exclusive metadata lock lock and this can cause a self-deadlock the thread already holds a shared lock on the table being that should be created. The solution is to make the prepare phase take a shared metadata lock when preparing a CREATE TABLE statement. The execution of the statement will still acquire a exclusive lock, but won't cause any problem as it issues a implicit commit. sql/transaction.cc: Release metadata locks after the implicitly committed due to a new transaction being started. Also, release metadata locks acquired after a savepoint if the transaction is rolled back to the save point. The problem is that in some cases transaction-long metadata locks could be released before the transaction was committed. This could happen when a active transaction was ended by a "START TRANSACTION" or "BEGIN" statement, in which case the metadata locks would be released before the actual commit of the active transaction. The solution is to defer the release of metadata locks to after the transaction has been implicitly committed. No test case is provided as the effort to provide one is too disproportional to the size of the fix. |
||
|---|---|---|
| .. | ||
| add_anonymous_users.inc | ||
| analyze-sync_with_master.test | ||
| analyze-timeout.test | ||
| big_test.inc | ||
| bug38347.inc | ||
| check-testcase.test | ||
| check-warnings.test | ||
| check_events_off.inc | ||
| check_ipv6.inc | ||
| check_var_limit.inc | ||
| circular_rpl_for_4_hosts_init.inc | ||
| circular_rpl_for_4_hosts_sync.inc | ||
| cleanup_fake_relay_log.inc | ||
| commit.inc | ||
| common-tests.inc | ||
| concurrent.inc | ||
| connect2.inc | ||
| count_sessions.inc | ||
| ctype_common.inc | ||
| ctype_filesort.inc | ||
| ctype_german.inc | ||
| ctype_innodb_like.inc | ||
| ctype_like_escape.inc | ||
| ctype_like_range_f1f2.inc | ||
| ctype_regex.inc | ||
| ddl_i18n.check_events.inc | ||
| ddl_i18n.check_sp.inc | ||
| ddl_i18n.check_triggers.inc | ||
| ddl_i18n.check_views.inc | ||
| deadlock.inc | ||
| default_client.cnf | ||
| default_my.cnf | ||
| default_mysqld.cnf | ||
| default_ndbd.cnf | ||
| delete_anonymous_users.inc | ||
| diff_master_slave.inc | ||
| diff_tables.inc | ||
| endspace.inc | ||
| get_binlog_dump_thread_id.inc | ||
| gis_generic.inc | ||
| gis_keys.inc | ||
| grant_cache.inc | ||
| handler.inc | ||
| have_32bit.inc | ||
| have_64bit.inc | ||
| have_archive.inc | ||
| have_big5.inc | ||
| have_binlog_format_mixed.inc | ||
| have_binlog_format_mixed_or_row.inc | ||
| have_binlog_format_mixed_or_statement.inc | ||
| have_binlog_format_row.inc | ||
| have_binlog_format_row_or_statement.inc | ||
| have_binlog_format_statement.inc | ||
| have_blackhole.inc | ||
| have_case_insensitive_file_system.inc | ||
| have_case_insensitive_fs.inc | ||
| have_case_sensitive_file_system.inc | ||
| have_compress.inc | ||
| have_cp866.inc | ||
| have_cp932.inc | ||
| have_cp1250_ch.inc | ||
| have_cp1251.inc | ||
| have_crypt.inc | ||
| have_csv.inc | ||
| have_debug.inc | ||
| have_debug_sync.inc | ||
| have_dynamic_loading.inc | ||
| have_eucjpms.inc | ||
| have_euckr.inc | ||
| have_example_plugin.inc | ||
| have_exampledb.inc | ||
| have_gb2312.inc | ||
| have_gbk.inc | ||
| have_geometry.inc | ||
| have_innodb.inc | ||
| have_koi8r.inc | ||
| have_latin2_ch.inc | ||
| have_local_infile.inc | ||
| have_log_bin.inc | ||
| have_lowercase0.inc | ||
| have_lowercase1.inc | ||
| have_lowercase2.inc | ||
| have_multi_ndb.inc | ||
| have_mysql_upgrade.inc | ||
| have_ndb.inc | ||
| have_ndb_extra.inc | ||
| have_ndbapi_examples.inc | ||
| have_nodebug.inc | ||
| have_not_innodb_plugin.inc | ||
| have_outfile.inc | ||
| have_partition.inc | ||
| have_profiling.inc | ||
| have_query_cache.inc | ||
| have_semisync_plugin.inc | ||
| have_simple_parser.inc | ||
| have_sjis.inc | ||
| have_ssl.inc | ||
| have_ssl_communication.inc | ||
| have_symlink.inc | ||
| have_tis620.inc | ||
| have_ucs2.inc | ||
| have_udf.inc | ||
| have_ujis.inc | ||
| have_utf8.inc | ||
| implicit_commit_helper.inc | ||
| index_merge1.inc | ||
| index_merge2.inc | ||
| index_merge_2sweeps.inc | ||
| index_merge_ror.inc | ||
| index_merge_ror_cpk.inc | ||
| innodb_rollback_on_timeout.inc | ||
| innodb_trx_weight.inc | ||
| ipv6.inc | ||
| ipv6_clients.inc | ||
| is_embedded.inc | ||
| kill_query.inc | ||
| kill_query_and_diff_master_slave.inc | ||
| linux_sys_vars.inc | ||
| load_sysvars.inc | ||
| loaddata_autocom.inc | ||
| master-slave-end.inc | ||
| master-slave-reset.inc | ||
| master-slave.inc | ||
| mix1.inc | ||
| mix2.inc | ||
| mix2_ucs2.inc | ||
| mtr_check.sql | ||
| mtr_warnings.sql | ||
| mysqlbinlog_row_engine.inc | ||
| mysqldump.inc | ||
| mysqltest-x.inc | ||
| ndb_backup.inc | ||
| ndb_backup_print.inc | ||
| ndb_default_cluster.inc | ||
| ndb_master-slave.inc | ||
| ndb_master-slave_2ch.inc | ||
| ndb_not_readonly.inc | ||
| ndb_restore_master.inc | ||
| ndb_restore_slave_eoption.inc | ||
| ndb_setup_slave.inc | ||
| ndb_wait_connected.inc | ||
| no_running_event_scheduler.inc | ||
| no_running_events.inc | ||
| no_valgrind_without_big.inc | ||
| not_as_root.inc | ||
| not_embedded.inc | ||
| not_ndb.inc | ||
| not_ndb_default.inc | ||
| not_openssl.inc | ||
| not_valgrind.inc | ||
| not_windows.inc | ||
| not_windows_embedded.inc | ||
| one_thread_per_connection.inc | ||
| parser_bug21114.inc | ||
| partition_date_range.inc | ||
| ps_conv.inc | ||
| ps_create.inc | ||
| ps_ddl_1.inc | ||
| ps_modify.inc | ||
| ps_modify1.inc | ||
| ps_query.inc | ||
| ps_renew.inc | ||
| query_cache.inc | ||
| query_cache_sql_prepare.inc | ||
| read_many_rows.inc | ||
| report-features.test | ||
| reset_master_and_slave.inc | ||
| restart_mysqld.inc | ||
| rowid_order.inc | ||
| rpl_events.inc | ||
| rpl_ip_mix.inc | ||
| rpl_ip_mix2.inc | ||
| rpl_ipv6.inc | ||
| rpl_loaddata_charset.inc | ||
| rpl_multi_engine.inc | ||
| rpl_multi_engine2.inc | ||
| rpl_multi_engine3.inc | ||
| rpl_stmt_seq.inc | ||
| rpl_udf.inc | ||
| running_event_scheduler.inc | ||
| safe_set_to_maybe_ro_var.inc | ||
| select_ndb_apply_status.inc | ||
| set_binlog_format_mixed.sql | ||
| set_binlog_format_row.sql | ||
| set_binlog_format_statement.sql | ||
| setup_fake_relay_log.inc | ||
| show_binary_logs.inc | ||
| show_binlog_events.inc | ||
| show_binlog_events2.inc | ||
| show_binlog_using_logname.inc | ||
| show_master_logs.inc | ||
| show_master_status.inc | ||
| show_msg.inc | ||
| show_msg80.inc | ||
| show_relaylog_events.inc | ||
| show_rpl_debug_info.inc | ||
| show_slave_status.inc | ||
| show_slave_status2.inc | ||
| sp-vars.inc | ||
| start_slave.inc | ||
| stop_slave.inc | ||
| strict_autoinc.inc | ||
| sync_slave_io_with_master.inc | ||
| system_db_struct.inc | ||
| test_fieldsize.inc | ||
| test_outfile.inc | ||
| testdb_only.inc | ||
| tpcb.inc | ||
| tpcb_disk_data.inc | ||
| unsafe_binlog.inc | ||
| uses_vardir.inc | ||
| varchar.inc | ||
| wait_condition.inc | ||
| wait_condition_sp.inc | ||
| wait_for_binlog_event.inc | ||
| wait_for_ndb_to_binlog.inc | ||
| wait_for_query_to_succeed.inc | ||
| wait_for_slave_io_error.inc | ||
| wait_for_slave_io_to_start.inc | ||
| wait_for_slave_io_to_stop.inc | ||
| wait_for_slave_param.inc | ||
| wait_for_slave_sql_error.inc | ||
| wait_for_slave_sql_error_and_skip.inc | ||
| wait_for_slave_sql_to_start.inc | ||
| wait_for_slave_sql_to_stop.inc | ||
| wait_for_slave_to_start.inc | ||
| wait_for_slave_to_stop.inc | ||
| wait_for_status_var.inc | ||
| wait_show_condition.inc | ||
| wait_until_connected_again.inc | ||
| wait_until_count_sessions.inc | ||
| wait_until_disconnected.inc | ||
| wait_until_rows_count.inc | ||
| windows.inc | ||
| windows_sys_vars.inc | ||