mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 03:52:35 +01:00
0ccdf54b64
I checked all stack overflow potential problems found with gcc -Wstack-usage=16384 and clang -Wframe-larger-than=16384 -no-inline Fixes: Added '#pragma clang diagnostic ignored "-Wframe-larger-than="' to a lot of function to where stack usage large but resonable. - Added stack check warnings to BUILD scrips when using clang and debug. Function changed to use malloc instead allocating things on stack: - read_bootstrap_query() now allocates line_buffer (20000 bytes) with malloc() instead of using stack. This has a small performance impact but this is not releant for bootstrap. - mroonga grn_select() used 65856 bytes on stack. Changed it to use malloc(). - Wsrep_schema::replay_transaction() and Wsrep_schema::recover_sr_transactions(). - Connect zipOpen3() Not fixed: - mroonga/vendor/groonga/lib/expr.c grn_proc_call() uses 43712 byte on stack. However this is not easy to fix as the stack used is caused by a lot of code generated by defines. - Most changes in mroonga/groonga where only adding of pragmas to disable stack warnings. - rocksdb/options/options_helper.cc uses 20288 of stack space. (no reason to fix except to get rid of the compiler warning) - Causes using alloca() where the allocation size is resonable. - An issue in libmariadb (reported to connectors).
88 lines
2.7 KiB
C
88 lines
2.7 KiB
C
/* Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
/*
|
|
Helper macros used for setting different __attributes__
|
|
on functions in a portable fashion
|
|
*/
|
|
|
|
#ifndef _my_attribute_h
|
|
#define _my_attribute_h
|
|
|
|
#if defined(__GNUC__)
|
|
# ifndef GCC_VERSION
|
|
# define GCC_VERSION (__GNUC__ * 1000 + __GNUC_MINOR__)
|
|
# endif
|
|
#endif
|
|
|
|
/*
|
|
Disable __attribute__() on gcc < 2.7, g++ < 3.4, and non-gcc compilers.
|
|
Some forms of __attribute__ are actually supported in earlier versions of
|
|
g++, but we just disable them all because we only use them to generate
|
|
compilation warnings.
|
|
*/
|
|
#ifndef __attribute__
|
|
# if !defined(__GNUC__) && !defined(__clang__)
|
|
# define __attribute__(A)
|
|
# elif defined(__GNUC__)
|
|
# ifndef GCC_VERSION
|
|
# define GCC_VERSION (__GNUC__ * 1000 + __GNUC_MINOR__)
|
|
# endif
|
|
# if GCC_VERSION < 2008
|
|
# define __attribute__(A)
|
|
# elif defined(__cplusplus) && GCC_VERSION < 3004
|
|
# define __attribute__(A)
|
|
# endif
|
|
# endif
|
|
#endif
|
|
|
|
/*
|
|
__attribute__((format(...))) is only supported in gcc >= 2.8 and g++ >= 3.4
|
|
But that's already covered by the __attribute__ tests above, so this is
|
|
just a convenience macro.
|
|
*/
|
|
#ifndef ATTRIBUTE_FORMAT
|
|
# define ATTRIBUTE_FORMAT(style, m, n) __attribute__((format(style, m, n)))
|
|
#endif
|
|
|
|
/*
|
|
|
|
__attribute__((format(...))) on a function pointer is not supported
|
|
until gcc 3.1
|
|
*/
|
|
#ifndef ATTRIBUTE_FORMAT_FPTR
|
|
# if (GCC_VERSION >= 3001)
|
|
# define ATTRIBUTE_FORMAT_FPTR(style, m, n) ATTRIBUTE_FORMAT(style, m, n)
|
|
# else
|
|
# define ATTRIBUTE_FORMAT_FPTR(style, m, n)
|
|
# endif /* GNUC >= 3.1 */
|
|
#endif
|
|
|
|
/* Define pragmas to disable warnings for stack frame checking */
|
|
|
|
#if defined(__clang__)
|
|
#define PRAGMA_DISABLE_CHECK_STACK_FRAME \
|
|
_Pragma("clang diagnostic push") \
|
|
_Pragma("clang diagnostic ignored \"-Wframe-larger-than=\"")
|
|
|
|
#define PRAGMA_REENABLE_CHECK_STACK_FRAME \
|
|
_Pragma("clang diagnostic pop")
|
|
|
|
#else
|
|
#define PRAGMA_DISABLE_CHECK_STACK_FRAME
|
|
#define PRAGMA_REENABLE_CHECK_STACK_FRAME
|
|
#endif
|
|
|
|
#endif /* _my_attribute_h */
|