mariadb/extra
Vladislav Vaintroub 0eae06c430 Bug#473914: mysql_client_test fail with in debug compilaton on windows x64
Reason: inconsistent compilation, federatedx is compiled without SAFEMALLOC
flag, while anything else is compiled with SAFEMALLOC.

As a consequence, my_hash_init used inside federatedx initialization does not
provide correct caller info parameters (file, line) , so they are initialized with 
whatever is on stack. When info about allocated memory is output in
COM_DEBUG command, the server crashes trying to output string starting at
0xcccccccccccccccc.

The fix is to remove SAFEMALLOC  preprocessor flags 
from every CMakeLists.txt, except the top-level one.

Also, SAFEMALLOC is not defined by default now, instead
there is WITH_DEBUG_FULL CMake option which adds 
-DSAFEMALLOC to C and C++ flags in debug compilation. 
This option is off by  default, because 
1) Debug C runtime already has heap debugging builtin with 
 overwrite and leak detection
2)safemalloc considerably slows down the tests.


Note also  that 
- SAFEMALLOC is gone  in MySQL5.5
- On Windows, heap related overflows can also be found using free pageheap utility
(that is also part of application verifier). This is even more efficient if there are no other layers 
on top of Windows heap allocator, e.g  it is most efficient with release version.
2010-12-06 12:52:06 +01:00
..
libevent Fixed compiler warnings and a compilation failure on windows 2010-11-27 00:37:34 +02:00
yassl Fixed compiler and gmake warnings 2010-11-29 11:27:52 +02:00
.cvsignore Import changeset 2000-07-31 21:29:14 +02:00
charset2html.c fixes for warnings and compile errors for the fix of bug 26243 2008-03-29 16:12:23 +02:00
CMakeLists.txt Bug#473914: mysql_client_test fail with in debug compilaton on windows x64 2010-12-06 12:52:06 +01:00
comp_err.c Merge with MySQL 5.1.50 2010-08-27 17:12:44 +03:00
innochecksum.c Fix incorrect filename in verbose output of innochecksum. (Bug #44484, 2009-05-05 11:07:26 -07:00
Makefile.am MWL#74: Shared libmysqld.so library. 2010-11-17 13:24:20 +01:00
my_print_defaults.c Fixed compiler warnings from Windows compiler 2010-08-11 13:55:54 +03:00
mysql_waitpid.c Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00
perror.c Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00
replace.c Added option BACKUP_ALL to mysqld --myisam-recover to also get a backup of the index file before it's repaired. 2010-11-07 14:25:29 +02:00
resolve_stack_dump.c Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00
resolveip.c Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00