mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
a23414dd32
When the log is stored in persistent memory, log_sys.buf[] is
a ring buffer that directly maps to the circular ib_logfile0 file.
There were several errors that could occur in the special case
when a log record ends exactly at the end of the log file and the
next record would start at log_sys.buf[log_sys.START_OFFSET].
mariabackup.huge_lsn,strict_full_crc32: Write the first record
at the very end of the circular file, to reproduce the failure
scenarios.
recv_sys_t::parse(): On PMEM, wrap the end offset of the record
from log_sys.file_size to log_sys.START_OFFSET if needed.
Otherwise, both InnoDB recovery and mariadb-backup would try
to parse the next record from an invalid address.
filename_to_spacename(): Remove an assumption about the format
of file names. While the server currently writes file names like
./databasename/tablename.ibd we might want to stop writing the
redundant ./ prefix in the future. The test mariabackup.huge_lsn
is generating such file names.
xtrabackup_copy_logfile(): Correctly copy a record that ends at
the very end of the log_sys.buf[].
The errors in mariadb-backup were reproduced with the test
mariabackup.huge_lsn,strict_full_crc32 and an additional patch
to use the start checkpoint of the test:
diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc
index 27dce5fa17d..e17a1692d6f 100644
--- a/storage/innobase/log/log0recv.cc
+++ b/storage/innobase/log/log0recv.cc
@@ -1796,7 +1796,8 @@ dberr_t recv_sys_t::find_checkpoint()
continue;
}
- if (checkpoint_lsn >= log_sys.next_checkpoint_lsn)
+ if (checkpoint_lsn >= log_sys.next_checkpoint_lsn &&
+ checkpoint_lsn != 0x1000fffffe10)
{
log_sys.next_checkpoint_lsn= checkpoint_lsn;
log_sys.next_checkpoint_no= field == log_t::CHECKPOINT_1;
98 lines
3.4 KiB
Text
98 lines
3.4 KiB
Text
--source include/not_embedded.inc
|
|
--source include/have_file_key_management.inc
|
|
|
|
--echo #
|
|
--echo # MDEV-13416 mariabackup fails with EFAULT "Bad Address"
|
|
--echo #
|
|
|
|
let INNODB_PAGE_SIZE=`select @@innodb_page_size`;
|
|
let MYSQLD_DATADIR=`select @@datadir`;
|
|
|
|
let $targetdir_old=$MYSQLTEST_VARDIR/tmp/backup_1;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir_old;
|
|
--enable_result_log
|
|
--source include/shutdown_mysqld.inc
|
|
|
|
if ($MTR_COMBINATION_STRICT_CRC32) {
|
|
perl;
|
|
my $file= "$ENV{MYSQLD_DATADIR}/ibdata1";
|
|
open(FILE, "+<", $file) or die "Unable to open $file\n";
|
|
binmode FILE;
|
|
my $ps= $ENV{INNODB_PAGE_SIZE};
|
|
my $page;
|
|
die "Unable to read $file" unless sysread(FILE, $page, $ps) == $ps;
|
|
substr($page,26,8) = pack("NN", 4096, ~1024);
|
|
sysseek(FILE, 0, 0) || die "Unable to rewind $file\n";
|
|
syswrite(FILE, $page, $ps)==$ps || die "Unable to write $file\n";
|
|
close(FILE) || die "Unable to close $file\n";
|
|
|
|
$file= "$ENV{MYSQLD_DATADIR}/ib_logfile0";
|
|
open(FILE, ">", $file) || die "Unable to truncate $file\n";
|
|
close(FILE) || "Unable to close $file\n";
|
|
EOF
|
|
--let SEARCH_PATTERN= redo log: [0-9.]*[KMGT]iB; LSN=17596481010687\\b
|
|
}
|
|
|
|
if (!$MTR_COMBINATION_STRICT_CRC32) {
|
|
perl;
|
|
do "$ENV{MTR_SUITE_DIR}/../innodb/include/crc32.pl";
|
|
my $file= "$ENV{MYSQLD_DATADIR}/ib_logfile0";
|
|
open(FILE, ">", $file) or die "Unable to open $file\n";
|
|
binmode FILE;
|
|
my $extra_repeat = 139820;
|
|
# The desired log sequence number is 17596481011216 (0x1000fffffe10).
|
|
my $file_size=4<<20;
|
|
my $lsn_hi=4096,$lsn_lo=0xfffffe00 - $extra_repeat * 15;
|
|
my $polynomial = 0x82f63b78; # CRC-32C
|
|
my ($header, $checkpoint, $log);
|
|
$header = "Phys" . pack("x[4]NN", $lsn_hi, $lsn_lo - $file_size + 0x300f) .
|
|
"some Perl code" . pack("x[478]");
|
|
$header .= pack("Nx[3584]", mycrc32($header, 0, $polynomial));
|
|
$checkpoint = pack("NNNNx[44]", $lsn_hi, $lsn_lo, $lsn_hi, $lsn_lo);
|
|
$checkpoint .= pack("Nx[8128]", mycrc32($checkpoint, 0, $polynomial));
|
|
$log = pack("CxxNN", 0xfa, $lsn_hi, $lsn_lo);
|
|
$log .= pack("CN", 0, mycrc32($log, 0, $polynomial));
|
|
|
|
# Write more than 2MiB of FILE_MODIFY mini-transactions to exercise the parser.
|
|
my $extra = pack("CCxa*", 0xb9, 127, "a/b.ibd");
|
|
$extra .= pack("CN", 0, mycrc32($extra, 0, $polynomial));
|
|
|
|
print FILE $header, $checkpoint, $extra x ($extra_repeat - 1), $log;
|
|
seek(FILE, $file_size - 15, 0);
|
|
$extra = pack("CCxa*", 0xb9, 127, "c/d.ibd");
|
|
$extra .= pack("CN", 1, mycrc32($extra, 0, $polynomial));
|
|
print FILE $extra;
|
|
close(FILE) or die "Unable to close $file\n";
|
|
EOF
|
|
--let SEARCH_PATTERN= InnoDB: log sequence number 17596481011216
|
|
--let $restart_parameters=--innodb-log-file-size=4M --innodb-encrypt-log=0
|
|
}
|
|
|
|
--source include/start_mysqld.inc
|
|
let SEARCH_FILE= $MYSQLTEST_VARDIR/log/mysqld.1.err;
|
|
--source include/search_pattern_in_file.inc
|
|
|
|
CREATE TABLE t(i INT) ENGINE INNODB;
|
|
INSERT INTO t VALUES(1);
|
|
|
|
echo # xtrabackup backup;
|
|
let $targetdir=$MYSQLTEST_VARDIR/tmp/backup;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir;
|
|
--enable_result_log
|
|
SET GLOBAL innodb_flush_log_at_trx_commit=1;
|
|
INSERT INTO t VALUES(2);
|
|
echo # xtrabackup prepare;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --prepare --target-dir=$targetdir;
|
|
--let $restart_parameters=
|
|
--source include/restart_and_restore.inc
|
|
--enable_result_log
|
|
SELECT * FROM t;
|
|
DROP TABLE t;
|
|
rmdir $targetdir;
|
|
let $targetdir= $targetdir_old;
|
|
exec $XTRABACKUP --prepare --target-dir=$targetdir;
|
|
--source include/restart_and_restore.inc
|
|
rmdir $targetdir_old;
|