mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
b07f9f72dc
The issue was that create...trigger part of the test suite used a debug_sync point that before was never triggered (in other words, wrong meaningless test). With the new create ... replace code the debug sync point is triggered and the test case could not handled that. I fixed this by adding a wait and go for the debug syncpoint in the test. Removed some compiler warnings from mysql_cond_timedwait include/mysql/psi/mysql_thread.h: Removed compiler warnings mysql-test/r/create-big.result: New test result mysql-test/t/create-big.test: Fixed test case as create_table_select_before_check_if_exists was not before triggered by the code.
240 lines
8.1 KiB
Text
240 lines
8.1 KiB
Text
drop table if exists t1,t2,t3,t4,t5;
|
|
set debug_sync='RESET';
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 (j char(5));;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 select 'Test' as j;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
create table t3 (j char(5));
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 like t3;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t3 to t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
alter table t3 rename to t1;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
alter table t3 rename to t1, add k int;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1,t3;
|
|
set debug_sync='create_table_select_before_open SIGNAL parked WAIT_FOR go';
|
|
set debug_sync='create_table_select_before_open SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t1 to t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
select * from t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
i
|
|
1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (2);;
|
|
set debug_sync='now SIGNAL go';
|
|
select * from t1;
|
|
i
|
|
1
|
|
2
|
|
drop table t1;
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;;
|
|
set debug_sync='now SIGNAL go';
|
|
select @a;
|
|
@a
|
|
0
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t1 to t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
select * from t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
i
|
|
1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (2);;
|
|
set debug_sync='now SIGNAL go';
|
|
select * from t1;
|
|
i
|
|
1
|
|
2
|
|
drop table t1;
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;;
|
|
set debug_sync='now SIGNAL go';
|
|
select @a;
|
|
@a
|
|
0
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_check_if_exists SIGNAL parked WAIT_FOR go';
|
|
create table if not exists t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
create table t1 (i int);
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_check_if_exists SIGNAL parked WAIT_FOR go';
|
|
create table if not exists t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;;
|
|
set debug_sync='now SIGNAL go';
|
|
Warnings:
|
|
Note 1050 Table 't1' already exists
|
|
select @a;
|
|
@a
|
|
0
|
|
select * from t1;
|
|
i
|
|
drop table t1;
|
|
drop table if exists t1,t2;
|
|
set debug_sync='RESET';
|
|
create table t1 (i int);
|
|
set debug_sync='create_table_like_after_open SIGNAL parked WAIT_FOR go';
|
|
reset master;
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (1);
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
show create table t2;
|
|
Table Create Table
|
|
t2 CREATE TABLE `t2` (
|
|
`i` int(11) DEFAULT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t2;
|
|
include/show_binlog_events.inc
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Gtid # # BEGIN GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; insert into t1 values (1)
|
|
master-bin.000001 # Query # # COMMIT
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t1` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
create table t1 (i int);
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
reset master;
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t2 values (1);;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='RESET';
|
|
include/show_binlog_events.inc
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Gtid # # BEGIN GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; insert into t2 values (1)
|
|
master-bin.000001 # Query # # COMMIT
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t1` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|