mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 18:41:56 +01:00
985ede9203
The problem: When incremental backup is taken, delta files are created for innodb tables which are marked as new tables during innodb ddl tracking. When such tablespace is tried to be opened during prepare in xb_delta_open_matching_space(), it is "created", i.e. xb_space_create_file() is invoked, instead of opening, even if a tablespace with the same name exists in the base backup directory. xb_space_create_file() writes page 0 header the tablespace. This header does not contain crypt data, as mariabackup does not have any information about crypt data in delta file metadata for tablespaces. After delta file is applied, recovery process is started. As the sequence of recovery for different pages is not defined, there can be the situation when crypt data redo log event is executed after some other page is read for recovery. When some page is read for recovery, it's decrypted using crypt data stored in tablespace header in page 0, if there is no crypt data, the page is not decryped and does not pass corruption test. This causes error for incremental backup --prepare for encrypted tablespaces. The error is not stable because crypt data redo log event updates crypt data on page 0, and recovery for different pages can be executed in undefined order. The fix: When delta file is created, the corresponding write filter copies only the pages which LSN is greater then some incremental LSN. When new file is created during incremental backup, the LSN of all it's pages must be greater then incremental LSN, so there is no need to create delta for such table, we can just copy it completely. The fix is to copy the whole file which was tracked during incremental backup with innodb ddl tracker, and copy it to base directory during --prepare instead of delta applying. There is also DBUG_EXECUTE_IF() in innodb code to avoid writing redo log record for crypt data updating on page 0 to make the test case stable. Note: The issue is not reproducible in 10.5 as optimized DDL's are deprecated in 10.5. But the fix is still useful because it allows to decrease data copy size during backup, as delta file contains some extra info. The test case should be removed for 10.5 as it will always pass. |
||
|---|---|---|
| .. | ||
| crc | ||
| quicklz | ||
| backup_copy.cc | ||
| backup_copy.h | ||
| backup_mysql.cc | ||
| backup_mysql.h | ||
| backup_wsrep.h | ||
| changed_page_bitmap.cc | ||
| changed_page_bitmap.h | ||
| CMakeLists.txt | ||
| common.h | ||
| datasink.cc | ||
| datasink.h | ||
| ds_archive.cc | ||
| ds_archive.h | ||
| ds_buffer.cc | ||
| ds_buffer.h | ||
| ds_compress.cc | ||
| ds_compress.h | ||
| ds_local.cc | ||
| ds_local.h | ||
| ds_stdout.cc | ||
| ds_stdout.h | ||
| ds_tmpfile.cc | ||
| ds_tmpfile.h | ||
| ds_xbstream.cc | ||
| ds_xbstream.h | ||
| encryption_plugin.cc | ||
| encryption_plugin.h | ||
| fil_cur.cc | ||
| fil_cur.h | ||
| innobackupex.cc | ||
| innobackupex.h | ||
| read_filt.cc | ||
| read_filt.h | ||
| write_filt.cc | ||
| write_filt.h | ||
| wsrep.cc | ||
| xb0xb.h | ||
| xb_regex.h | ||
| xbcloud.cc | ||
| xbstream.cc | ||
| xbstream.h | ||
| xbstream_read.cc | ||
| xbstream_write.cc | ||
| xtrabackup.cc | ||
| xtrabackup.h | ||