mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
117 lines
2.7 KiB
C++
117 lines
2.7 KiB
C++
/* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
#ifndef SQL_TABLE_MAINTENANCE_H
|
|
#define SQL_TABLE_MAINTENANCE_H
|
|
|
|
/* Must be able to hold ALTER TABLE t PARTITION BY ... KEY ALGORITHM = 1 ... */
|
|
#define SQL_ADMIN_MSG_TEXT_SIZE (128 * 1024)
|
|
|
|
bool mysql_assign_to_keycache(THD* thd, TABLE_LIST* table_list,
|
|
const LEX_CSTRING *key_cache_name);
|
|
bool mysql_preload_keys(THD* thd, TABLE_LIST* table_list);
|
|
int reassign_keycache_tables(THD* thd, KEY_CACHE *src_cache,
|
|
KEY_CACHE *dst_cache);
|
|
|
|
/**
|
|
Sql_cmd_analyze_table represents the ANALYZE TABLE statement.
|
|
*/
|
|
class Sql_cmd_analyze_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a ANALYZE TABLE statement.
|
|
*/
|
|
Sql_cmd_analyze_table() = default;
|
|
|
|
~Sql_cmd_analyze_table() = default;
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_ANALYZE;
|
|
}
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
Sql_cmd_check_table represents the CHECK TABLE statement.
|
|
*/
|
|
class Sql_cmd_check_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a CHECK TABLE statement.
|
|
*/
|
|
Sql_cmd_check_table() = default;
|
|
|
|
~Sql_cmd_check_table() = default;
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_CHECK;
|
|
}
|
|
};
|
|
|
|
|
|
/**
|
|
Sql_cmd_optimize_table represents the OPTIMIZE TABLE statement.
|
|
*/
|
|
class Sql_cmd_optimize_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a OPTIMIZE TABLE statement.
|
|
*/
|
|
Sql_cmd_optimize_table() = default;
|
|
|
|
~Sql_cmd_optimize_table() = default;
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_OPTIMIZE;
|
|
}
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
Sql_cmd_repair_table represents the REPAIR TABLE statement.
|
|
*/
|
|
class Sql_cmd_repair_table : public Sql_cmd
|
|
{
|
|
public:
|
|
/**
|
|
Constructor, used to represent a REPAIR TABLE statement.
|
|
*/
|
|
Sql_cmd_repair_table() = default;
|
|
|
|
~Sql_cmd_repair_table() = default;
|
|
|
|
bool execute(THD *thd);
|
|
|
|
virtual enum_sql_command sql_command_code() const
|
|
{
|
|
return SQLCOM_REPAIR;
|
|
}
|
|
};
|
|
|
|
#endif
|