mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
bd53f960dd
with errno 17 my_create() did not perform any checks for the case when a file is successfully created by a call to open(), but the call to my_register_filename() later fails because the number of open files has exceeded the my_open_files limit. This can happen on platforms which do not have getrlimit(), and hence we do not know the real limit for open files. In such a case an error was returned to a caller although the file has actually been created. Since callers assume my_create() to return an error only when it failed to create a file, they did not perform any cleanups, leaving an 'orphaned' file on the file system. Fixed by adding a check for the above case to my_create() and ensuring the newly created file is deleted before returning an error. Creating a deterministic test case in the test suite is impossible, because the exact steps required to reproduce the above situation depend on the platform and/or environment (OS per-user limits, queries executed by previous tests, startup parameters). The patch was manually tested on Windows using examples posted in the bug report.
79 lines
2.6 KiB
C
79 lines
2.6 KiB
C
/* Copyright (C) 2000 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#define USES_TYPES
|
|
#include "mysys_priv.h"
|
|
#include <my_dir.h>
|
|
#include "mysys_err.h"
|
|
#include <errno.h>
|
|
#if defined(MSDOS) || defined(__WIN__) || defined(__EMX__) || defined(OS2)
|
|
#include <share.h>
|
|
#endif
|
|
|
|
/*
|
|
** Create a new file
|
|
** Arguments:
|
|
** Path-name of file
|
|
** Read | write on file (umask value)
|
|
** Read & Write on open file
|
|
** Special flags
|
|
*/
|
|
|
|
|
|
File my_create(const char *FileName, int CreateFlags, int access_flags,
|
|
myf MyFlags)
|
|
{
|
|
int fd, rc;
|
|
DBUG_ENTER("my_create");
|
|
DBUG_PRINT("my",("Name: '%s' CreateFlags: %d AccessFlags: %d MyFlags: %d",
|
|
FileName, CreateFlags, access_flags, MyFlags));
|
|
|
|
#if !defined(NO_OPEN_3) && !defined(__EMX__)
|
|
fd = open((my_string) FileName, access_flags | O_CREAT,
|
|
CreateFlags ? CreateFlags : my_umask);
|
|
#elif defined(VMS)
|
|
fd = open((my_string) FileName, access_flags | O_CREAT, 0,
|
|
"ctx=stm","ctx=bin");
|
|
#elif defined(MSDOS) || defined(__EMX__) || defined(OS2)
|
|
if (access_flags & O_SHARE)
|
|
fd = sopen((my_string) FileName, access_flags | O_CREAT | O_BINARY,
|
|
SH_DENYNO, MY_S_IREAD | MY_S_IWRITE);
|
|
else
|
|
fd = open((my_string) FileName, access_flags | O_CREAT | O_BINARY,
|
|
MY_S_IREAD | MY_S_IWRITE);
|
|
#elif defined(__WIN__)
|
|
fd= my_sopen((my_string) FileName, access_flags | O_CREAT | O_BINARY,
|
|
SH_DENYNO, MY_S_IREAD | MY_S_IWRITE);
|
|
#else
|
|
fd = open(FileName, access_flags);
|
|
#endif
|
|
|
|
rc= my_register_filename(fd, FileName, FILE_BY_CREATE,
|
|
EE_CANTCREATEFILE, MyFlags);
|
|
/*
|
|
my_register_filename() may fail on some platforms even if the call to
|
|
*open() above succeeds. In this case, don't leave the stale file because
|
|
callers assume the file to not exist if my_create() fails, so they don't
|
|
do any cleanups.
|
|
*/
|
|
if (unlikely(fd >= 0 && rc < 0))
|
|
{
|
|
int tmp= my_errno;
|
|
my_delete(FileName, MyFlags);
|
|
my_errno= tmp;
|
|
}
|
|
|
|
DBUG_RETURN(rc);
|
|
} /* my_create */
|