mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
99adbd131a
Post-review fixes. Mostly whitespace, int-to-bool return value, fixed comments
sql/Makefile.am:
compile all submodules of Events before compiling the facade
sql/event_data_objects.cc:
- Use initialization list
- Clean whitespaces
- Shorten comments
- Fix comments
sql/event_data_objects.h:
- Fix whitespace
sql/event_db_repository.cc:
- Change return type from int to bool where only one error code is
returned.
- Don't use macros but get the maximal number of characters in a column
from the column
- Fix comments
- Make functions which has return value but it's not used - void.
sql/event_db_repository.h:
- Methods with only one error code int -> bool return value
- Remove declaration of fill_schema_events, a function that does not exist
sql/event_queue.cc:
- Use initialization lists
- Let find_n_remove_event delete the object thus making the code more robust.
The caller could forget to destruct the object. In addition, find_n_remove_element()
does not return a value.
- Move check_system_tables() to class Events
- Fix comments
sql/event_queue.h:
- Whitespace changes
- init_queue() should allow passing of THD
- check_system_tables moved to class Events
- find_n_remove_event() is now void
sql/event_scheduler.cc:
- Initialize res before use
- Remove end stop from message
sql/event_scheduler.h:
Add uninitialized state. The scheduler is in it before init_scheduler()
is called. The rationale is that otherwise state has no value before
the call. If the system tables were damaged the scheduler won't be initialized
but in Events::deinit() Event_scheduler::stop() will be called and this will
touch state, generating valgrind warning at minimum.
sql/events.cc:
- Whitespace changes
- Fix comments
- Make methods which have only one error code be bool instead of int
- Create temporarily a THD to be used for the initialization of Event_queue
- Event_queue::check_system_tables() moved to Events::check_system_tables
- is_started() is renamed to is_execution_of_events_started()
sql/events.h:
- Whitespace changes
- When a method returns only one error code it should be bool, not int
- is_started() renamed to is_execution_of_events_started()
sql/set_var.cc:
is_started() is renamed to is_execution_of_events_started()
sql/sql_db.cc:
The return code is not used, thus don't return anything and drop_schema_events()
is now void.
sql/sql_yacc.yy:
- Fix comments
- Remove unneeded initialization which is performed in lex_init()
sql/share/errmsg.txt:
New error message
sql/table.cc:
- Fix comments
- make table_check_intact() accespt const *table_def
sql/table.h:
Make table_check_intact() accespt const *table_def
104 lines
2.8 KiB
C++
104 lines
2.8 KiB
C++
#ifndef _EVENT_DB_REPOSITORY_H_
|
|
#define _EVENT_DB_REPOSITORY_H_
|
|
/* Copyright (C) 2004-2006 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#define EVEX_OPEN_TABLE_FAILED -1
|
|
|
|
enum enum_events_table_field
|
|
{
|
|
ET_FIELD_DB = 0,
|
|
ET_FIELD_NAME,
|
|
ET_FIELD_BODY,
|
|
ET_FIELD_DEFINER,
|
|
ET_FIELD_EXECUTE_AT,
|
|
ET_FIELD_INTERVAL_EXPR,
|
|
ET_FIELD_TRANSIENT_INTERVAL,
|
|
ET_FIELD_CREATED,
|
|
ET_FIELD_MODIFIED,
|
|
ET_FIELD_LAST_EXECUTED,
|
|
ET_FIELD_STARTS,
|
|
ET_FIELD_ENDS,
|
|
ET_FIELD_STATUS,
|
|
ET_FIELD_ON_COMPLETION,
|
|
ET_FIELD_SQL_MODE,
|
|
ET_FIELD_COMMENT,
|
|
ET_FIELD_COUNT /* a cool trick to count the number of fields :) */
|
|
};
|
|
|
|
|
|
int
|
|
events_table_index_read_for_db(THD *thd, TABLE *schema_table,
|
|
TABLE *event_table);
|
|
|
|
int
|
|
events_table_scan_all(THD *thd, TABLE *schema_table, TABLE *event_table);
|
|
|
|
class Event_basic;
|
|
class Event_parse_data;
|
|
|
|
class Event_db_repository
|
|
{
|
|
public:
|
|
Event_db_repository(){}
|
|
|
|
bool
|
|
create_event(THD *thd, Event_parse_data *parse_data, my_bool create_if_not,
|
|
uint *rows_affected);
|
|
|
|
bool
|
|
update_event(THD *thd, Event_parse_data *parse_data, LEX_STRING *new_dbname,
|
|
LEX_STRING *new_name);
|
|
|
|
bool
|
|
drop_event(THD *thd, LEX_STRING db, LEX_STRING name, bool drop_if_exists,
|
|
uint *rows_affected);
|
|
|
|
void
|
|
drop_schema_events(THD *thd, LEX_STRING schema);
|
|
|
|
bool
|
|
find_named_event(THD *thd, LEX_STRING db, LEX_STRING name, TABLE *table);
|
|
|
|
bool
|
|
load_named_event(THD *thd, LEX_STRING dbname, LEX_STRING name, Event_basic *et);
|
|
|
|
int
|
|
open_event_table(THD *thd, enum thr_lock_type lock_type, TABLE **table);
|
|
|
|
int
|
|
fill_schema_events(THD *thd, TABLE_LIST *tables, char *db);
|
|
|
|
private:
|
|
void
|
|
drop_events_by_field(THD *thd, enum enum_events_table_field field,
|
|
LEX_STRING field_value);
|
|
bool
|
|
index_read_for_db_for_i_s(THD *thd, TABLE *schema_table, TABLE *event_table,
|
|
char *db);
|
|
|
|
bool
|
|
table_scan_all_for_i_s(THD *thd, TABLE *schema_table, TABLE *event_table);
|
|
|
|
static bool
|
|
check_system_tables(THD *thd);
|
|
|
|
/* Prevent use of these */
|
|
Event_db_repository(const Event_db_repository &);
|
|
void operator=(Event_db_repository &);
|
|
};
|
|
|
|
#endif /* _EVENT_DB_REPOSITORY_H_ */
|