mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-17 20:42:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
mariadb/sql
History
Ole John Aske 221ce9223d Fix for bug#59308: Incorrect result for SELECT DISTINCT <col>... ORDER BY <col> DESC. 
Also fix bug#59110: Memory leak of QUICK_SELECT_I allocated memory.
Includes Jørgen Lølands review comments.
      
Root cause of these bugs are that test_if_skip_sort_order() decided to
revert the 'skip_sort_order' descision (and use filesort) after the
query plan has been updated to reflect a 'skip' of the sort order.
      
This might happen in 'check_reverse_order:' if we have a 
select->quick which could not be made descending by appending 
a QUICK_SELECT_DESC. ().
      
The original 'save_quick' was then restored after the QEP has been modified,
which caused:
      
  - An incorrect 'precomputed_group_by= TRUE' may have been set, 
    and not reverted, as part of the already modifified QEP (Bug#59308)
  - A 'select->quick' might have been created which we fail to delete (bug#59110).
      
This fix is a refactorication of test_if_skip_sort_order() where all logic
related to modification of QEP (controlled by argument 'bool no_changes'), is
moved to the end of test_if_skip_sort_order(), and done after *all* 'test_if_skip'
checks has been performed - including the 'check_reverse_order:' checks.
      
The refactorication above contains now intentional changes to the logic which 
has been moved to the end of the function.
      
Furthermore, a smaller part of the fix address the handling of the 
select->quick objects which may already exists when we call 
'test_if_skip_sort_order()' (save_quick) -and
new select->quick's created during test_if_skip_sort_order():
      
  - Before new select->quick may be created by calling ::test_quick_select(), we
    set 'select->quick= 0' to avoid that ::test_quick_select() prematurely
    delete the save_quick's. (After this call we may have both a 'save_quick' 
    and 'select->quick')
      
  - All returns from ::test_if_skip_sort_order() where we may have both a
    'save_quick' and a 'select->quick' has been changed to goto's to the
    exit points 'skiped_sort_order:' or 'need_filesort:' where we
    decide which of the QUICK_SELECT's to keep, and delete the other.
2011-02-07 10:36:21 +01:00
..
examples Bug #43414 Parenthesis (and other) warnings compiling MySQL 2009-06-17 15:54:01 +02:00
share Merge 2010-12-29 00:47:05 +01:00
.cvsignore
add_errmsg
authors.h Bug#50561: ALTER PARTITIONS does not have adequate lock, breaks with 2010-03-17 15:10:41 +01:00
client_settings.h Bug#46013: rpl_extraColmaster_myisam fails on pb2 2009-08-13 17:07:20 -03:00
CMakeLists.txt Bug #48042 The description for Event ID ( 100 ) in Source ( MySQL ) cannot be found. 2010-04-26 23:59:50 +02:00
contributors.h
custom_conf.h
debug_sync.cc Bug#58057: 5.1 libmysql/libmysql.c unused variable/compile failure 2010-11-10 19:14:47 -02:00
debug_sync.h Bug #51648 DBUG_SYNC_POINT is not defined on all platforms and mtr cant pre-check that 2010-03-19 11:06:40 +02:00
derror.cc
des_key_file.cc
discover.cc
event_data_objects.cc Manual merge from the bugfix tree. 2010-06-11 16:52:06 +04:00
event_data_objects.h Bug#35997 Event scheduler seems to let the server crash, if it is embedded. 2008-05-09 09:43:02 +02:00
event_db_repository.cc Bug #49132 Replication failure on temporary table + DDL 2010-01-22 17:38:21 +08:00
event_db_repository.h
event_parse_data.cc Bug#29125 Windows Server X64: so many compiler warnings 2009-02-13 11:41:47 -05:00
event_parse_data.h Added "Sun Microsystems, Inc." to copyright headers on files modified 2008-11-10 21:21:49 +01:00
event_queue.cc Bug#35997 Event scheduler seems to let the server crash, if it is embedded. 2008-05-09 09:43:02 +02:00
event_queue.h
event_scheduler.cc fixed various pb2 test failures on windows. 2010-02-02 14:17:21 +02:00
event_scheduler.h
events.cc Bug #50095 Multi statement including CREATE EVENT causes rotten binlog entry 2010-03-28 16:37:47 +08:00
events.h
field.cc Fix for bug #58650 "Failing assertion: primary_key_no == -1 || 2011-02-02 16:17:48 +03:00
field.h Merging with mysql-5.1-bugteam 2010-03-17 19:15:41 +01:00
field_conv.cc Fix for Bug#56138 "valgrind errors about overlapping memory when double-assigning same variable", 2010-11-22 09:57:59 +01:00
filesort.cc Bug #54734 assert in Diagnostics_area::set_ok_status 2010-07-19 11:03:52 +02:00
frm_crypt.cc
gen_lex_hash.cc Merge 2010-12-29 00:47:05 +01:00
gstream.cc Bug #43414 Parenthesis (and other) warnings compiling MySQL 2009-06-09 18:11:21 +02:00
gstream.h
ha_ndbcluster.cc Bug#45288: pb2 returns a lot of compilation warnings 2010-10-19 20:36:59 -02:00
ha_ndbcluster.h
ha_ndbcluster_binlog.cc Bug #40877: multi statement execution fails in 5.1.30 2009-10-16 13:29:42 +03:00
ha_ndbcluster_binlog.h
ha_ndbcluster_cond.cc
ha_ndbcluster_cond.h
ha_ndbcluster_tables.h
ha_partition.cc merge 2010-11-26 14:51:48 +02:00
ha_partition.h merge 2010-10-01 13:39:49 +02:00
handler.cc Fix for bug#58553, "Queries with pushed conditions causes 'explain extended' 2011-01-11 12:09:54 +01:00
handler.h merge 2010-07-09 15:00:33 +02:00
hash_filo.cc
hash_filo.h
hostname.cc
init.cc
item.cc Bug#58030 crash in Item_func_geometry_from_text::val_str 2010-12-21 14:34:11 +03:00
item.h Update of copyright headers for files I changed this year. 2011-01-27 23:47:24 +01:00
item_buff.cc Bug #55188: GROUP BY, GROUP_CONCAT and TEXT - inconsistent results 2010-07-30 16:35:06 +03:00
item_cmpfunc.cc Bug#59173: Failure to handle DATE(TIME) values where Year, Month or Day is 2011-01-19 15:09:32 +01:00
item_cmpfunc.h Merge 2010-12-29 00:47:05 +01:00
item_create.cc Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
item_create.h Bug #49829 Many "hides virtual function" warnings with 2010-03-14 17:01:45 +01:00
item_func.cc Merge 2010-12-29 00:47:05 +01:00
item_func.h Update of copyright headers for files I changed this year. 2011-01-27 23:47:24 +01:00
item_geofunc.cc Manual merge of the fix for bug#43668. 2009-11-24 18:26:13 +03:00
item_geofunc.h Bug #57321 crashes and valgrind errors from spatial types 2011-01-12 17:02:41 +04:00
item_row.cc Fixed following problems: 2010-12-14 12:33:03 +03:00
item_row.h Bug#51598 Inconsistent behaviour with a COALESCE statement inside an IN comparison 2010-03-19 10:21:37 +04:00
item_strfunc.cc Bug#58371 Assertion failed: !s.uses_buffer_owned_by(this) with format string function 2011-01-17 15:11:33 +03:00
item_strfunc.h Bug#58371 Assertion failed: !s.uses_buffer_owned_by(this) with format string function 2011-01-17 15:11:33 +03:00
item_subselect.cc Merge 2010-12-29 00:47:05 +01:00
item_subselect.h Fixed following problems: 2010-12-14 12:33:03 +03:00
item_sum.cc Merge 2010-12-29 00:47:05 +01:00
item_sum.h Bug#59149 valgrind warnings with "like .. escape .." function 2011-01-17 12:30:22 +03:00
item_timefunc.cc Bug#58005 utf8 + get_format causes failed assertion: !str || str != Ptr' 2010-11-12 13:12:15 +03:00
item_timefunc.h minor fix of copyright header 2011-01-28 13:37:39 +01:00
item_xmlfunc.cc Bug#57257 Replace(ExtractValue(...)) causes MySQL crash 2010-11-11 13:25:23 +03:00
item_xmlfunc.h
key.cc Bug#37721: ORDER BY when WHERE contains non-partitioned 2008-10-10 12:01:01 +02:00
lex.h Bug#45829 "CREATE TABLE TRANSACTIONAL PAGE_CHECKSUM ROW_FORMAT=PAGE accepted, does nothing": 2009-07-29 10:54:20 +02:00
lex_symbol.h
lock.cc Bug#45288: pb2 returns a lot of compilation warnings 2010-10-20 16:21:40 -02:00
log.cc Bug#51023: Mysql server crashes on SIGHUP and destroys InnoDB files 2011-01-07 16:33:36 -02:00
log.h BUG#46166: MYSQL_BIN_LOG::new_file_impl is not propagating error 2010-11-30 23:32:51 +00:00
log_event.cc Bug #50914 mysqlbinlog not handling drop of current default database 2010-12-29 11:52:57 +08:00
log_event.h Bug #56662 Assertion failed: next_insert_id == 0, file .\handler.cc 2010-12-21 12:47:22 +08:00
log_event_old.cc Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
log_event_old.h
Makefile.am Bug#57210: remove pstack 2010-11-09 12:45:13 -02:00
message.h - Added/updated copyright headers 2010-12-28 19:57:23 +01:00
message.mc Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows. 2008-10-23 15:28:53 +02:00
message.rc Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows. 2008-10-23 15:28:53 +02:00
mf_iocache.cc
MSG00001.bin Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows. 2008-10-23 15:28:53 +02:00
my_decimal.cc Bug#57818 string conversion function died 2010-12-14 19:08:25 +03:00
my_decimal.h Bug#45288: pb2 returns a lot of compilation warnings 2010-10-19 20:36:59 -02:00
my_lock.c
mysql_priv.h Postfix bug#49124 2011-01-26 15:30:06 +08:00
mysql_priv.h.pp Bug#47857 strip_sp function in mysys/mf_strip.c never used and cause name clash 2009-10-06 13:04:51 +02:00
mysqld.cc Fixed bug#58026 - massive recursion and crash in regular expression 2011-02-04 10:47:46 +06:00
mysqld_suffix.h
net_serv.cc Fixed Bug#58887 - server not throwing "Packet too large" error 2011-01-11 21:18:25 +06:00
nt_servc.cc merge 2008-11-22 01:10:38 +01:00
nt_servc.h merge 2008-11-22 01:10:38 +01:00
opt_range.cc Merge 2010-12-29 00:47:05 +01:00
opt_range.h Bug#56862 Execution of a query that uses index merge returns a wrong result 2010-11-23 13:18:47 +03:00
opt_sum.cc Bug#53859: Valgrind: opt_sum_query(TABLE_LIST*, List<Item>&, 2010-06-11 09:38:29 +02:00
parse_file.cc Bug#44834 strxnmov is expected to behave as you'd expect 2009-06-19 13:24:43 +05:00
parse_file.h Bug#43385 Cannot ALTER DATABASE ... UPGRADE DATA DIRECTORY NAME when Views exist(addon) 2009-04-13 18:09:10 +05:00
partition_element.h
partition_info.cc Bug#45288: pb2 returns a lot of compilation warnings on linux 2010-07-20 15:07:36 -03:00
partition_info.h fixed a valgrind warning in partition_pruning 2009-09-02 18:42:08 +03:00
password.c Manual merge. 2009-06-01 16:00:38 +04:00
procedure.cc
procedure.h
protocol.cc Merge 5.1-bugteam -> 5.1-bug-42496 2010-07-23 18:15:56 +07:00
protocol.h Bug#44521 Executing a stored procedure as a prepared statement can sometimes cause 2009-07-29 22:07:08 +02:00
records.cc Bug#56862 Execution of a query that uses index merge returns a wrong result 2010-11-23 13:18:47 +03:00
repl_failsafe.cc BUG#53657: Slave crashed with error 22 when trying to lock mutex 2010-05-24 17:43:27 +01:00
repl_failsafe.h
rpl_constants.h BUG#40482: server/mysqlbinlog crashes when reading invalid Incident_log_event 2008-12-29 17:04:10 +01:00
rpl_filter.cc A patch for Bug#45118 (mysqld.exe crashed in debug mode 2009-09-10 11:40:57 +04:00
rpl_filter.h
rpl_injector.cc BUG#46166: MYSQL_BIN_LOG::new_file_impl is not propagating error 2010-11-30 23:32:51 +00:00
rpl_injector.h
rpl_mi.cc BUG#53657: Slave crashed with error 22 when trying to lock mutex 2010-05-24 17:43:27 +01:00
rpl_mi.h BUG#53657: Slave crashed with error 22 when trying to lock mutex 2010-05-24 17:43:27 +01:00
rpl_record.cc Bug #56662 Assertion failed: next_insert_id == 0, file .\handler.cc 2010-12-21 12:47:22 +08:00
rpl_record.h Bug #56662 Assertion failed: next_insert_id == 0, file .\handler.cc 2010-12-21 12:47:22 +08:00
rpl_record_old.cc
rpl_record_old.h
rpl_reporting.cc BUG#45511 rpl.rpl_binlog_corruption fails with warning messages in Valgrind 2009-06-16 16:04:30 +01:00
rpl_reporting.h BUG#45511 rpl.rpl_binlog_corruption fails with warning messages in Valgrind 2009-06-16 16:04:30 +01:00
rpl_rli.cc Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
rpl_rli.h BUG#55263: assert in check_binlog_magic 2010-09-24 10:44:53 +01:00
rpl_tblmap.cc Bug#45613 handle failures from my_hash_insert 2009-11-20 16:18:01 +01:00
rpl_tblmap.h Bug#31455 mysqlbinlog don't print user readable info about RBR events 2008-08-20 19:06:31 +05:00
rpl_utility.cc BUG#49618: Field length stored incorrectly in binary log 2010-03-17 15:28:49 +01:00
rpl_utility.h Merging with mysql-5.1-bugteam 2010-03-17 19:15:41 +01:00
scheduler.cc
scheduler.h
set_var.cc merge to 5.1. 2011-02-02 19:05:28 +02:00
set_var.h Merge 2010-12-29 00:47:05 +01:00
slave.cc Postfix BUG#58546 2011-01-24 11:48:54 +08:00
slave.h BUG#46166: MYSQL_BIN_LOG::new_file_impl is not propagating error 2010-11-30 23:32:51 +00:00
sp.cc Manual merge from the bugfix tree. 2010-06-11 16:52:06 +04:00
sp.h Bug#45613 handle failures from my_hash_insert 2009-11-20 16:18:01 +01:00
sp_cache.cc Bug#50624: crash in check_table_access during call procedure 2010-02-13 08:35:14 -02:00
sp_cache.h A fix for 2008-07-03 23:41:22 +04:00
sp_head.cc Fixed bug#54375 - Error in stored procedure leaves connection 2010-11-11 10:52:51 +06:00
sp_head.h Bug#50755: Crash if stored routine def contains version comments 2010-04-01 10:15:22 -03:00
sp_pcontext.cc merging 2009-04-29 07:59:10 +05:00
sp_pcontext.h Manual merge. 2009-12-18 16:44:24 -02:00
sp_rcontext.cc Bug#34384: Slow down on constant conversion. 2009-11-06 22:34:25 +03:00
sp_rcontext.h
spatial.cc Fix for bug #51875: crash when loading data into geometry function polyfromwkb 2010-08-30 11:51:46 +04:00
spatial.h Bug#42733: Type-punning warnings when compiling MySQL -- 2010-07-14 16:39:40 -03:00
sql_acl.cc Bug#45288: pb2 returns a lot of compilation warnings 2010-10-20 16:21:40 -02:00
sql_acl.h Bug#41726: upgrade from 5.0 to 5.1.30 crashes if you didn't run mysql_upgrade 2009-11-21 09:18:21 -02:00
sql_analyse.cc Bug#45288: pb2 returns a lot of compilation warnings on linux 2010-07-09 09:00:17 -03:00
sql_analyse.h
sql_array.h
sql_base.cc Fix for bug#58553, "Queries with pushed conditions causes 'explain extended' 2011-01-11 12:09:54 +01:00
sql_binlog.cc BUG#54903 BINLOG statement toggles session variables 2010-11-28 17:43:36 +08:00
sql_bitmap.h
sql_builtin.cc.in
sql_cache.cc Follow-up for Bug#42503: fix a compilation warning. 2010-09-24 19:03:28 +07:00
sql_cache.h Bug#39253 Large query cache still freezes server after fix for bug #21074 2009-11-20 13:49:06 +01:00
sql_class.cc Bug#27606 GRANT statement should be replicated with DEFINER information 2010-10-23 20:55:44 +08:00
sql_class.h merge to 5.1. 2011-02-02 19:05:28 +02:00
sql_client.cc
sql_connect.cc Bug #49752: 2469.126.2 unintentionally breaks authentication against 2010-11-11 07:34:14 +00:00
sql_crypt.cc Bug#49141: Encode function is significantly slower in 5.1 compared to 5.0 2009-12-04 13:36:58 -02:00
sql_crypt.h Bug#49141: Encode function is significantly slower in 5.1 compared to 5.0 2009-12-04 13:36:58 -02:00
sql_cursor.cc Fixed bug #42496 - the server could crash on a debug assert after a failure 2010-07-21 14:56:43 +07:00
sql_cursor.h
sql_db.cc Fixed bug#54486 - assert in my_seek, concurrent 2010-12-10 13:48:50 +06:00
sql_delete.cc Bug #54734 assert in Diagnostics_area::set_ok_status 2010-07-19 11:03:52 +02:00
sql_derived.cc Fixed following problems: 2010-12-14 12:33:03 +03:00
sql_do.cc
sql_error.cc Bug#29125 Windows Server X64: so many compiler warnings 2009-02-13 11:41:47 -05:00
sql_error.h
sql_handler.cc Fix for bug #54007: assert in ha_myisam::index_next, HANDLER 2010-06-09 14:45:04 +04:00
sql_help.cc Bug#45288: pb2 returns a lot of compilation warnings 2010-10-20 16:21:40 -02:00
sql_insert.cc BUG#59338 Inconsistency in binlog for statements that don't change any rows STATEMENT SBR 2011-01-28 12:09:15 +00:00
sql_lex.cc Postfix bug#49124 2011-01-26 15:30:06 +08:00
sql_lex.h Postfix bug#49124 2011-01-26 15:30:06 +08:00
sql_list.cc
sql_list.h Fix somewhat bogus GCC warning. Although needless as the base 2010-07-03 10:20:05 -03:00
sql_load.cc BUG#46166: MYSQL_BIN_LOG::new_file_impl is not propagating error 2010-11-30 23:32:51 +00:00
sql_locale.cc Bug#43207 wrong LC_TIME names for romanian locale 2009-10-19 13:41:52 +05:00
sql_manager.cc Bug#38522: 5 seconds delay when closing application using embedded server 2008-12-04 19:41:53 +01:00
sql_map.cc
sql_map.h
sql_olap.cc Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:45:22 -03:00
sql_parse.cc Postfix bug#49124 2011-01-26 15:30:06 +08:00
sql_partition.cc Update of copyright headers for files I changed this year. 2011-01-27 23:47:24 +01:00
sql_partition.h BUG#49124 Security issue with /*!-versioned */ SQL statements on Slave 2010-07-29 11:00:57 +08:00
sql_plugin.cc BUG#58246 post-push fix broken DBG build. 2010-12-02 08:14:43 +01:00
sql_plugin.h BUG#58246: INSTALL PLUGIN not secure & crashable 2010-12-01 13:54:50 +01:00
sql_prepare.cc Merge 2010-12-29 00:47:05 +01:00
sql_profile.cc Bug #49829 Many "hides virtual function" warnings with 2010-03-14 17:01:45 +01:00
sql_profile.h Backport WL#3653 to 5.1 to enable bundled innodb plugin. 2009-06-10 10:59:49 +02:00
sql_rename.cc A fix and a test case for Bug#47924 -main.log_tables times out 2010-11-07 23:42:54 +06:00
sql_repl.cc BUG#55675 rpl.rpl_log_pos fails sporadically with error binlog truncated in the middle 2011-01-28 01:25:26 +00:00
sql_repl.h
sql_select.cc Fix for bug#59308: Incorrect result for SELECT DISTINCT <col>... ORDER BY <col> DESC. 2011-02-07 10:36:21 +01:00
sql_select.h Merge 2010-12-29 00:47:05 +01:00
sql_servers.cc Bug#33982 debug assertion and crash reloading grant tables after sighup or kill 2010-01-13 12:39:00 +01:00
sql_servers.h
sql_show.cc Merge mysql-5.1 -> mysql-5.1-innodb 2011-01-07 13:46:21 +02:00
sql_show.h Added "Sun Microsystems, Inc." to copyright headers on files modified 2008-11-10 21:21:49 +01:00
sql_sort.h
sql_state.c
sql_string.cc Bug#58165: "my_empty_string" gets modified and causes LOAD DATA to fail and 2011-01-13 08:57:15 +01:00
sql_string.h Bug#58165: "my_empty_string" gets modified and causes LOAD DATA to fail and 2011-01-13 08:57:15 +01:00
sql_table.cc Fixed bug#56619 - Assertion failed during 2010-11-10 14:32:42 +06:00
sql_tablespace.cc Backport Bug#37148 to 5.1 2010-01-24 15:03:23 +08:00
sql_test.cc Bug #50271: Debug output of JOIN structures is garbled 2010-01-28 12:10:57 +01:00
sql_trigger.cc Fixed bug #55421 - Protocol::end_statement(): Assertion `0' on 2010-09-07 15:53:46 +07:00
sql_trigger.h Fix for 2009-01-14 18:50:51 +04:00
sql_udf.cc BUG#58246: INSTALL PLUGIN not secure & crashable 2010-12-01 13:54:50 +01:00
sql_udf.h
sql_union.cc Bug#45288: pb2 returns a lot of compilation warnings 2010-10-20 16:21:40 -02:00
sql_update.cc Merge 2010-12-29 00:47:05 +01:00
sql_view.cc Fix for bug #58499 "DEFINER-security view selecting from 2011-01-12 16:08:30 +03:00
sql_view.h Bug#43385 Cannot ALTER DATABASE ... UPGRADE DATA DIRECTORY NAME when Views exist(addon) 2009-04-13 18:09:10 +05:00
sql_yacc.yy Fixed bug#36742 - GRANT hostname case handling inconsistent. 2010-10-13 12:28:58 +07:00
strfunc.cc Bug #43414 Parenthesis (and other) warnings compiling MySQL 2009-09-23 15:21:29 +02:00
structs.h A fix and a test case for 2009-11-03 20:45:52 +03:00
table.cc Update of copyright headers for files I changed this year. 2011-01-27 23:47:24 +01:00
table.h Merge 2010-12-29 00:47:05 +01:00
thr_malloc.cc Bug #42064: low memory crash when importing hex strings, in 2010-05-21 15:23:48 +04:00
time.cc Bug#47925: regression of range optimizer and date comparison in 5.1.39! 2009-11-02 13:24:07 +01:00
tzfile.h
tztime.cc Bug #55424: convert_tz crashes when fed invalid data 2010-08-06 23:29:37 +04:00
tztime.h Backport of a 5.0.74 fix into 5.0.72sp1: 2009-01-12 17:40:29 +01:00
udf_example.c Bug#45288: pb2 returns a lot of compilation warnings on linux 2010-07-20 15:07:36 -03:00
udf_example.def
uniques.cc Merge from 5.0-bugteam 2009-06-17 16:56:44 +02:00
unireg.cc Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00
unireg.h Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00