mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning". |
||
|---|---|---|
| .. | ||
| AUTHORS | ||
| ChangeLog | ||
| CMakeLists.txt | ||
| FAQ | ||
| federatedx_io.cc | ||
| federatedx_io_mysql.cc | ||
| federatedx_io_null.cc | ||
| federatedx_probes.h | ||
| federatedx_pushdown.cc | ||
| federatedx_pushdown.h | ||
| federatedx_txn.cc | ||
| ha_federatedx.cc | ||
| ha_federatedx.h | ||
| README | ||
| README.windows | ||
This is the FederatedX Storage Engine, developed as an external storage engine. NOTE: The following is only relevant if you use it for MySQL. MariaDB already comes with the latest version of FederatedX. To install, grab a copy of the mysql source code and run this: ./configure --with-mysql=/path/to/src/mysql-5.x --libdir=/usr/local/lib/mysql/ make install And then inside of MySQL: mysql> INSTALL PLUGIN federatedx SONAME 'libfederatedx_engine.so'; mysql> CREATE TABLE `d` (`a` varchar(125), b text, primary key(a)) ENGINE=FEDERATEDX CONNECTION="mysql://root@host/schema/table" or mysql> CREATE TABLE `d` (`a` varchar(125), b text, primary key(a)) ENGINE=FEDERATEDX CONNECTION="server" CHARSET=latin1; You will probably need to edit the Makefile.am in the src/ tree if you want to build on anything other then Linux (and the Makefile assumes that the server was not compiled for debug). The reason for the two possible configure lines is that libdir is dependent on where MySQL was installed. If you run the "INSTALL PLUGIN ..." and you get a file not found, check that your configured this directory correctly. For Solaris you can enable DTrace probes by adding to configure --enable-dtrace