mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
9438b98519
Bug #21785 "Server crashes after rename of the log table" and Bug #21966 "Strange warnings on create like/repair of the log tables" According to the patch, from now on, one should use RENAME to perform a log table rotation (this should also be reflected in the manual). Here is a sample: use mysql; CREATE TABLE IF NOT EXISTS general_log2 LIKE general_log; RENAME TABLE general_log TO general_log_backup, general_log2 TO general_log; The rules for Rename of the log tables are following: IF 1. Log tables are enabled AND 2. Rename operates on the log table and nothing is being renamed to the log table. DO 3. Throw an error message. ELSE 4. Perform rename. The very RENAME query will go the the old (backup) table. This is consistent with the behavoiur we have with binlog ROTATE LOGS statement. Other problems, which are solved by the patch are: 1) Now REPAIR of the log table is exclusive operation (as it should be), this also eliminates lock-related warnings. and 2) CREATE LIKE TABLE now usese usual read lock on the source table rather then name lock, which is too restrictive. This way we get rid of another log table-related warning, which occured because of the above fact (as a side-effect, name lock resulted in a warning). mysql-test/r/log_tables.result: update result file mysql-test/t/log_tables.test: Add tests for the bugs sql/handler.cc: update comment sql/handler.h: update function to reflect changes in log tables locking logic. sql/lock.cc: Now we allow locking of the log tables for "privileged" threads Privileged thread must explicitly close and lock log tables. This is required for admin operations such as REPAIR. sql/log.cc: Changes to the file: 1) Add checks for table schema. It's more important now, as we allow rename of the log tables. Since we should check for schema when writing to a log table. E.g. if one created a table with one-only comlumn and renamed it to general_log, the server should cope with it. 2) refactor LOGGER::flush(), so that we can now use the same machinery as we use in FLUSH LOGS in other statements: whenever we have to perform a serious operation on the log tables, we have to (a) lock logger, which blocks other concurrent statements (such as selects) (b) close logs. Then perform an exclusive operation, c) reenable logs and d) unlock logger. 3) Add a function to check if a given table is a log table. 4) Add support for "privileged" thread 5) merge is_[general/slow]_log_table_enabled() into one function. 6) Add new function: reopen _log_tables, which reopens the tables, which were enabled (after temporary close, required for admin operation) sql/log.h: 1) add a new call close_n_lock_tables(). Now we use it instead of LOGGER::flush() in FLUSH LOGS implementation. 2) add a prototype for the function to check if a given table is a log table; 3) add privileged table flag to table logger 4) merge is_[general/slow]_log_table_enabled() into one function. sql/mysql_priv.h: move log table defines to log.h sql/sql_delete.cc: use new function check_if_log_table() instead of direct strcmp sql/sql_rename.cc: Traverse the list of tables in mysql_rename_tables to make sure that log tables are processed correctly (that is, according to the rules specified in the main CS comment) sql/sql_table.cc: 1) mysql_admin_table() should disable logs if it performs exclusive admin operation on a log table. This way we also eliminate warning on REPAIR of the log table. 2) mysql_create_like_table should read-lock the source table instead getting name lock on it. Name lock is too restrictive in this case. sql/share/errmsg.txt: Add a new error message for rename of the log tables sql/table.cc: use new function instead of direct strcmp. change my_strcasecmp() -> strcmp(), when comparing system db and table names storage/csv/ha_tina.cc: update function to reflect changes in log tables locking logic. storage/myisam/ha_myisam.cc: update function to reflect changes in log tables locking logic.
288 lines
13 KiB
Text
288 lines
13 KiB
Text
use mysql;
|
|
truncate table general_log;
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
truncate table slow_log;
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
truncate table general_log;
|
|
select * from general_log where argument like '%general_log%';
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log where argument like '%general_log%'
|
|
create table join_test (verbose_comment varchar (80), command_type varchar(64));
|
|
insert into join_test values ("User performed a usual SQL query", "Query");
|
|
insert into join_test values ("New DB connection was registered", "Connect");
|
|
insert into join_test values ("Get the table info", "Field List");
|
|
select verbose_comment, user_host, argument
|
|
from mysql.general_log join join_test
|
|
on (mysql.general_log.command_type = join_test.command_type);
|
|
verbose_comment user_host argument
|
|
User performed a usual SQL query USER_HOST select * from general_log where argument like '%general_log%'
|
|
User performed a usual SQL query USER_HOST create table join_test (verbose_comment varchar (80), command_type varchar(64))
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("User performed a usual SQL query", "Query")
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("New DB connection was registered", "Connect")
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("Get the table info", "Field List")
|
|
User performed a usual SQL query USER_HOST select verbose_comment, user_host, argument
|
|
from mysql.general_log join join_test
|
|
on (mysql.general_log.command_type = join_test.command_type)
|
|
drop table join_test;
|
|
flush logs;
|
|
lock tables mysql.general_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.slow_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.general_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
unlock tables;
|
|
lock tables mysql.general_log READ LOCAL;
|
|
flush logs;
|
|
unlock tables;
|
|
select "Mark that we woke up from flush logs in the test"
|
|
as "test passed";
|
|
test passed
|
|
Mark that we woke up from flush logs in the test
|
|
lock tables mysql.general_log READ LOCAL;
|
|
truncate mysql.general_log;
|
|
unlock tables;
|
|
select "Mark that we woke up from TRUNCATE in the test"
|
|
as "test passed";
|
|
test passed
|
|
Mark that we woke up from TRUNCATE in the test
|
|
use test;
|
|
truncate table mysql.general_log;
|
|
set names utf8;
|
|
create table bug16905 (s char(15) character set utf8 default 'пусто');
|
|
insert into bug16905 values ('новое');
|
|
select * from mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set names utf8
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table bug16905 (s char(15) character set utf8 default 'пусто')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query insert into bug16905 values ('новое')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
drop table bug16905;
|
|
truncate table mysql.slow_log;
|
|
set session long_query_time=1;
|
|
select sleep(2);
|
|
sleep(2)
|
|
0
|
|
select * from mysql.slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
TIMESTAMP USER_HOST QUERY_TIME 00:00:00 1 0 test 0 0 1 select sleep(2)
|
|
alter table mysql.general_log engine=myisam;
|
|
ERROR HY000: You can't alter a log table if logging is enabled
|
|
alter table mysql.slow_log engine=myisam;
|
|
ERROR HY000: You can't alter a log table if logging is enabled
|
|
drop table mysql.general_log;
|
|
ERROR HY000: Cannot drop log table if log is enabled
|
|
drop table mysql.slow_log;
|
|
ERROR HY000: Cannot drop log table if log is enabled
|
|
set global general_log='OFF';
|
|
alter table mysql.slow_log engine=myisam;
|
|
ERROR HY000: You can't alter a log table if logging is enabled
|
|
set global slow_query_log='OFF';
|
|
show create table mysql.general_log;
|
|
Table Create Table
|
|
general_log CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='General log'
|
|
show create table mysql.slow_log;
|
|
Table Create Table
|
|
slow_log CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='Slow log'
|
|
alter table mysql.general_log engine=myisam;
|
|
alter table mysql.slow_log engine=myisam;
|
|
Warnings:
|
|
Warning 1264 Out of range value for column 'last_insert_id' at row 0
|
|
Warning 1264 Out of range value for column 'insert_id' at row 0
|
|
show create table mysql.general_log;
|
|
Table Create Table
|
|
general_log CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=MyISAM DEFAULT CHARSET=utf8 COMMENT='General log'
|
|
show create table mysql.slow_log;
|
|
Table Create Table
|
|
slow_log CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=utf8 COMMENT='Slow log'
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
select * from mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set names utf8
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table bug16905 (s char(15) character set utf8 default 'пусто')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query insert into bug16905 values ('новое')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table bug16905
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query truncate table mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set session long_query_time=1
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select sleep(2)
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query alter table mysql.general_log engine=myisam
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query alter table mysql.slow_log engine=myisam
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table mysql.general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set global general_log='OFF'
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set global slow_query_log='ON'
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
flush logs;
|
|
lock tables mysql.general_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.slow_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.general_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
unlock tables;
|
|
set global general_log='OFF';
|
|
set global slow_query_log='OFF';
|
|
alter table mysql.slow_log engine=ndb;
|
|
ERROR HY000: One can use only CSV and MyISAM engines for the log tables
|
|
alter table mysql.slow_log engine=innodb;
|
|
ERROR HY000: One can use only CSV and MyISAM engines for the log tables
|
|
alter table mysql.slow_log engine=archive;
|
|
ERROR HY000: One can use only CSV and MyISAM engines for the log tables
|
|
alter table mysql.slow_log engine=blackhole;
|
|
ERROR HY000: One can use only CSV and MyISAM engines for the log tables
|
|
drop table mysql.slow_log;
|
|
drop table mysql.general_log;
|
|
drop table mysql.general_log;
|
|
ERROR 42S02: Unknown table 'general_log'
|
|
drop table mysql.slow_log;
|
|
ERROR 42S02: Unknown table 'slow_log'
|
|
use mysql;
|
|
CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='General log';
|
|
CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='Slow log';
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
use test;
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
use mysql;
|
|
lock tables general_log read local, help_category read local;
|
|
unlock tables;
|
|
use mysql;
|
|
RENAME TABLE general_log TO renamed_general_log;
|
|
ERROR HY000: Cannot rename 'general_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'general_log'
|
|
RENAME TABLE slow_log TO renamed_slow_log;
|
|
ERROR HY000: Cannot rename 'slow_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'slow_log'
|
|
truncate table general_log;
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
truncate table slow_log;
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
create table general_log_new like general_log;
|
|
rename table general_log TO renamed_general_log, general_log_new TO general_log;
|
|
create table slow_log_new like slow_log;
|
|
rename table slow_log TO renamed_slow_log, slow_log_new TO slow_log;
|
|
rename table general_log TO general_log_new, renamed_general_log TO general_log, slow_log to renamed_slow_log;
|
|
ERROR HY000: Cannot rename 'slow_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'slow_log'
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table slow_log_new like slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table slow_log TO renamed_slow_log, slow_log_new TO slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table general_log TO general_log_new, renamed_general_log TO general_log, slow_log to renamed_slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
select * from renamed_general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query truncate table slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table general_log_new like general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table general_log TO renamed_general_log, general_log_new TO general_log
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
select * from renamed_slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
set global general_log='OFF';
|
|
RENAME TABLE general_log TO general_log2;
|
|
set global slow_query_log='OFF';
|
|
RENAME TABLE slow_log TO slow_log2;
|
|
set global general_log='ON';
|
|
ERROR HY000: Cannot activate 'general' log
|
|
set global slow_query_log='ON';
|
|
ERROR HY000: Cannot activate 'slow query' log
|
|
RENAME TABLE general_log2 TO general_log;
|
|
RENAME TABLE slow_log2 TO slow_log;
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
flush logs;
|
|
flush logs;
|
|
drop table renamed_general_log, renamed_slow_log;
|
|
use test;
|
|
use mysql;
|
|
repair table general_log;
|
|
Table Op Msg_type Msg_text
|
|
mysql.general_log repair status OK
|
|
repair table slow_log;
|
|
Table Op Msg_type Msg_text
|
|
mysql.slow_log repair status OK
|
|
create table general_log_new like general_log;
|
|
create table slow_log_new like slow_log;
|
|
show tables like "%log%";
|
|
Tables_in_mysql (%log%)
|
|
general_log
|
|
general_log_new
|
|
slow_log
|
|
slow_log_new
|
|
drop table slow_log_new, general_log_new;
|
|
use test;
|