mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
2f78abd21b
Problem: Some system functions that could return different values on
master and slave were not marked unsafe. In particular:
GET_LOCK
IS_FREE_LOCK
IS_USED_LOCK
MASTER_POS_WAIT
RELEASE_LOCK
SLEEP
SYSDATE
VERSION
Fix: Mark these functions unsafe.
mysql-test/extra/rpl_tests/rpl_stm_000001.test:
- The test does not work in mixed mode any more, since it tries to
simulate an error in the sql thread in a query that uses get_lock.
Since get_lock now causes the query to be logged in row format,
the error didn't happen. Hence, we now force statement mode.
- Warnings must be disabled when the unsafe query is issued.
- Replaced some save_master_pos+connection slave+sync_with_master
by sync_slave_with_master.
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
updated result file
mysql-test/suite/binlog/r/binlog_stm_row.result:
updated result file
mysql-test/suite/binlog/r/binlog_unsafe.result:
updated result file
mysql-test/suite/binlog/t/binlog_killed.test:
binlog_killed only works in statement format now, since
it switches to row mode in mixed mode.
mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
suppress warnings for unsafe statements
mysql-test/suite/binlog/t/binlog_stm_row.test:
- Suppress warnings in test that causes warnings.
- The test sets binlog format explicitly, so no need to execute it
twice.
mysql-test/suite/binlog/t/binlog_unsafe.test:
Added test for all unsafe system functions. This test also includes
system functions that were unsafe prior to BUG#47995.
mysql-test/suite/rpl/r/rpl_err_ignoredtable.result:
updated result file
mysql-test/suite/rpl/r/rpl_get_lock.result:
updated result file
mysql-test/suite/rpl/r/rpl_nondeterministic_functions.result:
new result file
mysql-test/suite/rpl/r/rpl_stm_000001.result:
updated result file
mysql-test/suite/rpl/r/rpl_trigger.result:
updated result file
mysql-test/suite/rpl/t/rpl_err_ignoredtable.test:
- suppress warnings for unsafe statement
- replaced save_master_pos+connection slave+sync_with_master
with sync_slave_with_master
mysql-test/suite/rpl/t/rpl_get_lock.test:
update test case that causes new warnings
mysql-test/suite/rpl/t/rpl_nondeterministic_functions.test:
Added new test case for nondeterministic functions.
mysql-test/suite/rpl/t/rpl_trigger.test:
update test case that causes new warnings
sql/item_create.cc:
Marked some system functions unsafe.
sql/item_strfunc.cc:
Clarified comment related to this bug.
sql/sql_yacc.yy:
Marked sysdate unsafe.
78 lines
2.5 KiB
Text
78 lines
2.5 KiB
Text
CALL mtr.add_suppression("Statement may not be safe to log in statement format.");
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE IF EXISTS t2;
|
|
set @saved_global_binlog_format = @@global.binlog_format;
|
|
set @saved_local_binlog_format = @@session.binlog_format;
|
|
SET GLOBAL BINLOG_FORMAT = STATEMENT;
|
|
SET SESSION BINLOG_FORMAT = STATEMENT;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TABLE t2 LIKE t1;
|
|
select @@SESSION.BINLOG_FORMAT;
|
|
@@SESSION.BINLOG_FORMAT
|
|
STATEMENT
|
|
INSERT INTO t1 VALUES(1);
|
|
INSERT INTO t2 VALUES(2);
|
|
#
|
|
# Ensure that INSERT INTO .. SELECT FROM under SBR takes a read
|
|
# lock that will prevent the source table from being modified.
|
|
#
|
|
# con1
|
|
SELECT GET_LOCK('Bug#34306', 120);
|
|
GET_LOCK('Bug#34306', 120)
|
|
1
|
|
# con2
|
|
PREPARE stmt FROM "INSERT INTO t1 SELECT * FROM t2 WHERE GET_LOCK('Bug#34306', 120)";
|
|
EXECUTE stmt;;
|
|
# default
|
|
INSERT INTO t2 VALUES (3);;
|
|
# con1
|
|
SELECT RELEASE_LOCK('Bug#34306');
|
|
RELEASE_LOCK('Bug#34306')
|
|
1
|
|
# con2
|
|
Warnings:
|
|
Note 1592 Statement may not be safe to log in statement format.
|
|
SELECT RELEASE_LOCK('Bug#34306');
|
|
RELEASE_LOCK('Bug#34306')
|
|
1
|
|
# default
|
|
#
|
|
# Ensure that INSERT INTO .. SELECT FROM prepared under SBR does
|
|
# not prevent the source table from being modified if under RBR.
|
|
#
|
|
# con2
|
|
SET SESSION BINLOG_FORMAT = ROW;
|
|
# con1
|
|
SELECT GET_LOCK('Bug#34306', 120);
|
|
GET_LOCK('Bug#34306', 120)
|
|
1
|
|
# con2
|
|
EXECUTE stmt;;
|
|
# default
|
|
# con1
|
|
INSERT INTO t2 VALUES (4);
|
|
SELECT RELEASE_LOCK('Bug#34306');
|
|
RELEASE_LOCK('Bug#34306')
|
|
1
|
|
# con2
|
|
# default
|
|
# Show binlog events
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE IF EXISTS t1
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE IF EXISTS t2
|
|
master-bin.000001 # Query # # use `test`; CREATE TABLE t1 (a INT)
|
|
master-bin.000001 # Query # # use `test`; CREATE TABLE t2 LIKE t1
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t1 VALUES(1)
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 VALUES(2)
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t1 SELECT * FROM t2 WHERE GET_LOCK('Bug#34306', 120)
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 VALUES (3)
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 VALUES (4)
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t1)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Query # # COMMIT
|
|
DROP TABLE t1;
|
|
DROP TABLE t2;
|
|
SET GLOBAL BINLOG_FORMAT = @saved_global_binlog_format;
|
|
SET SESSION BINLOG_FORMAT = @saved_local_binlog_format;
|