mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
75d59ff967
This crash could happen if TRUNCATE TABLE indirectly failed to open a merge table due to failures to open underlying tables. Even if opening failed, the TRUNCATE TABLE code would try to invalidate the table in the query cache. Since this table had been closed and memory released, this could lead to a crash. This bug was introduced by a combination of the changes introduced by the patch for Bug#52044, where failing to open a table will cause opened tables to be closed. And the changes in patch for Bug#49938, where TRUNCATE TABLE uses the standard open tables function. This patch fixes the problem by setting the TABLE pointer to NULL before invalidating the query cache. Test case added to truncate_coverage.test.
107 lines
2.4 KiB
Text
107 lines
2.4 KiB
Text
SET DEBUG_SYNC='RESET';
|
|
DROP TABLE IF EXISTS t1;
|
|
#
|
|
# Bug#20667 - Truncate table fails for a write locked table
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# connection con1
|
|
HANDLER t1 OPEN;
|
|
#
|
|
# connection default
|
|
LOCK TABLE t1 WRITE;
|
|
SET DEBUG_SYNC='mdl_upgrade_shared_lock_to_exclusive SIGNAL waiting';
|
|
TRUNCATE TABLE t1;
|
|
#
|
|
# connection con2
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
KILL QUERY @id;
|
|
#
|
|
# connection default
|
|
ERROR 70100: Query execution was interrupted
|
|
UNLOCK TABLES;
|
|
#
|
|
# connection con1
|
|
# Release shared metadata lock by closing HANDLER.
|
|
HANDLER t1 CLOSE;
|
|
#
|
|
# connection default
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# connection con1
|
|
HANDLER t1 OPEN;
|
|
#
|
|
# connection default
|
|
LOCK TABLE t1 WRITE;
|
|
SET DEBUG_SYNC='mdl_upgrade_shared_lock_to_exclusive SIGNAL waiting';
|
|
TRUNCATE TABLE t1;
|
|
#
|
|
# connection con2
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
#
|
|
# connection con1
|
|
HANDLER t1 CLOSE;
|
|
#
|
|
# connection default
|
|
ERROR 42S02: Table 'test.t1' doesn't exist
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
ERROR 42S02: Unknown table 't1'
|
|
SET DEBUG_SYNC='RESET';
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# connection con1
|
|
START TRANSACTION;
|
|
INSERT INTO t1 VALUES (2);
|
|
#
|
|
# connection default
|
|
SET DEBUG_SYNC='mdl_acquire_lock_wait SIGNAL waiting';
|
|
TRUNCATE TABLE t1;
|
|
#
|
|
# connection con1
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
KILL QUERY @id;
|
|
#
|
|
# connection default
|
|
ERROR 70100: Query execution was interrupted
|
|
#
|
|
# connection con1
|
|
# Release SW lock by committing transaction.
|
|
COMMIT;
|
|
#
|
|
# connection default
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
#
|
|
# Bug#57659 Segfault in Query_cache::invalidate_data for TRUNCATE TABLE
|
|
#
|
|
# Note that this test case only reproduces the problem
|
|
# when it is run with valgrind.
|
|
DROP TABLE IF EXISTS t1, m1;
|
|
CREATE TABLE t1(a INT) engine=memory;
|
|
CREATE TABLE m1(a INT) engine=merge UNION(t1);
|
|
# Connection con1
|
|
SET DEBUG_SYNC= 'open_tables_after_open_and_process_table SIGNAL opened WAIT_FOR dropped';
|
|
# Sending:
|
|
TRUNCATE TABLE m1;
|
|
# Connection con2
|
|
SET DEBUG_SYNC= 'now WAIT_FOR opened';
|
|
# Sending:
|
|
FLUSH TABLES;
|
|
# Connection default
|
|
# Waiting for FLUSH TABLES to be blocked.
|
|
SET DEBUG_SYNC= 'now SIGNAL dropped';
|
|
# Connection con1
|
|
# Reaping: TRUNCATE TABLE m1
|
|
ERROR HY000: Unable to open underlying table which is differently defined or of non-MyISAM type or doesn't exist
|
|
# Connection con2
|
|
# Reaping: FLUSH TABLES
|
|
# Connection default
|
|
SET DEBUG_SYNC= 'RESET';
|
|
DROP TABLE m1, t1;
|