mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
1c0388a5be
Fixed by backport of:
------------------------------------------------------------
revno: 3402.50.156
committer: Jon Olav Hauglid <jon.hauglid@oracle.com>
branch nick: mysql-trunk-test
timestamp: Wed 2012-02-08 14:10:23 +0100
message:
Bug#13417754 ASSERT IN ROW_DROP_DATABASE_FOR_MYSQL DURING DROP SCHEMA
This assert could be triggered if an InnoDB table was being moved
to a different database using ALTER TABLE ... RENAME, while this
database concurrently was being dropped by DROP DATABASE.
The reason for the problem was that no metadata lock was taken
on the target database by ALTER TABLE ... RENAME.
DROP DATABASE was therefore not blocked and could remove
the database while ALTER TABLE ... RENAME was executing. This
could cause the assert in InnoDB to be triggered.
This patch fixes the problem by taking a IX metadata lock on
the target database before ALTER TABLE ... RENAME starts
moving a table to a different database.
Note that this problem did not occur with RENAME TABLE which
already takes the correct metadata locks.
Also note that this patch slightly changes the behavior of
ALTER TABLE ... RENAME. Before, the statement would abort and
return an error if a lock on the target table name could not
be taken immediately. With this patch, ALTER TABLE ... RENAME
will instead block and wait until the lock can be taken
(or until we get a lock timeout). This also means that it is
possible to get ER_LOCK_DEADLOCK errors in this situation
since we allow ALTER TABLE ... RENAME to wait and not just
abort immediately.
228 lines
7.6 KiB
Text
228 lines
7.6 KiB
Text
drop table if exists t1,t2,t3,t4,t5;
|
|
set debug_sync='RESET';
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 (j char(5));;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 select 'Test' as j;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
create table t3 (j char(5));
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create table t1 like t3;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t3 to t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
alter table t3 rename to t1;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
alter table t3 rename to t1, add k int;
|
|
set debug_sync='now SIGNAL go';
|
|
ERROR 42S01: Table 't1' already exists
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`i` int(1) NOT NULL DEFAULT '0'
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t1,t3;
|
|
set debug_sync='create_table_select_before_open SIGNAL parked WAIT_FOR go';
|
|
set debug_sync='create_table_select_before_open SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t1 to t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
select * from t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
i
|
|
1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (2);;
|
|
set debug_sync='now SIGNAL go';
|
|
select * from t1;
|
|
i
|
|
1
|
|
2
|
|
drop table t1;
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_create SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;;
|
|
set debug_sync='now SIGNAL go';
|
|
select @a;
|
|
@a
|
|
0
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
rename table t1 to t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
select * from t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
i
|
|
1
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (2);;
|
|
set debug_sync='now SIGNAL go';
|
|
select * from t1;
|
|
i
|
|
1
|
|
2
|
|
drop table t1;
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_lock SIGNAL parked WAIT_FOR go';
|
|
create table t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;;
|
|
set debug_sync='now SIGNAL go';
|
|
select @a;
|
|
@a
|
|
0
|
|
drop table t1;
|
|
set debug_sync='create_table_select_before_check_if_exists SIGNAL parked WAIT_FOR go';
|
|
create table if not exists t1 select 1 as i;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
create table t1 (i int);
|
|
set @a:=0;
|
|
set debug_sync='create_table_select_before_check_if_exists SIGNAL parked WAIT_FOR go';
|
|
create table if not exists t1 select 1 as i;;
|
|
create trigger t1_bi before insert on t1 for each row set @a:=1;
|
|
Warnings:
|
|
Note 1050 Table 't1' already exists
|
|
select @a;
|
|
@a
|
|
0
|
|
select * from t1;
|
|
i
|
|
drop table t1;
|
|
drop table if exists t1,t2;
|
|
set debug_sync='RESET';
|
|
create table t1 (i int);
|
|
set debug_sync='create_table_like_after_open SIGNAL parked WAIT_FOR go';
|
|
reset master;
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t1 values (1);
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
show create table t2;
|
|
Table Create Table
|
|
t2 CREATE TABLE `t2` (
|
|
`i` int(11) DEFAULT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1
|
|
drop table t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; insert into t1 values (1)
|
|
master-bin.000001 # Query # # COMMIT
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t1` /* generated by server */
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
create table t1 (i int);
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
reset master;
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
insert into t2 values (1);;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t2;;
|
|
set debug_sync='now SIGNAL go';
|
|
set debug_sync='create_table_like_before_binlog SIGNAL parked WAIT_FOR go';
|
|
create table t2 like t1;;
|
|
set debug_sync='now WAIT_FOR parked';
|
|
drop table t1;;
|
|
set debug_sync='now SIGNAL go';
|
|
drop table t2;
|
|
set debug_sync='RESET';
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; insert into t2 values (1)
|
|
master-bin.000001 # Query # # COMMIT
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|
|
master-bin.000001 # Query # # use `test`; create table t2 like t1
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t1` /* generated by server */
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t2` /* generated by server */
|