mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
eba5d30e67
Add a wait-for graph based deadlock detector to the MDL subsystem. Fixes bug #46272 "MySQL 5.4.4, new MDL: unnecessary deadlock" and bug #37346 "innodb does not detect deadlock between update and alter table". The first bug manifested itself as an unwarranted abort of a transaction with ER_LOCK_DEADLOCK error by a concurrent ALTER statement, when this transaction tried to repeat use of a table, which it has already used in a similar fashion before ALTER started. The second bug showed up as a deadlock between table-level locks and InnoDB row locks, which was "detected" only after innodb_lock_wait_timeout timeout. A transaction would start using the table and modify a few rows. Then ALTER TABLE would come in, and start copying rows into a temporary table. Eventually it would stumble on the modified records and get blocked on a row lock. The first transaction would try to do more updates, and get blocked on thr_lock.c lock. This situation of circular wait would only get resolved by a timeout. Both these bugs stemmed from inadequate solutions to the problem of deadlocks occurring between different locking subsystems. In the first case we tried to avoid deadlocks between metadata locking and table-level locking subsystems, when upgrading shared metadata lock to exclusive one. Transactions holding the shared lock on the table and waiting for some table-level lock used to be aborted too aggressively. We also allowed ALTER TABLE to start in presence of transactions that modify the subject table. ALTER TABLE acquires TL_WRITE_ALLOW_READ lock at start, and that block all writes against the table (naturally, we don't want any writes to be lost when switching the old and the new table). TL_WRITE_ALLOW_READ lock, in turn, would block the started transaction on thr_lock.c lock, should they do more updates. This, again, lead to the need to abort such transactions. The second bug occurred simply because we didn't have any mechanism to detect deadlocks between the table-level locks in thr_lock.c and row-level locks in InnoDB, other than innodb_lock_wait_timeout. This patch solves both these problems by moving lock conflicts which are causing these deadlocks into the metadata locking subsystem, thus making it possible to avoid or detect such deadlocks inside MDL. To do this we introduce new type-of-operation-aware metadata locks, which allow MDL subsystem to know not only the fact that transaction has used or is going to use some object but also what kind of operation it has carried out or going to carry out on the object. This, along with the addition of a special kind of upgradable metadata lock, allows ALTER TABLE to wait until all transactions which has updated the table to go away. This solves the second issue. Another special type of upgradable metadata lock is acquired by LOCK TABLE WRITE. This second lock type allows to solve the first issue, since abortion of table-level locks in event of DDL under LOCK TABLES becomes also unnecessary. Below follows the list of incompatible changes introduced by this patch: - From now on, ALTER TABLE and CREATE/DROP TRIGGER SQL (i.e. those statements that acquire TL_WRITE_ALLOW_READ lock) wait for all transactions which has *updated* the table to complete. - From now on, LOCK TABLES ... WRITE, REPAIR/OPTIMIZE TABLE (i.e. all statements which acquire TL_WRITE table-level lock) wait for all transaction which *updated or read* from the table to complete. As a consequence, innodb_table_locks=0 option no longer applies to LOCK TABLES ... WRITE. - DROP DATABASE, DROP TABLE, RENAME TABLE no longer abort statements or transactions which use tables being dropped or renamed, and instead wait for these transactions to complete. - Since LOCK TABLES WRITE now takes a special metadata lock, not compatible with with reads or writes against the subject table and transaction-wide, thr_lock.c deadlock avoidance algorithm that used to ensure absence of deadlocks between LOCK TABLES WRITE and other statements is no longer sufficient, even for MyISAM. The wait-for graph based deadlock detector of MDL subsystem may sometimes be necessary and is involved. This may lead to ER_LOCK_DEADLOCK error produced for multi-statement transactions even if these only use MyISAM: session 1: session 2: begin; update t1 ... lock table t2 write, t1 write; -- gets a lock on t2, blocks on t1 update t2 ... (ER_LOCK_DEADLOCK) - Finally, support of LOW_PRIORITY option for LOCK TABLES ... WRITE was abandoned. LOCK TABLE ... LOW_PRIORITY WRITE from now on has the same priority as the usual LOCK TABLE ... WRITE. SELECT HIGH PRIORITY no longer trumps LOCK TABLE ... WRITE in the wait queue. - We do not take upgradable metadata locks on implicitly locked tables. So if one has, say, a view v1 that uses table t1, and issues: LOCK TABLE v1 WRITE; FLUSH TABLE t1; -- (or just 'FLUSH TABLES'), an error is produced. In order to be able to perform DDL on a table under LOCK TABLES, the table must be locked explicitly in the LOCK TABLES list. mysql-test/include/handler.inc: Adjusted test case to trigger an execution path on which bug 41110 "crash with handler command when used concurrently with alter table" and bug 41112 "crash in mysql_ha_close_table/get_lock_data with alter table" were originally discovered. Left old test case which no longer triggers this execution path for the sake of coverage. Added test coverage for HANDLER SQL statements and type-aware metadata locks. Added a test for the global shared lock and HANDLER SQL. Updated tests to take into account that the old simple deadlock detection heuristics was replaced with a graph-based deadlock detector. mysql-test/r/debug_sync.result: Updated results (see debug_sync.test). mysql-test/r/handler_innodb.result: Updated results (see handler.inc test). mysql-test/r/handler_myisam.result: Updated results (see handler.inc test). mysql-test/r/innodb-lock.result: Updated results (see innodb-lock.test). mysql-test/r/innodb_mysql_lock.result: Updated results (see innodb_mysql_lock.test). mysql-test/r/lock.result: Updated results (see lock.test). mysql-test/r/lock_multi.result: Updated results (see lock_multi.test). mysql-test/r/lock_sync.result: Updated results (see lock_sync.test). mysql-test/r/mdl_sync.result: Updated results (see mdl_sync.test). mysql-test/r/sp-threads.result: SHOW PROCESSLIST output has changed due to the fact that waiting for LOCK TABLES WRITE now happens within metadata locking subsystem. mysql-test/r/truncate_coverage.result: Updated results (see truncate_coverage.test). mysql-test/suite/funcs_1/datadict/processlist_val.inc: SELECT FROM I_S.PROCESSLIST output has changed due to fact that waiting for LOCK TABLES WRITE now happens within metadata locking subsystem. mysql-test/suite/funcs_1/r/processlist_val_no_prot.result: SELECT FROM I_S.PROCESSLIST output has changed due to fact that waiting for LOCK TABLES WRITE now happens within metadata locking subsystem. mysql-test/suite/rpl/t/rpl_sp.test: Updated to a new SHOW PROCESSLIST state name. mysql-test/t/debug_sync.test: Use LOCK TABLES READ instead of LOCK TABLES WRITE as the latter no longer allows to trigger execution path involving waiting on thr_lock.c lock and therefore reaching debug sync-point covered by this test. mysql-test/t/innodb-lock.test: Adjusted test case to the fact that innodb_table_locks=0 option is no longer supported, since LOCK TABLES WRITE handles all its conflicts within MDL subsystem. mysql-test/t/innodb_mysql_lock.test: Added test for bug #37346 "innodb does not detect deadlock between update and alter table". mysql-test/t/lock.test: Added test coverage which checks the fact that we no longer support DDL under LOCK TABLES on tables which were locked implicitly. Adjusted existing test cases accordingly. mysql-test/t/lock_multi.test: Added test for bug #46272 "MySQL 5.4.4, new MDL: unnecessary deadlock". Adjusted other test cases to take into account the fact that waiting for LOCK TABLES ... WRITE now happens within MDL subsystem. mysql-test/t/lock_sync.test: Since LOCK TABLES ... WRITE now takes SNRW metadata lock for tables locked explicitly we have to implicitly lock InnoDB tables (through view) to trigger the table-level lock conflict between TL_WRITE and TL_WRITE_ALLOW_WRITE. mysql-test/t/mdl_sync.test: Added basic test coverage for type-of-operation-aware metadata locks. Also covered with tests some use cases involving HANDLER statements in which a deadlock could arise. Adjusted existing tests to take type-of-operation-aware MDL into account. mysql-test/t/multi_update.test: Update to a new SHOW PROCESSLIST state name. mysql-test/t/truncate_coverage.test: Adjusted test case after making LOCK TABLES WRITE to wait until transactions that use the table to be locked are completed. Updated to the changed name of DEBUG_SYNC point. sql/handler.cc: Global read lock functionality has been moved into a class. sql/lock.cc: Global read lock functionality has been moved into a class. Updated code to use the new MDL API. sql/mdl.cc: Introduced new type-of-operation aware metadata locks. To do this: - Changed MDL_lock to use one list for waiting requests and one list for granted requests. For each list, added a bitmap that holds information what lock types a list contains. Added a helper class MDL_lock::List to manipulate with granted and waited lists while keeping the bitmaps in sync with list contents. - Changed lock-compatibility functions to use bitmaps that define compatibility. - Introduced a graph based deadlock detector inspired by waiting_threads.c from Maria implementation. - Now that we have a deadlock detector, and no longer have a global lock to protect individual lock objects, but rather use an rw lock per object, removed redundant code for upgrade, and the global read lock. Changed the MDL API to no longer require the caller to acquire the global intention exclusive lock by means of a separate method. Removed a few more methods that became redundant. - Removed deadlock detection heuristic, it has been made obsolete by the deadlock detector. - With operation-type-aware metadata locks, MDL subsystem has become aware of potential conflicts between DDL and open transactions. This made it possible to remove calls to mysql_abort_transactions_with_shared_lock() from acquisition paths for exclusive lock and lock upgrade. Now we can simply wait for these transactions to complete without fear of deadlock. Function mysql_lock_abort() has also become unnecessary for all conflicting cases except when a DDL conflicts with a connection that has an open HANDLER. sql/mdl.h: Introduced new type-of-operation aware metadata locks. Introduced a graph based deadlock detector and supporting methods. Added comments. God rid of redundant API calls. Renamed m_lt_or_ha_sentinel to m_trans_sentinel, since now it guards the global read lock as well as LOCK TABLES and HANDLER locks. sql/mysql_priv.h: Moved the global read lock functionality into a class. Added MYSQL_OPEN_FORCE_SHARED_MDL flag which forces open_tables() to take MDL_SHARED on tables instead of metadata locks specified in the parser. We use this to allow PREPARE run concurrently in presence of LOCK TABLES ... WRITE. Added signature for find_table_for_mdl_ugprade(). sql/set_var.cc: Global read lock functionality has been moved into a class. sql/sp_head.cc: When creating TABLE_LIST elements for prelocking or system tables set the type of request for metadata lock according to the operation that will be performed on the table. sql/sql_base.cc: - Updated code to use the new MDL API. - In order to avoid locks starvation we take upgradable locks all at once. As result implicitly locked tables no longer get an upgradable lock. Consequently DDL and FLUSH TABLES for such tables is prohibited. find_write_locked_table() was replaced by find_table_for_mdl_upgrade() function. open_table() was adjusted to return TABLE instance with upgradable ticket when necessary. - We no longer wait for all locks on OT_WAIT back off action -- only on the lock that caused the wait conflict. Moreover, now we distinguish cases when we have to wait due to conflict in MDL and old version of table in TDC. - Upate mysql_notify_threads_having_share_locks() to only abort thr_lock.c waits of threads that have open HANDLERs, since lock conflicts with only these threads now can lead to deadlocks not detectable by the MDL deadlock detector. - Remove mysql_abort_transactions_with_shared_locks() which is no longer needed. sql/sql_class.cc: Global read lock functionality has been moved into a class. Re-arranged code in THD::cleanup() to simplify assert. sql/sql_class.h: Introduced class to incapsulate global read lock functionality. Now sentinel in MDL subsystem guards the global read lock as well as LOCK TABLES and HANDLER locks. Adjusted code accordingly. sql/sql_db.cc: Global read lock functionality has been moved into a class. sql/sql_delete.cc: We no longer acquire upgradable metadata locks on tables which are locked by LOCK TABLES implicitly. As result TRUNCATE TABLE is no longer allowed for such tables. Updated code to use the new MDL API. sql/sql_handler.cc: Inform MDL_context about presence of open HANDLERs. Since HANLDERs break MDL protocol by acquiring table-level lock while holding only S metadata lock on a table MDL subsystem should take special care about such contexts (Now this is the only case when mysql_lock_abort() is used). sql/sql_parse.cc: Global read lock functionality has been moved into a class. Do not take upgradable metadata locks when opening tables for CREATE TABLE SELECT as it is not necessary and limits concurrency. When initializing TABLE_LIST objects before adding them to the table list set the type of request for metadata lock according to the operation that will be performed on the table. We no longer acquire upgradable metadata locks on tables which are locked by LOCK TABLES implicitly. As result FLUSH TABLES is no longer allowed for such tables. sql/sql_prepare.cc: Use MYSQL_OPEN_FORCE_SHARED_MDL flag when opening tables during PREPARE. This allows PREPARE to run concurrently in presence of LOCK TABLES ... WRITE. sql/sql_rename.cc: Global read lock functionality has been moved into a class. sql/sql_show.cc: Updated code to use the new MDL API. sql/sql_table.cc: Global read lock functionality has been moved into a class. We no longer acquire upgradable metadata locks on tables which are locked by LOCK TABLES implicitly. As result DROP TABLE is no longer allowed for such tables. Updated code to use the new MDL API. sql/sql_trigger.cc: Global read lock functionality has been moved into a class. We no longer acquire upgradable metadata locks on tables which are locked by LOCK TABLES implicitly. As result CREATE/DROP TRIGGER is no longer allowed for such tables. Updated code to use the new MDL API. sql/sql_view.cc: Global read lock functionality has been moved into a class. Fixed results of wrong merge that led to misuse of GLR API. CREATE VIEW statement is not a commit statement. sql/table.cc: When resetting TABLE_LIST objects for PS or SP re-execution set the type of request for metadata lock according to the operation that will be performed on the table. Do the same in auxiliary function initializing metadata lock requests in a table list. sql/table.h: When initializing TABLE_LIST objects set the type of request for metadata lock according to the operation that will be performed on the table. sql/transaction.cc: Global read lock functionality has been moved into a class.
472 lines
15 KiB
Text
472 lines
15 KiB
Text
drop table if exists t1,t2,t3;
|
|
CREATE TABLE t1 ( `id` int(11) NOT NULL default '0', `id2` int(11) NOT NULL default '0', `id3` int(11) NOT NULL default '0', `dummy1` char(30) default NULL, PRIMARY KEY (`id`,`id2`), KEY `index_id3` (`id3`)) ENGINE=MyISAM;
|
|
insert into t1 (id,id2) values (1,1),(1,2),(1,3);
|
|
LOCK TABLE t1 WRITE;
|
|
select dummy1,count(distinct id) from t1 group by dummy1;
|
|
dummy1 count(distinct id)
|
|
NULL 1
|
|
update t1 set id=-1 where id=1;
|
|
LOCK TABLE t1 READ;
|
|
update t1 set id=1 where id=1;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
create table t2 SELECT * from t1;
|
|
ERROR HY000: Table 't2' was not locked with LOCK TABLES
|
|
create temporary table t2 SELECT * from t1;
|
|
drop table if exists t2;
|
|
unlock tables;
|
|
create table t2 SELECT * from t1;
|
|
LOCK TABLE t1 WRITE,t2 write;
|
|
insert into t2 SELECT * from t1;
|
|
update t1 set id=1 where id=-1;
|
|
drop table t1,t2;
|
|
CREATE TABLE t1 (
|
|
index1 smallint(6) default NULL,
|
|
nr smallint(6) default NULL,
|
|
KEY index1(index1)
|
|
) ENGINE=MyISAM;
|
|
CREATE TABLE t2 (
|
|
nr smallint(6) default NULL,
|
|
name varchar(20) default NULL
|
|
) ENGINE=MyISAM;
|
|
INSERT INTO t2 VALUES (1,'item1');
|
|
INSERT INTO t2 VALUES (2,'item2');
|
|
lock tables t1 write, t2 read;
|
|
insert into t1 select 1,nr from t2 where name='item1';
|
|
insert into t1 select 2,nr from t2 where name='item2';
|
|
unlock tables;
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
lock tables t1 write;
|
|
check table t2;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 check Error Table 't2' was not locked with LOCK TABLES
|
|
test.t2 check status Operation failed
|
|
insert into t1 select index1,nr from t1;
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
|
unlock tables;
|
|
lock tables t1 write, t1 as t1_alias read;
|
|
insert into t1 select index1,nr from t1 as t1_alias;
|
|
drop table t1,t2;
|
|
ERROR HY000: Table 't2' was not locked with LOCK TABLES
|
|
unlock tables;
|
|
drop table t1,t2;
|
|
create table t1 (c1 int);
|
|
create table t2 (c1 int);
|
|
create table t3 (c1 int);
|
|
lock tables t1 write, t2 write, t3 write;
|
|
drop table t2, t3, t1;
|
|
create table t1 (c1 int);
|
|
create table t2 (c1 int);
|
|
create table t3 (c1 int);
|
|
lock tables t1 write, t2 write, t3 write, t1 as t4 read;
|
|
alter table t2 add column c2 int;
|
|
drop table t1, t2, t3;
|
|
create table t1 ( a int(11) not null auto_increment, primary key(a));
|
|
create table t2 ( a int(11) not null auto_increment, primary key(a));
|
|
lock tables t1 write, t2 read;
|
|
delete from t1 using t1,t2 where t1.a=t2.a;
|
|
delete t1 from t1,t2 where t1.a=t2.a;
|
|
delete from t2 using t1,t2 where t1.a=t2.a;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
delete t2 from t1,t2 where t1.a=t2.a;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
drop table t1,t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
unlock tables;
|
|
drop table t2,t1;
|
|
End of 4.1 tests.
|
|
drop table if exists t1;
|
|
create table t1 (a int);
|
|
lock table t1 write;
|
|
flush tables with read lock;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
unlock tables;
|
|
drop table t1;
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (i INT);
|
|
LOCK TABLES mysql.time_zone READ, mysql.proc READ, t1 READ;
|
|
UNLOCK TABLES;
|
|
LOCK TABLES mysql.time_zone READ, mysql.proc READ, t1 WRITE;
|
|
UNLOCK TABLES;
|
|
LOCK TABLES mysql.time_zone READ, mysql.proc READ;
|
|
UNLOCK TABLES;
|
|
LOCK TABLES mysql.time_zone WRITE, mysql.proc WRITE;
|
|
UNLOCK TABLES;
|
|
LOCK TABLES mysql.time_zone READ, mysql.proc WRITE, t1 READ;
|
|
ERROR HY000: You can't combine write-locking of system tables with other tables or lock types
|
|
LOCK TABLES mysql.time_zone WRITE, mysql.proc WRITE, t1 READ;
|
|
ERROR HY000: You can't combine write-locking of system tables with other tables or lock types
|
|
LOCK TABLES mysql.time_zone WRITE, mysql.proc WRITE, t1 WRITE;
|
|
ERROR HY000: You can't combine write-locking of system tables with other tables or lock types
|
|
LOCK TABLES mysql.time_zone READ, mysql.proc WRITE;
|
|
ERROR HY000: You can't combine write-locking of system tables with other tables or lock types
|
|
DROP TABLE t1;
|
|
|
|
Bug#5719 impossible to lock VIEW
|
|
|
|
Just covering existing behaviour with tests.
|
|
Consistency has not been found here.
|
|
|
|
drop view if exists v_bug5719;
|
|
drop table if exists t1, t2, t3;
|
|
create table t1 (a int);
|
|
create temporary table t2 (a int);
|
|
create table t3 (a int);
|
|
create view v_bug5719 as select 1;
|
|
lock table v_bug5719 write;
|
|
select * from t1;
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
|
|
|
Allowed to select from a temporary talbe under LOCK TABLES
|
|
|
|
select * from t2;
|
|
a
|
|
select * from t3;
|
|
ERROR HY000: Table 't3' was not locked with LOCK TABLES
|
|
select * from v_bug5719;
|
|
1
|
|
1
|
|
drop view v_bug5719;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
|
|
sic: did not left LOCK TABLES mode automatically
|
|
|
|
select * from t1;
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
|
unlock tables;
|
|
create or replace view v_bug5719 as select * from t1;
|
|
lock tables v_bug5719 write;
|
|
select * from v_bug5719;
|
|
a
|
|
|
|
Allowed to use an underlying table under LOCK TABLES <view>
|
|
|
|
select * from t1;
|
|
a
|
|
|
|
Allowed to select from a temporary table under LOCK TABLES
|
|
|
|
select * from t2;
|
|
a
|
|
select * from t3;
|
|
ERROR HY000: Table 't3' was not locked with LOCK TABLES
|
|
Dropping of implicitly locked table is disallowed.
|
|
drop table t1;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
unlock tables;
|
|
Now let us also lock table explicitly and drop it.
|
|
lock tables t1 write, v_bug5719 write;
|
|
drop table t1;
|
|
|
|
sic: left LOCK TABLES mode
|
|
|
|
select * from t3;
|
|
a
|
|
select * from v_bug5719;
|
|
ERROR HY000: View 'test.v_bug5719' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
|
|
unlock tables;
|
|
drop view v_bug5719;
|
|
|
|
When limitation to use temporary tables in views is removed, please
|
|
add a test that shows what happens under LOCK TABLES when a view
|
|
references a temporary table, is locked, and the underlying table
|
|
is dropped.
|
|
|
|
create view v_bug5719 as select * from t2;
|
|
ERROR HY000: View's SELECT refers to a temporary table 't2'
|
|
|
|
Cleanup.
|
|
|
|
drop table t2, t3;
|
|
#
|
|
# Bug#39843 DELETE requires write access to table in subquery in where clause
|
|
#
|
|
DROP TABLE IF EXISTS t1,t2;
|
|
CREATE TABLE t1 (
|
|
table1_rowid SMALLINT NOT NULL
|
|
);
|
|
CREATE TABLE t2 (
|
|
table2_rowid SMALLINT NOT NULL
|
|
);
|
|
INSERT INTO t1 VALUES (1);
|
|
INSERT INTO t2 VALUES (1);
|
|
LOCK TABLES t1 WRITE, t2 READ;
|
|
# Sub-select should not try to aquire a write lock.
|
|
DELETE FROM t1
|
|
WHERE EXISTS
|
|
(
|
|
SELECT 'x'
|
|
FROM t2
|
|
WHERE t1.table1_rowid = t2.table2_rowid
|
|
) ;
|
|
# While implementing the patch we didn't break old behavior;
|
|
# The following sub-select should still requires a write lock:
|
|
SELECT * FROM t1 WHERE 1 IN (SELECT * FROM t2 FOR UPDATE);
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1,t2;
|
|
End of 5.1 tests.
|
|
#
|
|
# Ensure that FLUSH TABLES doesn't substitute a base locked table
|
|
# with a temporary one.
|
|
#
|
|
drop table if exists t1, t2;
|
|
create table t1 (a int);
|
|
create table t2 (a int);
|
|
lock table t1 write, t2 write;
|
|
create temporary table t1 (a int);
|
|
flush table t1;
|
|
drop temporary table t1;
|
|
select * from t1;
|
|
a
|
|
unlock tables;
|
|
drop table t1, t2;
|
|
#
|
|
# Ensure that REPAIR .. USE_FRM works under LOCK TABLES.
|
|
#
|
|
drop table if exists t1, t2;
|
|
create table t1 (a int);
|
|
create table t2 (a int);
|
|
lock table t1 write, t2 write;
|
|
repair table t1 use_frm;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 repair status OK
|
|
repair table t1 use_frm;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 repair status OK
|
|
select * from t1;
|
|
a
|
|
select * from t2;
|
|
a
|
|
repair table t2 use_frm;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 repair status OK
|
|
repair table t2 use_frm;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 repair status OK
|
|
select * from t1;
|
|
a
|
|
unlock tables;
|
|
drop table t1, t2;
|
|
#
|
|
# Ensure that mi_copy_status is called for two instances
|
|
# of the same table when it is reopened after a flush.
|
|
#
|
|
drop table if exists t1;
|
|
drop view if exists v1;
|
|
create table t1 (c1 int);
|
|
create view v1 as select * from t1;
|
|
lock tables t1 write, v1 write;
|
|
flush table t1;
|
|
insert into t1 values (33);
|
|
flush table t1;
|
|
select * from t1;
|
|
c1
|
|
33
|
|
unlock tables;
|
|
drop table t1;
|
|
drop view v1;
|
|
#
|
|
# WL#4284: Transactional DDL locking
|
|
#
|
|
drop table if exists t1;
|
|
create table t1 (a int);
|
|
set autocommit= 0;
|
|
insert into t1 values (1);
|
|
lock table t1 write;
|
|
# Disconnect
|
|
# Ensure that metadata locks will be released if there is an open
|
|
# transaction (autocommit=off) in conjunction with lock tables.
|
|
drop table t1;
|
|
# Same problem but now for BEGIN
|
|
drop table if exists t1;
|
|
create table t1 (a int);
|
|
begin;
|
|
insert into t1 values (1);
|
|
# Disconnect
|
|
# Ensure that metadata locks held by the transaction are released.
|
|
drop table t1;
|
|
#
|
|
# Coverage for situations when we try to execute DDL on tables
|
|
# which are locked by LOCK TABLES only implicitly.
|
|
#
|
|
drop tables if exists t1, t2;
|
|
drop view if exists v1;
|
|
drop function if exists f1;
|
|
create table t1 (i int);
|
|
create table t2 (j int);
|
|
#
|
|
# Try to perform DDL on table which is locked through view.
|
|
create view v1 as select * from t2;
|
|
lock tables t1 write, v1 write;
|
|
flush table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
drop table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
alter table t2 add column k int;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
create trigger t2_bi before insert on t2 for each row set @a:=1;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
# Repair produces error as part of its result set.
|
|
repair table t2;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 repair Error Table 't2' was locked with a READ lock and can't be updated
|
|
test.t2 repair status Operation failed
|
|
unlock tables;
|
|
drop view v1;
|
|
#
|
|
# Now, try DDL on table which is locked through routine.
|
|
create function f1 () returns int
|
|
begin
|
|
insert into t2 values (1);
|
|
return 0;
|
|
end|
|
|
create view v1 as select f1() from t1;
|
|
lock tables v1 read;
|
|
flush table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
drop table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
alter table t2 add column k int;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
create trigger t2_bi before insert on t2 for each row set @a:=1;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
# Repair produces error as part of its result set.
|
|
repair table t2;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 repair Error Table 't2' was locked with a READ lock and can't be updated
|
|
test.t2 repair status Operation failed
|
|
unlock tables;
|
|
drop view v1;
|
|
drop function f1;
|
|
#
|
|
# Finally, try DDL on table which is locked thanks to trigger.
|
|
create trigger t1_ai after insert on t1 for each row insert into t2 values (1);
|
|
lock tables t1 write;
|
|
flush table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
drop table t2;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
alter table t2 add column k int;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
create trigger t2_bi before insert on t2 for each row set @a:=1;
|
|
ERROR HY000: Table 't2' was locked with a READ lock and can't be updated
|
|
# Repair produces error as part of its result set.
|
|
repair table t2;
|
|
Table Op Msg_type Msg_text
|
|
test.t2 repair Error Table 't2' was locked with a READ lock and can't be updated
|
|
test.t2 repair status Operation failed
|
|
unlock tables;
|
|
drop trigger t1_ai;
|
|
drop tables t1, t2;
|
|
#
|
|
# Bug#45035 " Altering table under LOCK TABLES results in
|
|
# "Error 1213 Deadlock found..."
|
|
#
|
|
# When reopening tables under LOCK TABLES after ALTER TABLE,
|
|
# 6.0 used to be taking thr_lock locks one by one, and
|
|
# that would lead to a lock conflict.
|
|
# Check that taking all locks at once works.
|
|
#
|
|
drop table if exists t1;
|
|
create table t1 (i int);
|
|
lock tables t1 write, t1 as a read, t1 as b read;
|
|
alter table t1 add column j int;
|
|
unlock tables;
|
|
drop table t1;
|
|
create temporary table t1 (i int);
|
|
#
|
|
# This is just for test coverage purposes,
|
|
# when this is allowed, remove the --error.
|
|
#
|
|
lock tables t1 write, t1 as a read, t1 as b read;
|
|
ERROR HY000: Can't reopen table: 't1'
|
|
alter table t1 add column j int;
|
|
unlock tables;
|
|
drop table t1;
|
|
#
|
|
# Separate case for partitioned tables is important
|
|
# because each partition has an own thr_lock object.
|
|
#
|
|
create table t1 (i int) partition by list (i)
|
|
(partition p0 values in (1),
|
|
partition p1 values in (2,3),
|
|
partition p2 values in (4,5));
|
|
lock tables t1 write, t1 as a read, t1 as b read;
|
|
alter table t1 add column j int;
|
|
unlock tables;
|
|
drop table t1;
|
|
#
|
|
# Bug #43272 HANDLER SQL command does not work under LOCK TABLES
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (a INT);
|
|
LOCK TABLE t1 WRITE;
|
|
# HANDLER commands are not allowed in LOCK TABLES mode
|
|
HANDLER t1 OPEN;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
HANDLER t1 READ FIRST;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
HANDLER t1 CLOSE;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
#
|
|
# Bug#45066 FLUSH TABLES WITH READ LOCK deadlocks against
|
|
# LOCK TABLE
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1(a INT);
|
|
LOCK TABLE t1 READ;
|
|
FLUSH TABLES;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
LOCK TABLE t1 WRITE;
|
|
FLUSH TABLES;
|
|
#
|
|
# If you allow the next combination, you reintroduce bug Bug#45066
|
|
#
|
|
LOCK TABLE t1 READ;
|
|
FLUSH TABLES WITH READ LOCK;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
LOCK TABLE t1 WRITE;
|
|
FLUSH TABLES WITH READ LOCK;
|
|
ERROR HY000: Can't execute the given command because you have active locked tables or an active transaction
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
#
|
|
# Simplified test for bug #48538 "Assertion in thr_lock() on LOAD DATA
|
|
# CONCURRENT INFILE".
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (f1 INT, f2 INT) ENGINE = MEMORY;
|
|
CREATE TRIGGER t1_ai AFTER INSERT ON t1 FOR EACH ROW
|
|
UPDATE LOW_PRIORITY t1 SET f2 = 7;
|
|
# Statement below should fail with ER_CANT_UPDATE_USED_TABLE_IN_SF_OR_TRG
|
|
# error instead of failing on assertion in table-level locking subsystem.
|
|
INSERT INTO t1(f1) VALUES(0);
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
DROP TABLE t1;
|
|
#
|
|
# Bug#43685 Lock table affects other non-related tables
|
|
#
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
CREATE TABLE t1 (id INT);
|
|
CREATE TABLE t2 (id INT);
|
|
# Connection default
|
|
LOCK TABLE t1 WRITE;
|
|
ANALYZE TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 analyze status Table is already up to date
|
|
# Connection con2
|
|
LOCK TABLE t2 WRITE;
|
|
# This used to hang until the first connection
|
|
# unlocked t1.
|
|
FLUSH TABLE t2;
|
|
UNLOCK TABLES;
|
|
# Connection default
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1, t2;
|
|
#
|
|
# End of 6.0 tests.
|
|
#
|