mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 18:41:56 +01:00
f317d3a6fb
strict aliasing violations. Another rather noisy violation of strict aliasing rules is the spatial code which makes use of stack-based memory (of type Geometry_buffer) to provide placement for Geometry objects. Although a placement new is allowed to dynamically change the type of a object, the object returned by the new placement was being ignored and the original stack-based object was being casted to the new type, thus violating strict aliasing rules. The solution is to reorganize the code so that the object returned by the new placement is used instead of casting the original object. Also, to ensure that the stack-based object is properly aligned with respect to the objects it provides placement for, a set of compiler-dependent macros and types are introduced so that the alignment of objects can be inquired and specified. include/Makefile.am: Add new header. include/my_compiler.h: Add new header. include/my_global.h: Remove now-unnecessary macros. sql/spatial.cc: Make object creation functions return the object whose type was dynamically changed by the new placement. Move static method from the header in order to avoid having to access a forward declaration. sql/spatial.h: Object creation callbacks now take a array of chars as the storage area. Move create_by_typeid to a source file as to not access the forward declaration of Geometry_buffer. Ensure that Geometry_buffer is properly aligned. sql/sql_show.cc: Use newly added aligned storage helper.
69 lines
2.5 KiB
Makefile
69 lines
2.5 KiB
Makefile
# Copyright (C) 2000-2006 MySQL AB
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Library General Public
|
|
# License as published by the Free Software Foundation; version 2
|
|
# of the License.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Library General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Library General Public
|
|
# License along with this library; if not, write to the Free
|
|
# Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
|
|
# MA 02111-1307, USA
|
|
|
|
BUILT_SOURCES = $(HEADERS_GEN_MAKE) link_sources
|
|
HEADERS_GEN_CONFIGURE = mysql_version.h
|
|
HEADERS_GEN_MAKE = my_config.h
|
|
HEADERS_ABI = mysql.h mysql_com.h mysql_time.h \
|
|
my_list.h my_alloc.h typelib.h mysql/plugin.h
|
|
pkginclude_HEADERS = $(HEADERS_ABI) my_dbug.h m_string.h my_sys.h \
|
|
my_xml.h mysql_embed.h \
|
|
my_pthread.h my_no_pthread.h \
|
|
decimal.h errmsg.h my_global.h my_net.h \
|
|
my_getopt.h sslopt-longopts.h my_dir.h \
|
|
sslopt-vars.h sslopt-case.h sql_common.h keycache.h \
|
|
m_ctype.h my_attribute.h $(HEADERS_GEN_CONFIGURE) \
|
|
$(HEADERS_GEN_MAKE)
|
|
|
|
noinst_HEADERS = config-win.h config-netware.h my_bit.h \
|
|
heap.h my_bitmap.h my_uctype.h \
|
|
myisam.h myisampack.h myisammrg.h ft_global.h\
|
|
mysys_err.h my_base.h help_start.h help_end.h \
|
|
my_nosys.h my_alarm.h queues.h rijndael.h sha1.h \
|
|
my_aes.h my_tree.h my_trie.h hash.h thr_alarm.h \
|
|
thr_lock.h t_ctype.h violite.h my_md5.h base64.h \
|
|
my_handler.h my_time.h my_vle.h my_user.h \
|
|
my_libwrap.h my_stacktrace.h my_compiler.h
|
|
|
|
EXTRA_DIST = mysql.h.pp mysql/plugin.h.pp
|
|
|
|
# Remove built files and the symlinked directories
|
|
CLEANFILES = $(BUILT_SOURCES) readline openssl
|
|
|
|
|
|
# Some include files that may be moved and patched by configure
|
|
DISTCLEANFILES = sched.h $(CLEANFILES) $(HEADERS_GEN_CONFIGURE)
|
|
|
|
link_sources:
|
|
-$(RM) -f readline openssl
|
|
@readline_h_ln_cmd@
|
|
@yassl_h_ln_cmd@
|
|
echo timestamp > link_sources
|
|
|
|
# We want both "my_config.h" and "config.h" that are identical, as
|
|
# MySQL sources assumes the name "my_config.h", and 3rd party sources
|
|
# assumes the name "config.h".
|
|
my_config.h: config.h
|
|
$(CP) config.h my_config.h
|
|
|
|
# These files should not be included in distributions since they are
|
|
# generated by configure from the .h.in files
|
|
dist-hook:
|
|
$(RM) -f $(distdir)/mysql_version.h $(distdir)/my_config.h
|
|
|
|
# Don't update the files from bitkeeper
|
|
%::SCCS/s.%
|