mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 21:42:35 +01:00
8b1609a637
duplicate key entries on slave" (two concurrrent connections doing multi-row INSERT DELAYED to insert into an auto_increment column, caused replication slave to stop with "duplicate key error" (and binlog was wrong)), and BUG#26116 "If multi-row INSERT DELAYED has errors, statement-based binlogging breaks" (the binlog was not accounting for all rows inserted, or slave could stop). The fix is that: if (statement-based) binlogging is on, a multi-row INSERT DELAYED is silently converted to a non-delayed INSERT. Note: it is not possible to test BUG#25507 in 5.0 (requires mysqlslap), so it is tested only in the changeset for 5.1. However, BUG#26116 is tested here, and the fix for BUG#25507 is the same code change.
67 lines
1.9 KiB
Text
67 lines
1.9 KiB
Text
--source include/master-slave.inc
|
|
--source include/not_embedded.inc
|
|
--source include/not_windows.inc
|
|
|
|
connection master;
|
|
|
|
let $binlog_format_statement=1;
|
|
|
|
CREATE TABLE t1 (id INT primary key auto_increment, name VARCHAR(64));
|
|
|
|
sync_slave_with_master;
|
|
|
|
#
|
|
# BUG#26116 "If multi-row INSERT DELAYED has errors,
|
|
# statement-based binlogging breaks";
|
|
# happened only in statement-based binlogging.
|
|
#
|
|
|
|
connection master;
|
|
truncate table t1;
|
|
# first scenario: duplicate on first row
|
|
insert delayed into t1 values(10, "my name");
|
|
if ($binlog_format_statement)
|
|
{
|
|
# statement below will be converted to non-delayed INSERT and so
|
|
# will stop at first error, guaranteeing replication.
|
|
--error ER_DUP_ENTRY
|
|
insert delayed into t1 values(10, "is Bond"), (20, "James Bond");
|
|
}
|
|
if (!$binlog_format_statement)
|
|
{
|
|
insert delayed into t1 values(10, "is Bond"), (20, "James Bond");
|
|
}
|
|
flush table t1; # to wait for INSERT DELAYED to be done
|
|
select * from t1;
|
|
sync_slave_with_master;
|
|
# when bug existed in statement-based binlogging, t1 on slave had
|
|
# different content from on master
|
|
select * from t1;
|
|
|
|
# second scenario: duplicate on second row
|
|
connection master;
|
|
delete from t1 where id!=10;
|
|
if ($binlog_format_statement)
|
|
{
|
|
# statement below will be converted to non-delayed INSERT and so
|
|
# will be binlogged with its ER_DUP_ENTRY error code, guaranteeing
|
|
# replication (slave will hit the same error code and so be fine).
|
|
--error ER_DUP_ENTRY
|
|
insert delayed into t1 values(20, "is Bond"), (10, "James Bond");
|
|
}
|
|
if (!$binlog_format_statement)
|
|
{
|
|
insert delayed into t1 values(20, "is Bond"), (10, "James Bond");
|
|
}
|
|
flush table t1; # to wait for INSERT DELAYED to be done
|
|
select * from t1;
|
|
sync_slave_with_master;
|
|
# when bug existed in statement-based binlogging, query was binlogged
|
|
# with error_code=0 so slave stopped
|
|
select * from t1;
|
|
|
|
# clean up
|
|
connection master;
|
|
drop table t1;
|
|
sync_slave_with_master;
|
|
connection master;
|