mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
8b8b28881f
numbers) Before this patch, the code in the class Log_to_csv_event_handler, which is used by the global LOGGER object to write to the tables mysql.slow_log and mysql_general_log, was supporting only records of the format defined for these tables in the database creation scripts. Also before this patch, the server would allow, with certain limitations, to perform ALTER TABLE on the LOG TABLES. As implemented, the behavior of the server, with regards to LOG TABLES, is inconsistent: - either ALTER TABLES on LOG TABLES should be prohibited, and the code writing to these tables can make assumptions on the record format, - or ALTER TABLE on LOG TABLES is permitted, in which case the code writing a record to these tables should be more flexible and honor new fields. In particular, adding an AUTO_INCREMENT column to the logs, does not work as expected (per the bug report). Given that the ALTER TABLE on log tables statement has been explicitly implemented to check that the log should be off to perform the operation, and that current test cases already cover this, the user expectation is already set that this is a "feature" and should be supported. With this patch, the server will: - populate AUTO INCREMENT columns if present, - populate any additional column with it's default value when writing a record to the LOG TABLES. Tests are provided, that detail the precise sequence of statements a SUPER user might want to perform to add more columns to the log tables. mysql-test/r/log_tables.result: Test case for bug#27857 mysql-test/t/log_tables.test: Test case for bug#27857 sql/log.cc: Set extra fields in log tables with default values.
477 lines
12 KiB
Text
477 lines
12 KiB
Text
# this test needs multithreaded mysqltest
|
|
-- source include/not_embedded.inc
|
|
#
|
|
# Basic log tables test
|
|
#
|
|
|
|
# check that CSV engine was compiled in
|
|
--source include/have_csv.inc
|
|
|
|
--disable_ps_protocol
|
|
use mysql;
|
|
|
|
#
|
|
# Check that log tables work and we can do basic selects. This also
|
|
# tests truncate, which works in a special mode with the log tables
|
|
#
|
|
|
|
truncate table general_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from general_log;
|
|
truncate table slow_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST
|
|
select * from slow_log;
|
|
|
|
#
|
|
# We want to check that a record newly written to a log table shows up for
|
|
# the query: since log tables use concurrent insert machinery and log tables
|
|
# are always locked by artificial THD, this feature requires additional
|
|
# check in ha_tina::write_row. This simple test should prove that the
|
|
# log table flag in the table handler is triggered and working.
|
|
#
|
|
|
|
truncate table general_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from general_log where argument like '%general_log%';
|
|
|
|
|
|
#
|
|
# Check some basic queries interfering with the log tables.
|
|
# In our test we'll use a tbale with verbose comments to the short
|
|
# command type names, used in the tables
|
|
#
|
|
|
|
create table join_test (verbose_comment varchar (80), command_type varchar(64));
|
|
|
|
insert into join_test values ("User performed a usual SQL query", "Query");
|
|
insert into join_test values ("New DB connection was registered", "Connect");
|
|
insert into join_test values ("Get the table info", "Field List");
|
|
|
|
--replace_column 2 USER_HOST
|
|
select verbose_comment, user_host, argument
|
|
from mysql.general_log join join_test
|
|
on (mysql.general_log.command_type = join_test.command_type);
|
|
|
|
drop table join_test;
|
|
|
|
#
|
|
# check that flush of the log table work fine
|
|
#
|
|
|
|
flush logs;
|
|
|
|
#
|
|
# check locking of the log tables
|
|
#
|
|
|
|
--error ER_CANT_WRITE_LOCK_LOG_TABLE
|
|
lock tables mysql.general_log WRITE;
|
|
|
|
--error ER_CANT_WRITE_LOCK_LOG_TABLE
|
|
lock tables mysql.slow_log WRITE;
|
|
|
|
#
|
|
# This attemts to get TL_READ_NO_INSERT lock, which is incompatible with
|
|
# TL_WRITE_CONCURRENT_INSERT. This should fail. We issue this error as log
|
|
# tables are always opened and locked by the logger.
|
|
#
|
|
|
|
--error ER_CANT_READ_LOCK_LOG_TABLE
|
|
lock tables mysql.general_log READ;
|
|
|
|
--error ER_CANT_READ_LOCK_LOG_TABLE
|
|
lock tables mysql.slow_log READ;
|
|
|
|
#
|
|
# This call should result in TL_READ lock on the log table. This is ok and
|
|
# should pass.
|
|
#
|
|
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
|
|
unlock tables;
|
|
|
|
#
|
|
# check that FLUSH LOGS waits for all readers of the log table to vanish
|
|
#
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
connection con1;
|
|
|
|
lock tables mysql.general_log READ LOCAL;
|
|
|
|
connection con2;
|
|
|
|
# this should wait for log tables to unlock
|
|
send flush logs;
|
|
|
|
connection con1;
|
|
|
|
unlock tables;
|
|
|
|
# this connection should be alive by the time
|
|
connection con2;
|
|
|
|
reap;
|
|
|
|
select "Mark that we woke up from flush logs in the test"
|
|
as "test passed";
|
|
|
|
#
|
|
# perform the same check for TRUNCATE: it should also wait for readers
|
|
# to disappear
|
|
#
|
|
|
|
connection con1;
|
|
|
|
lock tables mysql.general_log READ LOCAL;
|
|
|
|
connection con2;
|
|
|
|
# this should wait for log tables to unlock
|
|
send truncate mysql.general_log;
|
|
|
|
connection con1;
|
|
|
|
unlock tables;
|
|
|
|
# this connection should be alive by the time
|
|
connection con2;
|
|
|
|
reap;
|
|
|
|
select "Mark that we woke up from TRUNCATE in the test"
|
|
as "test passed";
|
|
|
|
connection con1;
|
|
|
|
use test;
|
|
|
|
#
|
|
# Bug #16905 Log tables: unicode statements are logged incorrectly
|
|
#
|
|
|
|
truncate table mysql.general_log;
|
|
set names utf8;
|
|
create table bug16905 (s char(15) character set utf8 default 'пусто');
|
|
insert into bug16905 values ('новое');
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from mysql.general_log;
|
|
drop table bug16905;
|
|
|
|
#
|
|
# Bug #17600: Invalid data logged into mysql.slow_log
|
|
#
|
|
|
|
truncate table mysql.slow_log;
|
|
set session long_query_time=1;
|
|
select sleep(2);
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 QUERY_TIME
|
|
select * from mysql.slow_log;
|
|
|
|
#
|
|
# Bug #18559 log tables cannot change engine, and gets deadlocked when
|
|
# dropping w/ log on
|
|
#
|
|
|
|
# check that appropriate error messages are given when one attempts to alter
|
|
# or drop a log tables, while corresponding logs are enabled
|
|
--error ER_BAD_LOG_STATEMENT
|
|
alter table mysql.general_log engine=myisam;
|
|
--error ER_BAD_LOG_STATEMENT
|
|
alter table mysql.slow_log engine=myisam;
|
|
|
|
--error ER_BAD_LOG_STATEMENT
|
|
drop table mysql.general_log;
|
|
--error ER_BAD_LOG_STATEMENT
|
|
drop table mysql.slow_log;
|
|
|
|
# check that one can alter log tables to MyISAM
|
|
set global general_log='OFF';
|
|
|
|
# cannot convert another log table
|
|
--error ER_BAD_LOG_STATEMENT
|
|
alter table mysql.slow_log engine=myisam;
|
|
|
|
# alter both tables
|
|
set global slow_query_log='OFF';
|
|
# check that both tables use CSV engine
|
|
show create table mysql.general_log;
|
|
show create table mysql.slow_log;
|
|
|
|
alter table mysql.general_log engine=myisam;
|
|
alter table mysql.slow_log engine=myisam;
|
|
|
|
# check that the tables were converted
|
|
show create table mysql.general_log;
|
|
show create table mysql.slow_log;
|
|
|
|
# enable log tables and chek that new tables indeed work
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from mysql.general_log;
|
|
|
|
# check that flush of myisam-based log tables work fine
|
|
flush logs;
|
|
|
|
# check locking of myisam-based log tables
|
|
|
|
--error ER_CANT_WRITE_LOCK_LOG_TABLE
|
|
lock tables mysql.general_log WRITE;
|
|
|
|
--error ER_CANT_WRITE_LOCK_LOG_TABLE
|
|
lock tables mysql.slow_log WRITE;
|
|
|
|
#
|
|
# This attemts to get TL_READ_NO_INSERT lock, which is incompatible with
|
|
# TL_WRITE_CONCURRENT_INSERT. This should fail. We issue this error as log
|
|
# tables are always opened and locked by the logger.
|
|
#
|
|
|
|
--error ER_CANT_READ_LOCK_LOG_TABLE
|
|
lock tables mysql.general_log READ;
|
|
|
|
--error ER_CANT_READ_LOCK_LOG_TABLE
|
|
lock tables mysql.slow_log READ;
|
|
|
|
#
|
|
# This call should result in TL_READ lock on the log table. This is ok and
|
|
# should pass.
|
|
#
|
|
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
|
|
unlock tables;
|
|
|
|
# check that we can drop them
|
|
set global general_log='OFF';
|
|
set global slow_query_log='OFF';
|
|
|
|
# check that alter table doesn't work for other engines
|
|
set @save_storage_engine= @@session.storage_engine;
|
|
set storage_engine= MEMORY;
|
|
--error ER_UNSUPORTED_LOG_ENGINE
|
|
alter table mysql.slow_log engine=ndb;
|
|
--error ER_UNSUPORTED_LOG_ENGINE
|
|
alter table mysql.slow_log engine=innodb;
|
|
--error ER_UNSUPORTED_LOG_ENGINE
|
|
alter table mysql.slow_log engine=archive;
|
|
--error ER_UNSUPORTED_LOG_ENGINE
|
|
alter table mysql.slow_log engine=blackhole;
|
|
set storage_engine= @save_storage_engine;
|
|
|
|
drop table mysql.slow_log;
|
|
drop table mysql.general_log;
|
|
|
|
# check that table share cleanup is performed correctly (double drop)
|
|
|
|
--error ER_BAD_TABLE_ERROR
|
|
drop table mysql.general_log;
|
|
--error ER_BAD_TABLE_ERROR
|
|
drop table mysql.slow_log;
|
|
|
|
# recreate tables and enable logs
|
|
|
|
use mysql;
|
|
|
|
CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='General log';
|
|
|
|
CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='Slow log';
|
|
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
use test;
|
|
|
|
#
|
|
# Bug #20139 Infinite loop after "FLUSH" and "LOCK tabX, general_log"
|
|
#
|
|
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
use mysql;
|
|
lock tables general_log read local, help_category read local;
|
|
unlock tables;
|
|
|
|
#
|
|
# Bug #17544 Cannot do atomic log rotate and
|
|
# Bug #21785 Server crashes after rename of the log table
|
|
#
|
|
|
|
use mysql;
|
|
# Should result in error
|
|
--error ER_CANT_RENAME_LOG_TABLE
|
|
RENAME TABLE general_log TO renamed_general_log;
|
|
--error ER_CANT_RENAME_LOG_TABLE
|
|
RENAME TABLE slow_log TO renamed_slow_log;
|
|
|
|
#check rotate logs
|
|
truncate table general_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from general_log;
|
|
|
|
truncate table slow_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST
|
|
select * from slow_log;
|
|
|
|
create table general_log_new like general_log;
|
|
rename table general_log TO renamed_general_log, general_log_new TO general_log;
|
|
|
|
create table slow_log_new like slow_log;
|
|
rename table slow_log TO renamed_slow_log, slow_log_new TO slow_log;
|
|
|
|
# check that rename checks more then first table in the list
|
|
--error ER_CANT_RENAME_LOG_TABLE
|
|
rename table general_log TO general_log_new, renamed_general_log TO general_log, slow_log to renamed_slow_log;
|
|
|
|
# now check the content of tables
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from general_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST 3 THREAD_ID
|
|
select * from renamed_general_log;
|
|
|
|
# the content of the slow log is empty, but we will try a select anyway
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST
|
|
select * from slow_log;
|
|
--replace_column 1 TIMESTAMP 2 USER_HOST
|
|
select * from renamed_slow_log;
|
|
|
|
# check that we can do whatever we want with disabled log
|
|
set global general_log='OFF';
|
|
RENAME TABLE general_log TO general_log2;
|
|
|
|
set global slow_query_log='OFF';
|
|
RENAME TABLE slow_log TO slow_log2;
|
|
|
|
# this should fail
|
|
--error ER_CANT_ACTIVATE_LOG
|
|
set global general_log='ON';
|
|
--error ER_CANT_ACTIVATE_LOG
|
|
set global slow_query_log='ON';
|
|
|
|
RENAME TABLE general_log2 TO general_log;
|
|
RENAME TABLE slow_log2 TO slow_log;
|
|
|
|
# this should work
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
# now check flush logs
|
|
flush logs;
|
|
flush logs;
|
|
drop table renamed_general_log, renamed_slow_log;
|
|
use test;
|
|
|
|
#
|
|
# Bug #21966 Strange warnings on repair of the log tables
|
|
#
|
|
|
|
use mysql;
|
|
# check that no warning occurs on repair of the log tables
|
|
repair table general_log;
|
|
repair table slow_log;
|
|
# check that no warning occurs on "create like" for the log tables
|
|
create table general_log_new like general_log;
|
|
create table slow_log_new like slow_log;
|
|
show tables like "%log%";
|
|
drop table slow_log_new, general_log_new;
|
|
use test;
|
|
|
|
#
|
|
# Bug#27857 (Log tables supplies the wrong value for generating
|
|
# AUTO_INCREMENT numbers)
|
|
#
|
|
|
|
SET GLOBAL LOG_OUTPUT = 'TABLE';
|
|
|
|
## test the general log
|
|
|
|
SET GLOBAL general_log = 0;
|
|
FLUSH LOGS;
|
|
|
|
TRUNCATE TABLE mysql.general_log;
|
|
ALTER TABLE mysql.general_log ENGINE = MyISAM;
|
|
ALTER TABLE mysql.general_log
|
|
ADD COLUMN seq BIGINT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY;
|
|
|
|
SET GLOBAL general_log = 1;
|
|
FLUSH LOGS;
|
|
|
|
--replace_column 1 EVENT_TIME 2 USER_HOST 3 THREAD_ID 4 SERVER_ID
|
|
SELECT * FROM mysql.general_log;
|
|
--replace_column 1 EVENT_TIME 2 USER_HOST 3 THREAD_ID 4 SERVER_ID
|
|
SELECT * FROM mysql.general_log;
|
|
SELECT "My own query 1";
|
|
SELECT "My own query 2";
|
|
--replace_column 1 EVENT_TIME 2 USER_HOST 3 THREAD_ID 4 SERVER_ID
|
|
SELECT * FROM mysql.general_log;
|
|
|
|
SET GLOBAL general_log = 0;
|
|
FLUSH LOGS;
|
|
|
|
ALTER TABLE mysql.general_log DROP COLUMN seq;
|
|
ALTER TABLE mysql.general_log ENGINE = CSV;
|
|
|
|
## test the slow query log
|
|
|
|
SET @old_long_query_time:=@@long_query_time;
|
|
|
|
SET GLOBAL slow_query_log = 0;
|
|
FLUSH LOGS;
|
|
|
|
TRUNCATE TABLE mysql.slow_log;
|
|
ALTER TABLE mysql.slow_log ENGINE = MyISAM;
|
|
|
|
ALTER TABLE mysql.slow_log
|
|
ADD COLUMN seq BIGINT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY;
|
|
|
|
SET SESSION long_query_time = 1;
|
|
SET GLOBAL slow_query_log = 1;
|
|
FLUSH LOGS;
|
|
|
|
## FLUSH LOGS above might be slow, so the following is
|
|
## logged as either seq 1-4 or seq 2-5
|
|
SELECT "My own slow query", sleep(2);
|
|
SELECT "My own slow query", sleep(2);
|
|
SELECT "My own slow query", sleep(2);
|
|
SELECT "My own slow query", sleep(2);
|
|
|
|
## So we look for seq 2-4
|
|
--replace_column 1 START_TIME 2 USER_HOST 3 QUERY_TIME
|
|
SELECT * FROM mysql.slow_log WHERE seq >= 2 LIMIT 3;
|
|
|
|
SET GLOBAL slow_query_log = 0;
|
|
SET SESSION long_query_time =@old_long_query_time;
|
|
FLUSH LOGS;
|
|
|
|
ALTER TABLE mysql.slow_log DROP COLUMN seq;
|
|
ALTER TABLE mysql.slow_log ENGINE = CSV;
|
|
|
|
# kill all connections
|
|
disconnect con1;
|
|
disconnect con2;
|
|
--enable_ps_protocol
|
|
|