mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
54e2e70194
In commit 91599701d0 (MDEV-25312)
some recovery code for TRUNCATE TABLE was broken
causing a regression in a case where undo log for a RENAME TABLE
operation had been durably written but the tablespace had not been
renamed yet.
row_rename_table_for_mysql(): Add a DEBUG_SYNC point for the
test case, and simplify the logic and trim the error messages.
fil_space_t::rename(): Simplify the operation. Merge the necessary
part of fil_rename_tablespace_check(). If there is no change to
the file name, do nothing.
dict_table_t::rename_tablespace(): Refactored from
dict_table_rename_in_cache().
row_undo_ins_parse_undo_rec(): On rolling back TRX_UNDO_RENAME_TABLE,
invoke dict_table_t::rename_tablespace() even if the table name matches.
os_file_rename_func(): Temporarily relax an assertion that would
fail during the recovery in the test innodb.truncate_crash.
93 lines
2.9 KiB
Text
93 lines
2.9 KiB
Text
--echo #
|
|
--echo # Show what happens during ALTER TABLE when an existing file
|
|
--echo # exists in the target location.
|
|
--echo #
|
|
--echo # Bug #19218794: IF TABLESPACE EXISTS, CAN'T CREATE TABLE,
|
|
--echo # BUT CAN ALTER ENGINE=INNODB
|
|
--echo #
|
|
|
|
--source include/have_innodb.inc
|
|
|
|
--disable_query_log
|
|
LET $MYSQLD_DATADIR = `select @@datadir`;
|
|
SET @old_innodb_file_per_table = @@innodb_file_per_table;
|
|
--enable_query_log
|
|
|
|
CREATE TABLE t1 (a SERIAL, b CHAR(10)) ENGINE=Memory;
|
|
INSERT INTO t1(b) VALUES('one'), ('two'), ('three');
|
|
|
|
--echo #
|
|
--echo # Create a file called MYSQLD_DATADIR/test/t1.ibd
|
|
--exec echo "This is not t1.ibd" > $MYSQLD_DATADIR/test/t1.ibd
|
|
|
|
--echo # Directory listing of test/*.ibd
|
|
--echo #
|
|
--list_files $MYSQLD_DATADIR/test/ *.ibd
|
|
|
|
--replace_regex /Error on rename of '.*' to '.*'/Error on rename of 'OLD_FILE_NAME' to 'NEW_FILE_NAME'/
|
|
--error ER_ERROR_ON_RENAME
|
|
ALTER TABLE t1 ENGINE = InnoDB;
|
|
|
|
--echo #
|
|
--echo # Move the file to InnoDB as t2
|
|
--echo #
|
|
ALTER TABLE t1 RENAME TO t2, ENGINE = INNODB;
|
|
SHOW CREATE TABLE t2;
|
|
SELECT * from t2;
|
|
|
|
--replace_regex /Error on rename of '.*' to '.*'/Error on rename of 'OLD_FILE_NAME' to 'NEW_FILE_NAME'/
|
|
--error ER_ERROR_ON_RENAME
|
|
ALTER TABLE t2 RENAME TO t1;
|
|
|
|
--echo #
|
|
--echo # Create another t1, but in the system tablespace.
|
|
--echo #
|
|
SET GLOBAL innodb_file_per_table=OFF;
|
|
CREATE TABLE t1 (a SERIAL, b CHAR(20)) ENGINE=InnoDB;
|
|
INSERT INTO t1(b) VALUES('one'), ('two'), ('three');
|
|
SHOW CREATE TABLE t1;
|
|
SELECT name, space=0 FROM information_schema.innodb_sys_tables WHERE name = 'test/t1';
|
|
|
|
--echo #
|
|
--echo # ALTER TABLE from system tablespace to system tablespace
|
|
--echo #
|
|
ALTER TABLE t1 ADD COLUMN c INT, ALGORITHM=INPLACE;
|
|
ALTER TABLE t1 ADD COLUMN d INT, ALGORITHM=COPY;
|
|
|
|
--echo #
|
|
--echo # Try to move t1 from the system tablespace to a file-per-table
|
|
--echo # while a blocking t1.ibd file exists.
|
|
--echo #
|
|
SET GLOBAL innodb_file_per_table=ON;
|
|
--replace_regex /#sql-ib[1-9][0-9]*/#sql-ib/
|
|
--error ER_TABLESPACE_EXISTS
|
|
ALTER TABLE t1 FORCE, ALGORITHM=INPLACE;
|
|
--replace_regex /Error on rename of '.*' to '.*'/Error on rename of 'OLD_FILE_NAME' to 'NEW_FILE_NAME'/
|
|
--error ER_ERROR_ON_RENAME
|
|
ALTER TABLE t1 FORCE, ALGORITHM=COPY;
|
|
|
|
--echo #
|
|
--echo # Delete the blocking file called MYSQLD_DATADIR/test/t1.ibd
|
|
--remove_file $MYSQLD_DATADIR/test/t1.ibd
|
|
|
|
--echo # Move t1 to file-per-table using ALGORITHM=INPLACE with no blocking t1.ibd.
|
|
--echo #
|
|
ALTER TABLE t1 FORCE, ALGORITHM=INPLACE;
|
|
SHOW CREATE TABLE t1;
|
|
SELECT name, space=0 FROM information_schema.innodb_sys_tables WHERE name = 'test/t1';
|
|
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # Rename t2.ibd to t1.ibd.
|
|
--echo #
|
|
ALTER TABLE t2 RENAME TO t1;
|
|
SELECT name, space=0 FROM information_schema.innodb_sys_tables WHERE name = 'test/t1';
|
|
SELECT * from t1;
|
|
|
|
DROP TABLE t1;
|
|
|
|
--disable_query_log
|
|
call mtr.add_suppression("\\[ERROR\\] InnoDB: Cannot rename '.*' to '.*' because the target file exists");
|
|
SET GLOBAL innodb_file_per_table = @old_innodb_file_per_table;
|
|
--enable_query_log
|