mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
96a51b7f39
without PK Bug#31609 Not all RBR slave errors reported as errors bug#32468 delete rows event on a table with foreign key constraint fails The first two bugs comprise idempotency issues. First, there was no error code reported under conditions of the bug description although the slave sql thread halted. Second, executions were different with and without presence of prim key in the table. Third, there was no way to instruct the slave whether to ignore an error and skip to the following event or to halt. Fourth, there are handler errors which might happen due to idempotent applying of binlog but those were not listed among the "idempotent" error list. All the named issues are addressed. Wrt to the 3rd, there is the new global system variable, changeble at run time, which controls the slave sql thread behaviour. The new variable allows further extensions to mimic the sql_mode session/global variable. To address the 4th, the new bug#32468 had to be fixed as it was staying in the way. include/my_bitmap.h: basic operations with bits of an integer type are added. mysql-test/extra/rpl_tests/rpl_foreign_key.test: regression test for bug#32468 mysql-test/extra/rpl_tests/rpl_row_basic.test: changes due to bug#31552/31609 idempotency is not default any longer mysql-test/extra/rpl_tests/rpl_row_tabledefs.test: changes due to bug#31552/31609 idempotency is not default any longer mysql-test/suite/rpl/r/rpl_foreign_key_innodb.result: results changed mysql-test/suite/rpl/r/rpl_idempotency.result: results changed mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result: results changed mysql-test/suite/rpl/r/rpl_row_basic_2myisam.result: results changed mysql-test/suite/rpl/r/rpl_row_basic_3innodb.result: results changed mysql-test/suite/rpl/r/rpl_row_mystery22.result: results changed mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result: results changed mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result: results changed mysql-test/suite/rpl/r/rpl_temporary_errors.result: results changed mysql-test/suite/rpl/t/rpl_idempotency.test: extenstions to the test providing testing of complements to the idempotent error set and checking how slave halts when it faces an error from the list when the mode is STRICT. mysql-test/suite/rpl/t/rpl_row_basic_11bugs.test: changes due to bug#31552/31609 idempotency is not default any longer. mysql-test/suite/rpl/t/rpl_row_mystery22.test: changes due to bug#31552/31609 idempotency is not default any longer mysql-test/suite/rpl/t/rpl_temporary_errors.test: changes due to bug#31552/31609 idempotency is not default any longer mysql-test/suite/rpl_ndb/r/rpl_ndb_dd_advance.result: results changed mysql-test/suite/rpl_ndb/r/rpl_row_basic_7ndb.result: results changed sql/log_event.cc: the fix for bug#32468 delete rows event on a table with foreign key constraint fails ensures the flags are set at proper time so that their values will be caught by innodb. reseting the flags is done along the common error and errorless execution path. The list of idempotent error is extended with foreign keys related items. NDB engine write events are designed with the replace sematics in mind. Therefore the corrsponding ndb handler's flag are (re)set regardless of the slave's execution mode. Rows_log_event::write_row() starts using the bool replace argument as its caller sets it depending on the event's execution mode. sql/log_event.h: adding a new member to hold the slave's mode during execution of the event. sql/mysql_priv.h: changes to link the command line option with the new global sys var. sql/mysqld.cc: introduction of the new command line option. providing its initialization to a default. changes to link the command line option with the new global sys var. sql/rpl_rli.cc: rli post-event-execution cleanup restores the default bits. sql/set_var.cc: The new "standard" sys_var_set class' and the new global system var related declarations and definitions. fix_slave_exec_mode() is used as with the update method of a new class so as at time of the command line arguments parsing. sql/set_var.h: new declarations. The class for the new global sys var is based on yet another new "standard" one. sql/share/errmsg.txt: slave_exec_mode setting error; slave inconsistency error which may be not an error when the intention is "idempotent". I.e consisting of row-based events binlog is being applied for the 2nd (more) time. sql/sql_class.h: The names for the bits of the new sever slave_exec_mode_options. mysql-test/suite/rpl/t/rpl_idempotency-master.opt: innodb is necessary mysql-test/suite/rpl/t/rpl_idempotency-slave.opt: innodb is necessary, as well as the tests start with non-default IDEMPOTENT slave execution mode.
226 lines
5 KiB
Text
226 lines
5 KiB
Text
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
CREATE TABLE t1 (a INT PRIMARY KEY);
|
|
CREATE TABLE t2 (a INT);
|
|
INSERT INTO t1 VALUES (-1),(-2),(-3);
|
|
INSERT INTO t2 VALUES (-1),(-2),(-3);
|
|
DELETE FROM t1 WHERE a = -2;
|
|
DELETE FROM t2 WHERE a = -2;
|
|
DELETE FROM t1 WHERE a = -2;
|
|
DELETE FROM t2 WHERE a = -2;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-1
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a
|
|
-3
|
|
-1
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-1
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a
|
|
-3
|
|
-1
|
|
Last_SQL_Error
|
|
0
|
|
INSERT IGNORE INTO t1 VALUES (-2);
|
|
INSERT IGNORE INTO t1 VALUES (-2);
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-2
|
|
-1
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-2
|
|
-1
|
|
Last_SQL_Error
|
|
0
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-2
|
|
1
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a
|
|
-3
|
|
1
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
-3
|
|
-2
|
|
1
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a
|
|
-3
|
|
1
|
|
Last_SQL_Error
|
|
0
|
|
DROP TABLE t1, t2;
|
|
select @@global.slave_exec_mode /* must be IDEMPOTENT */;
|
|
@@global.slave_exec_mode
|
|
IDEMPOTENT
|
|
create table ti1 (b int primary key) engine = innodb;
|
|
create table ti2 (a int primary key, b int, foreign key (b) references ti1(b))
|
|
engine = innodb;
|
|
set foreign_key_checks=1 /* ensure the check */;
|
|
insert into ti1 values (1),(2),(3);
|
|
insert into ti2 set a=2, b=2;
|
|
select * from ti1 order by b /* must be (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
insert into ti2 set a=1, b=1;
|
|
select * from ti2 order by b /* must be (1,1) (2,2) */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
set @save_binlog_format= @@session.binlog_format;
|
|
set @@session.binlog_format= row;
|
|
delete from ti1 where b=1;
|
|
select * from ti1 order by b /* must be (2),(3) */;
|
|
b
|
|
2
|
|
3
|
|
select * from ti1 order by b /* must stays as were on master (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
delete from ti1 where b=3;
|
|
insert into ti2 set a=3, b=3;
|
|
select * from ti2 order by b /* must be (1,1),(2,2) - not inserted */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
set global slave_exec_mode='STRICT';
|
|
set global slave_exec_mode='IDEMPOTENT,STRICT';
|
|
ERROR HY000: Ambiguous slave modes combination.
|
|
select @@global.slave_exec_mode /* must be STRICT */;
|
|
@@global.slave_exec_mode
|
|
STRICT
|
|
*** foreign keys errors as above now forces to stop
|
|
set foreign_key_checks=0;
|
|
drop table ti2, ti1;
|
|
create table ti1 (b int primary key) engine = innodb;
|
|
create table ti2 (a int primary key, b int, foreign key (b) references ti1(b))
|
|
engine = innodb;
|
|
set foreign_key_checks=1 /* ensure the check */;
|
|
insert into ti1 values (1),(2),(3);
|
|
insert into ti2 set a=2, b=2;
|
|
select * from ti1 order by b /* must be (1),(2),(3) */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
*** conspire future problem
|
|
insert into ti2 set a=1, b=1;
|
|
select * from ti2 order by b /* must be (1,1) (2,2) */;
|
|
a b
|
|
1 1
|
|
2 2
|
|
delete from ti1 where b=1 /* offending delete event */;
|
|
select * from ti1 order by b /* must be (2),(3) */;
|
|
b
|
|
2
|
|
3
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
0
|
|
select * from ti1 order by b /* must be (1),(2),(3) - not deleted */;
|
|
b
|
|
1
|
|
2
|
|
3
|
|
set foreign_key_checks= 0;
|
|
delete from ti2 where b=1;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
*** conspire the following insert failure
|
|
*** conspire future problem
|
|
delete from ti1 where b=3;
|
|
insert into ti2 set a=3, b=3 /* offending write event */;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
1452
|
|
select * from ti2 order by b /* must be (2,2) */;
|
|
a b
|
|
2 2
|
|
set foreign_key_checks= 0;
|
|
insert into ti1 set b=3;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
select * from ti2 order by b /* must be (2,2),(3,3) */;
|
|
a b
|
|
2 2
|
|
3 3
|
|
*** other errors
|
|
*** conspiring query
|
|
insert into ti1 set b=1;
|
|
insert into ti1 set b=1 /* offending write event */;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
1062
|
|
set foreign_key_checks= 0;
|
|
delete from ti1 where b=1;
|
|
set foreign_key_checks= 1;
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
CREATE TABLE t1 (a INT PRIMARY KEY);
|
|
CREATE TABLE t2 (a INT);
|
|
INSERT INTO t1 VALUES (-1),(-2),(-3);
|
|
INSERT INTO t2 VALUES (-1),(-2),(-3);
|
|
DELETE FROM t1 WHERE a = -2;
|
|
DELETE FROM t2 WHERE a = -2;
|
|
DELETE FROM t1 WHERE a = -2;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
DELETE FROM t2 WHERE a = -2;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
0
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
UPDATE t1 SET a = 1 WHERE a = -1;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
1032
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
UPDATE t2 SET a = 1 WHERE a = -1;
|
|
*** slave must stop
|
|
Last_SQL_Error
|
|
0
|
|
set global slave_exec_mode='IDEMPOTENT';
|
|
start slave sql_thread;
|
|
set global slave_exec_mode='STRICT';
|
|
set @@session.binlog_format= @save_binlog_format;
|
|
drop table t1,t2,ti2,ti1;
|
|
*** end of tests
|