mariadb/sql/wsrep_thd.h
Jan Lindström 224c950462 MDEV-23101 : SIGSEGV in lock_rec_unlock() when Galera is enabled
Remove incorrect BF (brute force) handling from lock_rec_has_to_wait_in_queue
and move condition to correct callers. Add a function to report
BF lock waits and assert if incorrect BF-BF lock wait happens.

wsrep_report_bf_lock_wait
	Add a new function to report BF lock wait.

wsrep_assert_no_bf_bf_wait
	Add a new function to check do we have a
	BF-BF wait and if we have report this case
	and assert as it is a bug.

lock_rec_has_to_wait
	Use new wsrep_assert_bf_wait to check BF-BF wait.

lock_rec_create_low
lock_table_create
	Use new function to report BF lock waits.

lock_rec_insert_by_trx_age
lock_grant_and_move_on_page
lock_grant_and_move_on_rec
	Assert that trx is not Galera as VATS is not compatible
	with Galera.

lock_rec_add_to_queue
	If there is conflicting lock in a queue make sure that
	transaction is BF.

lock_rec_has_to_wait_in_queue
	Remove incorrect BF handling. If there is conflicting
	locks in a queue all transactions must wait.

lock_rec_dequeue_from_page
lock_rec_unlock
	If there is conflicting lock make sure it is not
	BF-BF case.

lock_rec_queue_validate
	Add Galera record locking rules comment and use
	new function to report BF lock waits.

All attempts to reproduce the original assertion have been
failed. Therefore, there is no test case on this commit.
2020-09-10 13:18:12 +03:00

302 lines
9.4 KiB
C++

/* Copyright (C) 2013 Codership Oy <info@codership.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License along
with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA. */
#ifndef WSREP_THD_H
#define WSREP_THD_H
#include <my_config.h>
#include "mysql/service_wsrep.h"
#include "wsrep/client_state.hpp"
#include "sql_class.h"
#include "wsrep_utils.h"
#include <deque>
class Wsrep_thd_queue
{
public:
Wsrep_thd_queue(THD* t) : thd(t)
{
mysql_mutex_init(key_LOCK_wsrep_thd_queue,
&LOCK_wsrep_thd_queue,
MY_MUTEX_INIT_FAST);
mysql_cond_init(key_COND_wsrep_thd_queue, &COND_wsrep_thd_queue, NULL);
}
~Wsrep_thd_queue()
{
mysql_mutex_destroy(&LOCK_wsrep_thd_queue);
mysql_cond_destroy(&COND_wsrep_thd_queue);
}
bool push_back(THD* thd)
{
DBUG_ASSERT(thd);
wsp::auto_lock lock(&LOCK_wsrep_thd_queue);
std::deque<THD*>::iterator it = queue.begin();
while (it != queue.end())
{
if (*it == thd)
{
return true;
}
it++;
}
queue.push_back(thd);
mysql_cond_signal(&COND_wsrep_thd_queue);
return false;
}
THD* pop_front()
{
wsp::auto_lock lock(&LOCK_wsrep_thd_queue);
while (queue.empty())
{
if (thd->killed != NOT_KILLED)
return NULL;
thd->mysys_var->current_mutex= &LOCK_wsrep_thd_queue;
thd->mysys_var->current_cond= &COND_wsrep_thd_queue;
mysql_cond_wait(&COND_wsrep_thd_queue, &LOCK_wsrep_thd_queue);
thd->mysys_var->current_mutex= 0;
thd->mysys_var->current_cond= 0;
}
THD* ret= queue.front();
queue.pop_front();
return ret;
}
private:
THD* thd;
std::deque<THD*> queue;
mysql_mutex_t LOCK_wsrep_thd_queue;
mysql_cond_t COND_wsrep_thd_queue;
};
int wsrep_show_bf_aborts (THD *thd, SHOW_VAR *var, char *buff,
enum enum_var_type scope);
bool wsrep_create_appliers(long threads, bool mutex_protected=false);
void wsrep_create_rollbacker();
bool wsrep_bf_abort(const THD*, THD*);
int wsrep_abort_thd(THD *bf_thd_ptr, THD *victim_thd_ptr, my_bool signal);
extern void wsrep_thd_set_PA_safe(void *thd_ptr, my_bool safe);
/*
Helper methods to deal with thread local storage.
The purpose of these methods is to hide the details of thread
local storage handling when operating with wsrep storage access
and streaming applier THDs
With one-thread-per-connection thread handling thread specific
variables are allocated when the thread is started and deallocated
before thread exits (my_thread_init(), my_thread_end()). However,
with pool-of-threads thread handling new thread specific variables
are allocated for each THD separately (see threadpool_add_connection()),
and the variables in thread local storage are assigned from
currently active thread (see thread_attach()). This must be taken into
account when storing/resetting thread local storage and when creating
streaming applier THDs.
*/
/**
Create new variables for thread local storage. With
one-thread-per-connection thread handling this is a no op,
with pool-of-threads new variables are created via my_thread_init().
It is assumed that the caller has called wsrep_reset_threadvars() to clear
the thread local storage before this call.
@return Zero in case of success, non-zero otherwise.
*/
int wsrep_create_threadvars();
/**
Delete variables which were created by wsrep_create_threadvars().
The caller must store variables into thread local storage before
this call via wsrep_store_threadvars().
*/
void wsrep_delete_threadvars();
/**
Assign variables from current thread local storage into THD.
This should be called for THDs whose lifetime is limited to single
thread execution or which may share the operation context with some
parent THD (e.g. storage access) and thus don't require separately
allocated globals.
With one-thread-per-connection thread handling this is a no-op,
with pool-of-threads the variables which are currently stored into
thread local storage are assigned to THD.
*/
void wsrep_assign_from_threadvars(THD *);
/**
Helper struct to save variables from thread local storage.
*/
struct Wsrep_threadvars
{
THD* cur_thd;
st_my_thread_var* mysys_var;
};
/**
Save variables from thread local storage into Wsrep_threadvars struct.
*/
Wsrep_threadvars wsrep_save_threadvars();
/**
Restore variables into thread local storage from Wsrep_threadvars struct.
*/
void wsrep_restore_threadvars(const Wsrep_threadvars&);
/**
Store variables into thread local storage.
*/
void wsrep_store_threadvars(THD *);
/**
Reset thread local storage.
*/
void wsrep_reset_threadvars(THD *);
/**
Helper functions to override error status
In many contexts it is desirable to mask the original error status
set for THD or it is necessary to change OK status to error.
This function implements the common logic for the most
of the cases.
Rules:
* If the diagnostics are has OK or EOF status, override it unconditionally
* If the error is either ER_ERROR_DURING_COMMIT or ER_LOCK_DEADLOCK
it is usually the correct error status to be returned to client,
so don't override those by default
*/
static inline void wsrep_override_error(THD *thd, uint error)
{
DBUG_ASSERT(error != ER_ERROR_DURING_COMMIT);
Diagnostics_area *da= thd->get_stmt_da();
if (da->is_ok() ||
da->is_eof() ||
!da->is_set() ||
(da->is_error() &&
da->sql_errno() != error &&
da->sql_errno() != ER_ERROR_DURING_COMMIT &&
da->sql_errno() != ER_LOCK_DEADLOCK))
{
da->reset_diagnostics_area();
my_error(error, MYF(0));
}
}
/**
Override error with additional wsrep status.
*/
static inline void wsrep_override_error(THD *thd, uint error,
enum wsrep::provider::status status)
{
Diagnostics_area *da= thd->get_stmt_da();
if (da->is_ok() ||
!da->is_set() ||
(da->is_error() &&
da->sql_errno() != error &&
da->sql_errno() != ER_ERROR_DURING_COMMIT &&
da->sql_errno() != ER_LOCK_DEADLOCK))
{
da->reset_diagnostics_area();
my_error(error, MYF(0), status);
}
}
static inline void wsrep_override_error(THD* thd,
wsrep::client_error ce,
enum wsrep::provider::status status)
{
DBUG_ASSERT(ce != wsrep::e_success);
switch (ce)
{
case wsrep::e_error_during_commit:
wsrep_override_error(thd, ER_ERROR_DURING_COMMIT, status);
break;
case wsrep::e_deadlock_error:
wsrep_override_error(thd, ER_LOCK_DEADLOCK);
break;
case wsrep::e_interrupted_error:
wsrep_override_error(thd, ER_QUERY_INTERRUPTED);
break;
case wsrep::e_size_exceeded_error:
wsrep_override_error(thd, ER_ERROR_DURING_COMMIT, status);
break;
case wsrep::e_append_fragment_error:
/* TODO: Figure out better error number */
wsrep_override_error(thd, ER_ERROR_DURING_COMMIT, status);
break;
case wsrep::e_not_supported_error:
wsrep_override_error(thd, ER_NOT_SUPPORTED_YET);
break;
case wsrep::e_timeout_error:
wsrep_override_error(thd, ER_LOCK_WAIT_TIMEOUT);
break;
default:
wsrep_override_error(thd, ER_UNKNOWN_ERROR);
break;
}
}
/**
Helper function to log THD wsrep context.
@param thd Pointer to THD
@param message Optional message
@param function Function where the call was made from
*/
static inline void wsrep_log_thd(const THD *thd,
const char *message,
const char *function)
{
WSREP_DEBUG("%s %s\n"
" thd: %llu thd_ptr: %p client_mode: %s client_state: %s trx_state: %s\n"
" next_trx_id: %lld trx_id: %lld seqno: %lld\n"
" is_streaming: %d fragments: %zu\n"
" sql_errno: %u message: %s\n"
#define WSREP_THD_LOG_QUERIES
#ifdef WSREP_THD_LOG_QUERIES
" command: %d query: %.72s"
#endif /* WSREP_OBSERVER_LOG_QUERIES */
,
function,
message ? message : "",
thd->thread_id,
thd,
wsrep_thd_client_mode_str(thd),
wsrep_thd_client_state_str(thd),
wsrep_thd_transaction_state_str(thd),
(long long)thd->wsrep_next_trx_id(),
(long long)thd->wsrep_trx_id(),
(long long)wsrep_thd_trx_seqno(thd),
thd->wsrep_trx().is_streaming(),
thd->wsrep_sr().fragments().size(),
(thd->get_stmt_da()->is_error() ? thd->get_stmt_da()->sql_errno() : 0),
(thd->get_stmt_da()->is_error() ? thd->get_stmt_da()->message() : "")
#ifdef WSREP_THD_LOG_QUERIES
, thd->lex->sql_command,
WSREP_QUERY(thd)
#endif /* WSREP_OBSERVER_LOG_QUERIES */
);
}
#define WSREP_LOG_THD(thd_, message_) wsrep_log_thd(thd_, message_, __FUNCTION__)
#endif /* WSREP_THD_H */