mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
5a759d31f7
Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char*) to (char*) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."*' is not anymore same as table_name.* - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)
53 lines
1.7 KiB
C
53 lines
1.7 KiB
C
#ifndef DATADICT_INCLUDED
|
|
#define DATADICT_INCLUDED
|
|
/* Copyright (c) 2010, Oracle and/or its affiliates.
|
|
Copyright (c) 2017 MariaDB corporation.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
#include "handler.h"
|
|
|
|
/*
|
|
Data dictionary API.
|
|
*/
|
|
|
|
enum Table_type
|
|
{
|
|
TABLE_TYPE_UNKNOWN,
|
|
TABLE_TYPE_NORMAL, /* Normal table */
|
|
TABLE_TYPE_SEQUENCE,
|
|
TABLE_TYPE_VIEW
|
|
};
|
|
|
|
/*
|
|
Take extra care when using dd_frm_type() - it only checks the .frm file,
|
|
and it won't work for any engine that supports discovery.
|
|
|
|
Prefer to use ha_table_exists() instead.
|
|
To check whether it's an frm of a view, use dd_frm_is_view().
|
|
*/
|
|
|
|
enum Table_type dd_frm_type(THD *thd, char *path, LEX_CSTRING *engine_name,
|
|
bool *is_sequence);
|
|
|
|
static inline bool dd_frm_is_view(THD *thd, char *path)
|
|
{
|
|
bool not_used2;
|
|
return dd_frm_type(thd, path, NULL, ¬_used2) == TABLE_TYPE_VIEW;
|
|
}
|
|
|
|
bool dd_recreate_table(THD *thd, const char *db, const char *table_name,
|
|
const char *path = NULL);
|
|
|
|
#endif // DATADICT_INCLUDED
|