mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
f45601ce58
The C optimizer may decide that data access operations through pointer of different type are not related to the original data (strict aliasing). This is what happens in fetch_long_with_conversion(), when called as part of mysql_stmt_fetch() : it tries to check for truncation errors by first storing float (and other types of data) into a char * buffer and then accesses them through a float pointer. This is done to prevent the effects of excess precision when using FPU registers. However the doublestore() macro converts a double pointer to an union pointer. This violates the strict aliasing rule. Fixed by making the intermediary variables volatile ( to not re-introduce the excess precision bug) and using the intermediary value instead of the char * buffer. Note that there can be loss of precision for both signed and unsigned 64 bit integers converted to double and back, so the check must stay there (even for compatibility reasons). Based on the excellent analysis in bug 28400. |
||
|---|---|---|
| .. | ||
| .cvsignore | ||
| acinclude.m4 | ||
| client_settings.h | ||
| CMakeLists.txt | ||
| conf_to_src.c | ||
| dll.c | ||
| errmsg.c | ||
| get_password.c | ||
| libmysql.c | ||
| libmysql.def | ||
| libmysql.ver.in | ||
| Makefile.am | ||
| Makefile.shared | ||
| manager.c | ||
| mytest.c | ||