mirror of
https://github.com/MariaDB/server.git
synced 2025-02-01 03:21:53 +01:00
6b5c4a9ef6
on Windows". On platforms where read-write lock implementation does not prefer readers by default (Windows, Solaris) server might have deadlocked while detecting MDL deadlock. MDL deadlock detector relies on the fact that read-write locks which are used in its implementation prefer readers (see new comment for MDL_lock::m_rwlock for details). So far MDL code assumed that default implementation of read/write locks for the system has this property. Indeed, this turned out ot be wrong, for example, for Windows or Solaris. Thus MDL deadlock detector might have deadlocked on these systems. This fix simply adds portable implementation of read/write lock which prefer readers and changes MDL code to use this new type of synchronization primitive. No test case is added as existing rqg_mdl_stability test can serve as one. config.h.cmake: Check for presence of pthread_rwlockattr_setkind_np to be able to determine if system natively supports read-write locks for which we can specify if readers or writers should be preferred. configure.cmake: Check for presence of pthread_rwlockattr_setkind_np to be able to determine if system natively supports read-write locks for which we can specify if readers or writers should be preferred. configure.in: Check for presence of pthread_rwlockattr_setkind_np to be able to determine if system natively supports read-write locks for which we can specify if readers or writers should be preferred. include/my_pthread.h: Added support for portable read-write locks which prefer readers. To do so extended existing my_rw_lock_t implementation to support selection of whom to prefer depending on a flag. mysys/thr_rwlock.c: Extended existing my_rw_lock_t implementation to support selection of whom to prefer depending on a flag. Added rw_pr_init() function implementing initialization of read-write locks preferring readers. sql/mdl.cc: Use portable read-write locks which prefer readers instead of relying on that system implementation of read-write locks has this property (this was true for Linux/NPTL but was false, for example, for Windows and Solaris). Added comment explaining why preferring readers is important for MDL deadlock detector (thanks to Serg for example!). sql/mdl.h: Use portable read-write locks which prefer readers instead of relying on that system implementation of read-write locks has this property (this was true for Linux/NPTL but was false, for example, for Windows and Solaris). |
||
|---|---|---|
| .. | ||
| atomic | ||
| mysql | ||
| base64.h | ||
| CMakeLists.txt | ||
| config-netware.h | ||
| config-win.h | ||
| decimal.h | ||
| errmsg.h | ||
| ft_global.h | ||
| hash.h | ||
| heap.h | ||
| help_end.h | ||
| help_start.h | ||
| keycache.h | ||
| lf.h | ||
| m_ctype.h | ||
| m_string.h | ||
| Makefile.am | ||
| my_aes.h | ||
| my_alarm.h | ||
| my_alloc.h | ||
| my_atomic.h | ||
| my_attribute.h | ||
| my_base.h | ||
| my_bit.h | ||
| my_bitmap.h | ||
| my_dbug.h | ||
| my_dir.h | ||
| my_getopt.h | ||
| my_global.h | ||
| my_handler.h | ||
| my_libwrap.h | ||
| my_list.h | ||
| my_md5.h | ||
| my_net.h | ||
| my_no_pthread.h | ||
| my_nosys.h | ||
| my_pthread.h | ||
| my_rdtsc.h | ||
| my_stacktrace.h | ||
| my_sys.h | ||
| my_time.h | ||
| my_tree.h | ||
| my_trie.h | ||
| my_uctype.h | ||
| my_user.h | ||
| my_vle.h | ||
| my_xml.h | ||
| myisam.h | ||
| myisammrg.h | ||
| myisampack.h | ||
| mysql.h | ||
| mysql.h.pp | ||
| mysql_com.h | ||
| mysql_embed.h | ||
| mysql_time.h | ||
| mysql_version.h.in | ||
| mysys_err.h | ||
| probes_mysql.d.base | ||
| probes_mysql.h | ||
| probes_mysql_nodtrace.h | ||
| queues.h | ||
| rijndael.h | ||
| service_versions.h | ||
| sha1.h | ||
| sql_common.h | ||
| sslopt-case.h | ||
| sslopt-longopts.h | ||
| sslopt-vars.h | ||
| t_ctype.h | ||
| thr_alarm.h | ||
| thr_lock.h | ||
| typelib.h | ||
| violite.h | ||