mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
7be4bc4e55
The following is an excerption from the WL.
1. Change so that MIXED is default format
1.1 to change the default for command line --binlog-format
1.2 to alter global_system_variables.binlog_format calculation
basing on command line --binlog-format parameter and
its default.
2. Change test suite so that more testing is done by MIXED format.
2.1 to check if there are test cases requiring --binlog-foramt=statement via
`source include/have_binlog_format_statement.inc' and affected by
altering the latter to be "mixed".
2.2 to check the content of such vulnerable cases to find if
extending to the mixed does not modify results. In that case simply
substitute source arguments as explained.
2.3 if a test in mixed mode deals with features triggering
row-binlogging then if necessary we can switch explicitly
to statement mode or create another test to run with
non-recommended STATEMENT mode
Particullarily, extracting INSERT DELAYED
binlogging subtest for statement mode is performed, and
the snippet is moved into a separate test file.
Note that since now all three modes verify this use case
through 3 different tests.
No changes in item 3 of HLD appeared to be needed.
35 lines
1.1 KiB
Text
35 lines
1.1 KiB
Text
# Testcase for BUG#4551
|
|
# The bug was that when the table was TEMPORARY, it was not deleted if
|
|
# the CREATE SELECT failed (the code intended too, but it actually
|
|
# didn't). And as the CREATE TEMPORARY TABLE was not written to the
|
|
# binlog if it was a transactional table, it resulted in an
|
|
# inconsistency between binlog and the internal list of temp tables.
|
|
|
|
# This does not work for RBR yet.
|
|
--source include/have_binlog_format_mixed_or_statement.inc
|
|
|
|
-- source include/have_innodb.inc
|
|
--disable_warnings
|
|
drop table if exists t1, t2;
|
|
--enable_warnings
|
|
CREATE TABLE t1 ( a int );
|
|
INSERT INTO t1 VALUES (1),(2),(1);
|
|
--error 1062
|
|
CREATE TABLE t2 ( PRIMARY KEY (a) ) ENGINE=INNODB SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error 1062
|
|
CREATE TEMPORARY TABLE t2 ( PRIMARY KEY (a) ) ENGINE=INNODB SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error 1062
|
|
CREATE TABLE t2 ( PRIMARY KEY (a) ) ENGINE=MYISAM SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error 1062
|
|
CREATE TEMPORARY TABLE t2 ( PRIMARY KEY (a) ) ENGINE=MYISAM SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
drop table t1;
|
|
|
|
# End of 4.1 tests
|