mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
142 lines
4.9 KiB
C++
142 lines
4.9 KiB
C++
// TABOCCUR.H Olivier Bertrand 2013
|
|
// Defines the OCCUR tables
|
|
|
|
#include "tabutil.h"
|
|
|
|
typedef class OCCURDEF *POCCURDEF;
|
|
typedef class TDBOCCUR *PTDBOCCUR;
|
|
typedef class OCCURCOL *POCCURCOL;
|
|
typedef class RANKCOL *PRANKCOL;
|
|
|
|
/* -------------------------- OCCUR classes -------------------------- */
|
|
|
|
/***********************************************************************/
|
|
/* OCCUR: Table that provides a view of a source table where the */
|
|
/* contain of several columns of the source table is placed in only */
|
|
/* one column, the OCCUR column, this resulting into several rows. */
|
|
/***********************************************************************/
|
|
|
|
/***********************************************************************/
|
|
/* OCCUR table. */
|
|
/***********************************************************************/
|
|
class OCCURDEF : public PRXDEF { /* Logical table description */
|
|
friend class TDBOCCUR;
|
|
public:
|
|
// Constructor
|
|
OCCURDEF(void) {Pseudo = 3; Colist = Xcol = NULL;}
|
|
|
|
// Implementation
|
|
virtual const char *GetType(void) {return "OCCUR";}
|
|
|
|
// Methods
|
|
virtual bool DefineAM(PGLOBAL g, LPCSTR am, int poff);
|
|
virtual PTDB GetTable(PGLOBAL g, MODE m);
|
|
|
|
protected:
|
|
// Members
|
|
char *Colist; /* The source column list */
|
|
char *Xcol; /* The multiple occurence column */
|
|
char *Rcol; /* The rank column */
|
|
}; // end of OCCURDEF
|
|
|
|
/***********************************************************************/
|
|
/* This is the class declaration for the OCCUR table. */
|
|
/***********************************************************************/
|
|
class TDBOCCUR : public TDBPRX {
|
|
friend class OCCURCOL;
|
|
friend class RANKCOL;
|
|
public:
|
|
// Constructor
|
|
TDBOCCUR(POCCURDEF tdp);
|
|
|
|
// Implementation
|
|
virtual AMT GetAmType(void) {return TYPE_AM_OCCUR;}
|
|
void SetTdbp(PTDBASE tdbp) {Tdbp = tdbp;}
|
|
|
|
// Methods
|
|
virtual void ResetDB(void) {N = 0; Tdbp->ResetDB();}
|
|
virtual int RowNumber(PGLOBAL g, bool b = FALSE);
|
|
bool MakeColumnList(PGLOBAL g);
|
|
bool ViewColumnList(PGLOBAL g);
|
|
|
|
// Database routines
|
|
virtual PCOL MakeCol(PGLOBAL g, PCOLDEF cdp, PCOL cprec, int n);
|
|
virtual bool InitTable(PGLOBAL g);
|
|
virtual int GetMaxSize(PGLOBAL g);
|
|
virtual bool OpenDB(PGLOBAL g);
|
|
virtual int ReadDB(PGLOBAL g);
|
|
|
|
protected:
|
|
// Members
|
|
LPCSTR Tabname; // Name of source table
|
|
char *Colist; // Source column list
|
|
char *Xcolumn; // Occurence column name
|
|
char *Rcolumn; // Rank column name
|
|
POCCURCOL Xcolp; // To the OCCURCOL column
|
|
PCOL *Col; // To source multiple columns
|
|
int Mult; // Multiplication factor
|
|
int N; // The current table index
|
|
int M; // The occurence rank
|
|
BYTE RowFlag; // 0: Ok, 1: Same, 2: Skip
|
|
}; // end of class TDBOCCUR
|
|
|
|
/***********************************************************************/
|
|
/* Class OCCURCOL: for the multiple occurence column. */
|
|
/***********************************************************************/
|
|
class OCCURCOL : public COLBLK {
|
|
public:
|
|
// Constructors
|
|
OCCURCOL(PCOLDEF cdp, PTDBOCCUR tdbp, int n);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_OCCUR;}
|
|
int GetI(void) {return I;}
|
|
|
|
// Methods
|
|
virtual void Reset(void) {} // Evaluated only by TDBOCCUR
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
void Xreset(void) {I = 0;};
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
OCCURCOL(void) = default;
|
|
|
|
// Members
|
|
int I;
|
|
}; // end of class OCCURCOL
|
|
|
|
/***********************************************************************/
|
|
/* Class RANKCOL: for the multiple occurence column ranking. */
|
|
/***********************************************************************/
|
|
class RANKCOL : public COLBLK {
|
|
public:
|
|
// Constructors
|
|
RANKCOL(PCOLDEF cdp, PTDBOCCUR tdbp, int n) : COLBLK(cdp, tdbp, n) {}
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_OCCUR;}
|
|
|
|
// Methods
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
RANKCOL(void) = default;
|
|
|
|
// Members
|
|
}; // end of class RANKCOL
|
|
|
|
/***********************************************************************/
|
|
/* Definition of class XCOLDEF. */
|
|
/* This class purpose is just to access COLDEF protected items! */
|
|
/***********************************************************************/
|
|
class XCOLDEF: public COLDEF {
|
|
friend class TDBOCCUR;
|
|
}; // end of class XCOLDEF
|
|
|
|
|
|
bool OcrColumns(PGLOBAL g, PQRYRES qrp, const char *col,
|
|
const char *ocr, const char *rank);
|
|
|
|
bool OcrSrcCols(PGLOBAL g, PQRYRES qrp, const char *col,
|
|
const char *ocr, const char *rank);
|