mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 18:20:07 +01:00
d09aec7a15
Shorten some VARCHAR attributes to a more reasonable length. INNODB_METRICS: Rename the column STATUS to ENABLED, and make it Boolean. Replace with INT(1) many Boolean attributes that were declared as VARCHAR containing 'NO','YES','disabled','enabled','Uninitialized','Initialized'. Replace some VARCHAR attributes with ENUM. Replace some BIGINT with INT when 32 bits are sufficient. Remove INNODB_SYS_TABLESPACES.SPACE_TYPE. The type of a tablespace can be derived from the tablespace ID. A fixed number is used for the system tablespace and the temporary tablespace. All other tablespaces are single-table or single-partition tablespaces. i_s_locks_row_t::lock_type, lock_get_type_str(): Remove. This is a redundant field. Table and record locks can be distinguished by whether i_s_locks_row_t::lock_index is NULL. fill_trx_row(): Do not unnecessarily copy the constant strings that trx->op_info is pointing to. i_s_locks_row_t::lock_mode: Replace string with integer. lock_get_mode_str(), lock_get_trx_id(), lock_get_trx(): Remove. field_store_ulint(): Remove. |
||
|---|---|---|
| .. | ||
| mysql-test | ||
| rocksdb@926f3a78a6 | ||
| tools | ||
| unittest | ||
| .clang-format | ||
| .gitignore | ||
| atomic_stat.h | ||
| build_rocksdb.cmake | ||
| CMakeLists.txt | ||
| event_listener.cc | ||
| event_listener.h | ||
| get_rocksdb_files.sh | ||
| ha_rocksdb.cc | ||
| ha_rocksdb.h | ||
| ha_rocksdb_proto.h | ||
| logger.h | ||
| myrocks_hotbackup.py | ||
| properties_collector.cc | ||
| properties_collector.h | ||
| rdb_buff.h | ||
| rdb_cf_manager.cc | ||
| rdb_cf_manager.h | ||
| rdb_cf_options.cc | ||
| rdb_cf_options.h | ||
| rdb_compact_filter.h | ||
| rdb_comparator.h | ||
| rdb_datadic.cc | ||
| rdb_datadic.h | ||
| rdb_i_s.cc | ||
| rdb_i_s.h | ||
| rdb_index_merge.cc | ||
| rdb_index_merge.h | ||
| rdb_io_watchdog.cc | ||
| rdb_io_watchdog.h | ||
| rdb_mariadb_port.h | ||
| rdb_mariadb_server_port.cc | ||
| rdb_mariadb_server_port.h | ||
| rdb_mutex_wrapper.cc | ||
| rdb_mutex_wrapper.h | ||
| rdb_perf_context.cc | ||
| rdb_perf_context.h | ||
| rdb_psi.cc | ||
| rdb_psi.h | ||
| rdb_source_revision.h.in | ||
| rdb_sst_info.cc | ||
| rdb_sst_info.h | ||
| rdb_threads.cc | ||
| rdb_threads.h | ||
| rdb_utils.cc | ||
| rdb_utils.h | ||
| README | ||
| rocksdb-range-access.txt | ||
| ut0counter.h | ||
== Summary ==
This directory contains RocksDB-based Storage Engine (RDBSE) for MySQL,
also known as "MyRocks".
== Resources ==
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks
https://www.facebook.com/groups/MyRocks/
== Coding Conventions ==
The baseline for MyRocks coding conventions for the code in storage/rocksdb/
is based on the default clang format with a few minor changes. The file
storage/rocksdb/.clang-format describes conventions and can be integrated
with Vim or Emacs as described here:
http://releases.llvm.org/3.6.0/tools/clang/docs/ClangFormat.html#vim-integration
All code outside of storage/rocksdb/ should conform to the MySQL coding
conventions:
http://dev.mysql.com/doc/internals/en/coding-guidelines.html.
Several refinements:
0. There is an umbrella C++ namespace named "myrocks" for all MyRocks code.
1. We introduced "RDB" as the super-short abbreviation for "RocksDB". We will
use it as a name prefix, with different capitalization (see below), to ease
up code navigation with ctags and grep.
N.B. For ease of matching, we'll keep the variables and functions dealing
with sysvars as close as possible to the outside visible names of
sysvars, which start with "rocksdb_" prefix, the outward storage
engine name.
2. The names for classes, interfaces, and C++ structures (which act as
classes), start with prefix "Rdb_".
NB: For historical reasons, we'll keep the "ha_<storage_engine_name>" class
name for ha_rocksdb class, which is an exception to the rule.
3. The names for global objects and functions start with prefix "rdb_".
4. The names for macros and constants start with prefix "RDB_".
5. Regular class member names start with "m_".
6. Static class member names start with "s_".
7. Given the 80 character per line limit, we'll not always use full English
words in names, when a well known or easily recognizable abbreviation
exists (like "tx" for "transaction" or "param" for "parameter" etc).
8. When needing to disambiguate, we use different suffixes for that, like
"_arg" for a function argument/parameter, "_arr" for a C style array, and
"_vect" for a std::vector etc.
== Running Tests ==
To run tests from rocksdb, rocksdb_rpl or other rocksdb_* packages, use the
following parameters:
--default-storage-engine=rocksdb
--skip-innodb
--default-tmp-storage-engine=MyISAM
--rocksdb