mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
75d59ff967
This crash could happen if TRUNCATE TABLE indirectly failed to open a merge table due to failures to open underlying tables. Even if opening failed, the TRUNCATE TABLE code would try to invalidate the table in the query cache. Since this table had been closed and memory released, this could lead to a crash. This bug was introduced by a combination of the changes introduced by the patch for Bug#52044, where failing to open a table will cause opened tables to be closed. And the changes in patch for Bug#49938, where TRUNCATE TABLE uses the standard open tables function. This patch fixes the problem by setting the TABLE pointer to NULL before invalidating the query cache. Test case added to truncate_coverage.test.
228 lines
5.6 KiB
Text
228 lines
5.6 KiB
Text
#
|
|
# Code coverage testing of TRUNCATE TABLE.
|
|
#
|
|
# Ingo Struewing, 2009-07-20
|
|
#
|
|
|
|
--source include/have_debug_sync.inc
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
--let $MYSQLD_DATADIR= `SELECT @@datadir`
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
--enable_warnings
|
|
|
|
--echo #
|
|
--echo # Bug#20667 - Truncate table fails for a write locked table
|
|
--echo #
|
|
########
|
|
# Attack wait_while_table_is_used(). Kill query while trying to
|
|
# upgrade MDL.
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# Acquire a shared metadata lock on table by opening HANDLER for it and wait.
|
|
# TRUNCATE shall block on this metadata lock.
|
|
# We can't use normal DML as such statements would also block LOCK TABLES.
|
|
#
|
|
--echo #
|
|
--echo # connection con1
|
|
--connect (con1, localhost, root,,)
|
|
HANDLER t1 OPEN;
|
|
#
|
|
# Get connection id of default connection.
|
|
# Lock the table and start TRUNCATE, which will block on MDL upgrade.
|
|
#
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
let $ID= `SELECT @id := CONNECTION_ID()`;
|
|
LOCK TABLE t1 WRITE;
|
|
SET DEBUG_SYNC='mdl_upgrade_shared_lock_to_exclusive SIGNAL waiting';
|
|
send TRUNCATE TABLE t1;
|
|
#
|
|
# Get the default connection ID into a variable in an invisible statement.
|
|
# Kill the TRUNCATE query. This shall result in an error return
|
|
# from wait_while_table_is_used().
|
|
#
|
|
--echo #
|
|
--echo # connection con2
|
|
--connect (con2, localhost, root,,)
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
let $invisible_assignment_in_select = `SELECT @id := $ID`;
|
|
KILL QUERY @id;
|
|
--disconnect con2
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
--error ER_QUERY_INTERRUPTED
|
|
reap;
|
|
UNLOCK TABLES;
|
|
--echo #
|
|
--echo # connection con1
|
|
--connection con1
|
|
--echo # Release shared metadata lock by closing HANDLER.
|
|
HANDLER t1 CLOSE;
|
|
--disconnect con1
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
########
|
|
# Attack reopen_tables(). Remove form file.
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# Acquire a shared metadata lock on table by opening HANDLER for it and wait.
|
|
# TRUNCATE shall block on this metadata lock.
|
|
# We can't use normal DML as such statements would also block LOCK TABLES.
|
|
#
|
|
--echo #
|
|
--echo # connection con1
|
|
--connect (con1, localhost, root,,)
|
|
HANDLER t1 OPEN;
|
|
#
|
|
# Lock the table and start TRUNCATE, which will block on MDL upgrade.
|
|
#
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
LOCK TABLE t1 WRITE;
|
|
SET DEBUG_SYNC='mdl_upgrade_shared_lock_to_exclusive SIGNAL waiting';
|
|
send TRUNCATE TABLE t1;
|
|
#
|
|
# Remove datafile.
|
|
# Commit to let TRUNCATE continue.
|
|
#
|
|
--echo #
|
|
--echo # connection con2
|
|
--connect (con2, localhost, root,,)
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
--remove_file $MYSQLD_DATADIR/test/t1.frm
|
|
--disconnect con2
|
|
--echo #
|
|
--echo # connection con1
|
|
--connection con1
|
|
HANDLER t1 CLOSE;
|
|
--disconnect con1
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
--error ER_NO_SUCH_TABLE
|
|
reap;
|
|
UNLOCK TABLES;
|
|
--error ER_BAD_TABLE_ERROR
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
########
|
|
# Attack acquire_exclusive_locks(). Hold a global read lock.
|
|
# Non-LOCK TABLE case.
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# Start a transaction and execute a DML in it. Since 5.4.4 this leaves
|
|
# a shared meta data lock (MDL) behind. TRUNCATE shall block on it.
|
|
#
|
|
--echo #
|
|
--echo # connection con1
|
|
--connect (con1, localhost, root,,)
|
|
START TRANSACTION;
|
|
INSERT INTO t1 VALUES (2);
|
|
#
|
|
# Get connection id of default connection.
|
|
# Start TRUNCATE, which will block on acquire_exclusive_locks().
|
|
#
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
let $ID= `SELECT @id := CONNECTION_ID()`;
|
|
SET DEBUG_SYNC='mdl_acquire_lock_wait SIGNAL waiting';
|
|
send TRUNCATE TABLE t1;
|
|
#
|
|
# Get the default connection ID into a variable in an invisible statement.
|
|
# Kill the TRUNCATE query. This shall result in an error return
|
|
# from wait_while_table_is_used().
|
|
#
|
|
--echo #
|
|
--echo # connection con1
|
|
--connection con1
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
let $invisible_assignment_in_select = `SELECT @id := $ID`;
|
|
KILL QUERY @id;
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
--error ER_QUERY_INTERRUPTED
|
|
reap;
|
|
--echo #
|
|
--echo # connection con1
|
|
--connection con1
|
|
--echo # Release SW lock by committing transaction.
|
|
COMMIT;
|
|
--disconnect con1
|
|
--echo #
|
|
--echo # connection default
|
|
--connection default
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
--echo #
|
|
--echo # Bug#57659 Segfault in Query_cache::invalidate_data for TRUNCATE TABLE
|
|
--echo #
|
|
|
|
--echo # Note that this test case only reproduces the problem
|
|
--echo # when it is run with valgrind.
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1, m1;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1(a INT) engine=memory;
|
|
CREATE TABLE m1(a INT) engine=merge UNION(t1);
|
|
connect(con2, localhost, root);
|
|
|
|
--echo # Connection con1
|
|
connect(con1, localhost, root);
|
|
SET DEBUG_SYNC= 'open_tables_after_open_and_process_table SIGNAL opened WAIT_FOR dropped';
|
|
--echo # Sending:
|
|
--send TRUNCATE TABLE m1
|
|
|
|
--echo # Connection con2
|
|
connection con2;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR opened';
|
|
--echo # Sending:
|
|
--send FLUSH TABLES
|
|
|
|
--echo # Connection default
|
|
connection default;
|
|
--echo # Waiting for FLUSH TABLES to be blocked.
|
|
let $wait_condition= SELECT COUNT(*)=1 FROM information_schema.processlist
|
|
WHERE state= 'Waiting for table flush' AND info= 'FLUSH TABLES';
|
|
--source include/wait_condition.inc
|
|
SET DEBUG_SYNC= 'now SIGNAL dropped';
|
|
|
|
--echo # Connection con1
|
|
connection con1;
|
|
--echo # Reaping: TRUNCATE TABLE m1
|
|
--error ER_WRONG_MRG_TABLE
|
|
--reap
|
|
disconnect con1;
|
|
--source include/wait_until_disconnected.inc
|
|
|
|
--echo # Connection con2
|
|
connection con2;
|
|
--echo # Reaping: FLUSH TABLES
|
|
--reap
|
|
disconnect con2;
|
|
--source include/wait_until_disconnected.inc
|
|
|
|
--echo # Connection default
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
DROP TABLE m1, t1;
|