mirror of
https://github.com/MariaDB/server.git
synced 2025-01-21 22:34:18 +01:00
2f78abd21b
Problem: Some system functions that could return different values on
master and slave were not marked unsafe. In particular:
GET_LOCK
IS_FREE_LOCK
IS_USED_LOCK
MASTER_POS_WAIT
RELEASE_LOCK
SLEEP
SYSDATE
VERSION
Fix: Mark these functions unsafe.
mysql-test/extra/rpl_tests/rpl_stm_000001.test:
- The test does not work in mixed mode any more, since it tries to
simulate an error in the sql thread in a query that uses get_lock.
Since get_lock now causes the query to be logged in row format,
the error didn't happen. Hence, we now force statement mode.
- Warnings must be disabled when the unsafe query is issued.
- Replaced some save_master_pos+connection slave+sync_with_master
by sync_slave_with_master.
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
updated result file
mysql-test/suite/binlog/r/binlog_stm_row.result:
updated result file
mysql-test/suite/binlog/r/binlog_unsafe.result:
updated result file
mysql-test/suite/binlog/t/binlog_killed.test:
binlog_killed only works in statement format now, since
it switches to row mode in mixed mode.
mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
suppress warnings for unsafe statements
mysql-test/suite/binlog/t/binlog_stm_row.test:
- Suppress warnings in test that causes warnings.
- The test sets binlog format explicitly, so no need to execute it
twice.
mysql-test/suite/binlog/t/binlog_unsafe.test:
Added test for all unsafe system functions. This test also includes
system functions that were unsafe prior to BUG#47995.
mysql-test/suite/rpl/r/rpl_err_ignoredtable.result:
updated result file
mysql-test/suite/rpl/r/rpl_get_lock.result:
updated result file
mysql-test/suite/rpl/r/rpl_nondeterministic_functions.result:
new result file
mysql-test/suite/rpl/r/rpl_stm_000001.result:
updated result file
mysql-test/suite/rpl/r/rpl_trigger.result:
updated result file
mysql-test/suite/rpl/t/rpl_err_ignoredtable.test:
- suppress warnings for unsafe statement
- replaced save_master_pos+connection slave+sync_with_master
with sync_slave_with_master
mysql-test/suite/rpl/t/rpl_get_lock.test:
update test case that causes new warnings
mysql-test/suite/rpl/t/rpl_nondeterministic_functions.test:
Added new test case for nondeterministic functions.
mysql-test/suite/rpl/t/rpl_trigger.test:
update test case that causes new warnings
sql/item_create.cc:
Marked some system functions unsafe.
sql/item_strfunc.cc:
Clarified comment related to this bug.
sql/sql_yacc.yy:
Marked sysdate unsafe.
53 lines
1.4 KiB
Text
53 lines
1.4 KiB
Text
# ==== Purpose ====
|
|
#
|
|
# Test that nondeterministic system functions are correctly replicated.
|
|
#
|
|
# (Some functions are only correctly replicated if binlog_format=MIXED
|
|
# or ROW. See binlog_unsafe.test for a test that those variables are
|
|
# indeed unsafe.)
|
|
#
|
|
# ==== Implementation ====
|
|
#
|
|
# We insert the values of each unsafe function into a table. Then we
|
|
# replicate and check that the table is identical on slave.
|
|
#
|
|
# ==== Related bugs ====
|
|
#
|
|
# BUG#47995
|
|
|
|
--source include/master-slave.inc
|
|
|
|
CREATE TABLE t1 (a VARCHAR(1000));
|
|
|
|
# We replicate the connection_id in the query_log_event
|
|
INSERT INTO t1 VALUES (CONNECTION_ID());
|
|
--connection master1
|
|
INSERT INTO t1 VALUES (CONNECTION_ID());
|
|
|
|
# We replicate the TIMESTAMP variable, so the following functions that
|
|
# are affected by the TIMESTAMP variable should be safe to replicate.
|
|
INSERT INTO t1 VALUES
|
|
(CURDATE()),
|
|
(CURRENT_DATE()),
|
|
(CURRENT_TIME()),
|
|
(CURRENT_TIMESTAMP()),
|
|
(CURTIME()),
|
|
(LOCALTIME()),
|
|
(LOCALTIMESTAMP()),
|
|
(NOW()),
|
|
(UNIX_TIMESTAMP()),
|
|
(UTC_DATE()),
|
|
(UTC_TIME()),
|
|
(UTC_TIMESTAMP());
|
|
|
|
# We replicate the random seed in a rand_log_event
|
|
INSERT INTO t1 VALUES (RAND());
|
|
# We replicate the last_insert_id in an intvar_log_event
|
|
INSERT INTO t1 VALUES (LAST_INSERT_ID());
|
|
|
|
--sync_slave_with_master
|
|
--let $diff_table_1= master:test.t1
|
|
--let $diff_table_2= slave:test.t1
|
|
--source include/diff_tables.inc
|
|
|
|
DROP TABLE t1;
|